birkeh/api-themoviedb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use isEmpty in tests

Browse Source
This commit is contained in:
Stuart Boston
2017-07-07 11:23:54 +01:00
parent 8a3af38b0c
commit 3a1251777e
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/com/omertron/themoviedbapi/TestSuite.java
+1 -1
View File
@@ -137,7 +137,7 @@ public class TestSuite {
assertTrue(message + MISSING_ID, test.getId() > 0);
assertTrue(message + MISSING_NAME, StringUtils.isNotBlank(test.getName()));
assertTrue(message + ": Missing overview", StringUtils.isNotBlank(test.getOverview()));
assertTrue(message + ": Missing episodes", test.getEpisodes().size() > 0);
assertFalse(message + ": Missing episodes", test.getEpisodes().isEmpty());
}
public static void test(ExternalID test) {
src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java
+3 -2
View File
@@ -32,6 +32,7 @@ import com.omertron.themoviedbapi.model.movie.MovieInfo;
import com.omertron.themoviedbapi.model.person.PersonFind;
import com.omertron.themoviedbapi.model.tv.TVBasic;
import com.omertron.themoviedbapi.results.ResultList;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import org.junit.BeforeClass;
import org.junit.Test;
@@ -105,12 +106,12 @@ public class TmdbSearchTest extends AbstractTests {
// Try a movie with less than 1 page of results
ResultList<MovieInfo> movieList = instance.searchMovie("Blade Runner", 0, "", null, 0, 0, SearchType.PHRASE);
TestSuite.test(movieList, "Movie 1");
assertTrue("No movies found, should be at least 1", movieList.getResults().size() > 0);
assertFalse("No movies found, should be at least 1", movieList.getResults().isEmpty());
// Try a russian langugage movie
movieList = instance.searchMovie("О чём говорят мужчины", 0, LANGUAGE_RUSSIAN, null, 0, 0, SearchType.PHRASE);
TestSuite.test(movieList, "Movie 2");
assertTrue("No 'RU' movies found, should be at least 1", movieList.getResults().size() > 0);
assertFalse("No 'RU' movies found, should be at least 1", movieList.getResults().isEmpty());
// Try a movie with more than 20 results
movieList = instance.searchMovie("Star Wars", 0, LANGUAGE_ENGLISH, null, 0, 0, SearchType.PHRASE);