From 3a1251777ebf81c20a7403ddee61091c4f0e4570 Mon Sep 17 00:00:00 2001 From: Stuart Boston Date: Fri, 7 Jul 2017 11:23:54 +0100 Subject: [PATCH] Use isEmpty in tests --- src/test/java/com/omertron/themoviedbapi/TestSuite.java | 2 +- .../com/omertron/themoviedbapi/methods/TmdbSearchTest.java | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/test/java/com/omertron/themoviedbapi/TestSuite.java b/src/test/java/com/omertron/themoviedbapi/TestSuite.java index dfb490d31..a1d1b4bde 100644 --- a/src/test/java/com/omertron/themoviedbapi/TestSuite.java +++ b/src/test/java/com/omertron/themoviedbapi/TestSuite.java @@ -137,7 +137,7 @@ public class TestSuite { assertTrue(message + MISSING_ID, test.getId() > 0); assertTrue(message + MISSING_NAME, StringUtils.isNotBlank(test.getName())); assertTrue(message + ": Missing overview", StringUtils.isNotBlank(test.getOverview())); - assertTrue(message + ": Missing episodes", test.getEpisodes().size() > 0); + assertFalse(message + ": Missing episodes", test.getEpisodes().isEmpty()); } public static void test(ExternalID test) { diff --git a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java index 81b7f83af..0e3a75704 100644 --- a/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java +++ b/src/test/java/com/omertron/themoviedbapi/methods/TmdbSearchTest.java @@ -32,6 +32,7 @@ import com.omertron.themoviedbapi.model.movie.MovieInfo; import com.omertron.themoviedbapi.model.person.PersonFind; import com.omertron.themoviedbapi.model.tv.TVBasic; import com.omertron.themoviedbapi.results.ResultList; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import org.junit.BeforeClass; import org.junit.Test; @@ -105,12 +106,12 @@ public class TmdbSearchTest extends AbstractTests { // Try a movie with less than 1 page of results ResultList movieList = instance.searchMovie("Blade Runner", 0, "", null, 0, 0, SearchType.PHRASE); TestSuite.test(movieList, "Movie 1"); - assertTrue("No movies found, should be at least 1", movieList.getResults().size() > 0); + assertFalse("No movies found, should be at least 1", movieList.getResults().isEmpty()); // Try a russian langugage movie movieList = instance.searchMovie("О чём говорят мужчины", 0, LANGUAGE_RUSSIAN, null, 0, 0, SearchType.PHRASE); TestSuite.test(movieList, "Movie 2"); - assertTrue("No 'RU' movies found, should be at least 1", movieList.getResults().size() > 0); + assertFalse("No 'RU' movies found, should be at least 1", movieList.getResults().isEmpty()); // Try a movie with more than 20 results movieList = instance.searchMovie("Star Wars", 0, LANGUAGE_ENGLISH, null, 0, 0, SearchType.PHRASE);