You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Gems/Atom/Feature/Common/Code/Source
Ken Pruiksma 9df995dd26
Temporal anti-aliasing and constrast adaptive sharpening (#1161)
First version of temporal antialiasing and contrast adaptive sharpening for GA. Works well in most cases but still has a few issues that will need additional time. This is only the passes and shaders with no exposure to the editor. TAA and CAS can be turned on by enabling their respective passes in the pipeline.

All of the code has been previously reviewed in smaller PRs into the taa_staging branch:
aws-lumberyard-dev#29
aws-lumberyard-dev#53
aws-lumberyard-dev#73
aws-lumberyard-dev#79
aws-lumberyard-dev#84

Main issues:

- Bloom doesn't play nice with TAA and seems to greatly amplify any flickering
- AuxGeom jitters with the camera, so TAA doesn't currently work well in editor
- Transparencies don't have correct motion vectors. History rectification keeps this from looking too bad, but could still be improved
- There is still more that could be done to inhibit flickering, usually from specular aliasing
- Motion vectors aren't correct on POM unless PDO is turned on, which can result in some blurring during motion.
- SSAO can contribute to flickering in its default half res configuration. Changing this to full res mitigates the problem.

Squashed merge of the following:

* [ATOM-13987] Initial checkin of Taa pass.

* TAA pass setup WIP. (does not work yet due to pass configuration issues).

* Taa WIP - Camera motion vectors fixed and hooked up. TAA does simple reprojection and rejection based on depth.

* Small update to use lerp and add some comments.

* Fix issue with attachments not being set up on bindings at initialization. Fixing issue with half-pixel offsets in TAA shader

* - Motion vector passes now use the same output with mesh motion vectors overwriting camera motion vectors.
- Taa pass now works with multiple pipelines.
- Cleaned up TAA shader a bit.

* Fixes from PR review.

* Adding check for multiple attachments of the same name with different resources in Pass::ImportAttachments().

* Adding camera jitter with configurable position count. Updated TAA to blend in tonemapped space.

* Fixes from PR review. Fixing camera motion vectors for background (infinite distance)

* Updates to taa shader from PR review

* Adding a rcp input color size.

* Fix comment on PassAttachment::Update()

* Updates for PR review.

* Fixing missing const on the FrameAttachment* in Pass's call to FindAttachment()

* Taa WIP - Adding filtering to both the current pixel and history. Adding rectification based on variance clipping. Adding some basic anti-flickering. Removing rejection based on depth.

* Updates from PR code review. Mostly better commenting and naming.

* Adding contrast adaptive sharpening based on AMD FidelityFX CAS to help with the softness added by TAA.

* Changing to using luminance for sharpening instead of just green. Added some comments.

* Moving Taa's NaN check to a better location. Disabling TAA and sharpening in prep for check in.

* Updates from PR feedback.
5 years ago
..
ACES Integrating up through commit 90f050496 5 years ago
AuxGeom Merge branch 'main' into non-uniform-scale-mesh 5 years ago
Builders Initial commit 5 years ago
Checkerboard Integrating up through commit 90f050496 5 years ago
CoreLights ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
Decals update usages of transform vector scale 5 years ago
DiffuseGlobalIllumination Added DiffuseGlobalIlluminationFeatureProcessor and moved the DiffuseProbeGrid files to the DiffuseGlobalIllumination directory 5 years ago
DisplayMapper PR feedback and fixing TrackView 5 years ago
ImGui Fix issue found in PR 5 years ago
ImageBasedLights Integrating up through commit 90f050496 5 years ago
LookupTable Initial commit 5 years ago
LuxCore Initial commit 5 years ago
Material updating includes 5 years ago
Math ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
Mesh Merge branch 'main' into Atom/dmcdiar/ATOM-15555 5 years ago
MorphTargets Fix for ATOM-15488 : Rendering out an animation with shadows crashes the editor (#794) 5 years ago
OcclusionCullingPlane Changed the occlusion culling plane model to be on the XZ plane and adjusted the corner point computations 5 years ago
Platform Remove unrelated files 5 years ago
PostProcess ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
PostProcessing Temporal anti-aliasing and constrast adaptive sharpening (#1161) 5 years ago
RayTracing ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
ReflectionProbe update usages of transform vector scale 5 years ago
ReflectionScreenSpace Integrating up through commit 90f050496 5 years ago
ScreenSpace Integrating latest 47acbe8 5 years ago
Shadows Integrating github/staging through commit 5f214be 5 years ago
SkinnedMesh Merging WrinkleMask support from 1.0 to main (#680) 5 years ago
SkyBox ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
TransformService ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
Utils ATOM-15658 Better option of CreateCommonBuffer requires unique buffer name (#1133) 5 years ago
CommonModule.cpp Integrating latest 47acbe8 5 years ago
CommonSystemComponent.cpp Temporal anti-aliasing and constrast adaptive sharpening (#1161) 5 years ago
CommonSystemComponent.h ATOM-4661 Improvement with pass templates registration from data (#735) 5 years ago
EditorCommonSystemComponent.cpp ATOM-13216 Delete Deprecated Functors 5 years ago
EditorCommonSystemComponent.h Initial commit 5 years ago
FrameCaptureSystemComponent.cpp Fix window handle retrieval in frame capture system. (#1073) 5 years ago
FrameCaptureSystemComponent.h Integrating latest 47acbe8 5 years ago
ProfilingCaptureSystemComponent.cpp ATOM-13791 Editor: ImGui profiling tools doesn't work correctly due to disabled RenderPipelines 5 years ago
ProfilingCaptureSystemComponent.h Initial commit 5 years ago
RenderCommon.h Minor changes to comment. 5 years ago