You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
b176697ce9
The problem was... After a MaterialAsset reload, there could be two different versions of the MaterialAsset in memory: the old one and the reloaded one. The old one is still connected to buses and can send reinitialization messages when other things reload or reinitialize. So when the shader asset reloaded, both the old and new MaterialAsset were sending reinitialization messages. Material::OnMaterialAssetReinitialized was using the materialAsset parameter to initialize the Material, and the latest call to OnMaterialAssetReinitialized was for the *old* MaterialAsset. The solution is to use the m_materialAsset member when reinitializing the Material. I also added checks in a couple places to skip unnecessary reinitialization, and added comments in the bus headers to warn developers about this issue. Testing: Added a new step to ASV's MaterialHotReloadTest.bv.lua script for the error scenario, and this now passes. Ran ASV full test suite, both dx12 and vulkan, only known issues occurred. |
5 years ago | |
|---|---|---|
| .. | ||
| Buffer | 5 years ago | |
| ColorManagement | 5 years ago | |
| DynamicDraw | 5 years ago | |
| GpuQuery | 5 years ago | |
| Image | 5 years ago | |
| Material | 5 years ago | |
| Model | 5 years ago | |
| Pass | 5 years ago | |
| Shader | 5 years ago | |
| AuxGeomFeatureProcessorInterface.cpp | 5 years ago | |
| Culling.cpp | 5 years ago | |
| FeatureProcessor.cpp | 5 years ago | |
| FeatureProcessorFactory.cpp | 5 years ago | |
| MeshDrawPacket.cpp | 5 years ago | |
| PipelineState.cpp | 5 years ago | |
| RPISystem.cpp | 5 years ago | |
| RPIUtils.cpp | 5 years ago | |
| RenderPipeline.cpp | 5 years ago | |
| Scene.cpp | 5 years ago | |
| View.cpp | 5 years ago | |
| ViewportContext.cpp | 5 years ago | |
| ViewportContextManager.cpp | 5 years ago | |
| WindowContext.cpp | 5 years ago | |