You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Framework/AzToolsFramework/Tests/Prefab
Danilo Aimini 80f62d0523
LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
5 years ago
..
Benchmark Fixed unit test compile error with spawnables 5 years ago
Spawnable Integrating github/staging through commit ab87ed9 5 years ago
MockPrefabFileIOActionValidator.cpp Integrating up through commit 90f050496 5 years ago
MockPrefabFileIOActionValidator.h Integrating up through commit 90f050496 5 years ago
PrefabDuplicateTests.cpp [LYN-2255] Updated Prefab Duplicate to select the newly duplicated entities. Also addressed some other PR feedback. 5 years ago
PrefabEntityAliasTests.cpp LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700) 5 years ago
PrefabInstanceToTemplatePropagatorTests.cpp Integrating up through commit 90f050496 5 years ago
PrefabInstantiateTests.cpp Integrating up through commit 90f050496 5 years ago
PrefabLoadTemplateTests.cpp Integrating up through commit 90f050496 5 years ago
PrefabTestComponent.cpp Integrating up through commit 90f050496 5 years ago
PrefabTestComponent.h Integrating up through commit 90f050496 5 years ago
PrefabTestData.cpp Initial commit 5 years ago
PrefabTestData.h Integrating up through commit 90f050496 5 years ago
PrefabTestDataUtils.cpp Integrating up through commit 90f050496 5 years ago
PrefabTestDataUtils.h Integrating up through commit 90f050496 5 years ago
PrefabTestDomUtils.cpp Integrating up through commit 90f050496 5 years ago
PrefabTestDomUtils.h Integrating up through commit 90f050496 5 years ago
PrefabTestFixture.cpp [LYN-2255] Made PrefabTestFixture have the prefab system enabled so that the duplicate tests pass on Jenkins (they rely on the PrefabEditorEntityOwnershipInterface being registered). 5 years ago
PrefabTestFixture.h [LYN-2255] Made PrefabTestFixture have the prefab system enabled so that the duplicate tests pass on Jenkins (they rely on the PrefabEditorEntityOwnershipInterface being registered). 5 years ago
PrefabTestUndoFixture.cpp Integrating latest 47acbe8 5 years ago
PrefabTestUndoFixture.h Integrating latest 47acbe8 5 years ago
PrefabTestUtils.h Initial commit 5 years ago
PrefabUndoLinkTests.cpp Initial draft for getting instantiation to work immediately after creation is undone 5 years ago
PrefabUndoTests.cpp Integrating github/staging through commit b0dd7ed 5 years ago
PrefabUpdateInstancesTests.cpp Integrating github/staging through commit ab87ed9 5 years ago
PrefabUpdateTemplateTests.cpp Integrating up through commit 90f050496 5 years ago
PrefabUpdateWithPatchesTests.cpp Integrating up through commit 90f050496 5 years ago
SpawnableCreateTests.cpp Fixed unit test compile error with spawnables 5 years ago
SpawnableRemoveEditorInfoTestFixture.cpp Integrating up through commit 90f050496 5 years ago
SpawnableRemoveEditorInfoTestFixture.h Integrating up through commit 90f050496 5 years ago
SpawnableRemoveEditorInfoTests.cpp Integrating latest 47acbe8 5 years ago
SpawnableSortEntitiesTestFixture.cpp Integrating latest 47acbe8 5 years ago
SpawnableSortEntitiesTestFixture.h Integrating latest 47acbe8 5 years ago
SpawnableSortEntitiesTests.cpp Integrating latest 47acbe8 5 years ago