You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Framework
Danilo Aimini 80f62d0523
LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
5 years ago
..
AtomCore ATOM-15358 : Culling concurrency checker fails in AtomSampleViewer (merge from 1.0->main) 5 years ago
AzAndroid/java/com/amazon Remove bootstrap.cfg and references to it. 5 years ago
AzAutoGen Add newlines to the end of all files 5 years ago
AzCore Formatting-only change - Update Manipulator and Viewport AzToolsFramework files (#1143) 5 years ago
AzFramework fixed missing methods in SC from Trigger and Collision events (#1185) 5 years ago
AzGameFramework External Project Build Path Support using SDK Binaries (#690) 5 years ago
AzManipulatorTestFramework Formatting-only change - Update Manipulator and Viewport AzToolsFramework files (#1143) 5 years ago
AzNetworking SPEC-2513 Fixes to enable w4457 5 years ago
AzQtComponents Main toolbar consolidation and cleanup (#1167) 5 years ago
AzTest Remove AZ_TRAIT_DISABLE_ASSET_JOB_PARALLEL_TESTS from Linux traits (#1018) 5 years ago
AzToolsFramework LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700) 5 years ago
Crcfix Add newlines to the end of all files 5 years ago
GFxFramework Add newlines to the end of all files 5 years ago
GridMate update network code to use uniform scale on Transform 5 years ago
Tests {LYN-4230} Fixed loading *.pak files in Release builds (#1127) 5 years ago
CMakeLists.txt Add newlines to the end of all files 5 years ago