Nicholas Van Sickle
e080ade885
Switch high perf allocator back on for containers, modest perf boost
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 14:20:16 -08:00
Nicholas Van Sickle
d9ac3c2120
Tidy up Type enum
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 13:56:10 -08:00
Nicholas Van Sickle
cc120c772c
Add RapidjsonCopyAndMutate to compare w/ shallow copy
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 12:58:52 -08:00
Nicholas Van Sickle
c53c97cf5f
Add another round of benchmarks
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-11 15:54:57 -08:00
Nicholas Van Sickle
1f2635d24b
Switch to the high pref heap allocator, roll back pool interface changes
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 16:35:26 -08:00
Nicholas Van Sickle
809ee2dce9
Fix "force string copy" logic
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 16:18:38 -08:00
Nicholas Van Sickle
1af39a5c5c
Add benchmarks, some light optimizations like SSO
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 15:57:52 -08:00
Nicholas Van Sickle
947951b6c7
Add copy on write tests
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 23:43:22 -08:00
Nicholas Van Sickle
15e0bb1693
Add tests, fix missing bool in Accept and operator[] insert
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 21:37:22 -08:00
Nicholas Van Sickle
a2d474cc4f
Add some intial tests
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 17:47:01 -08:00
Nicholas Van Sickle
e7c92b5658
Move ValueWriter out, add DeepCompareIsEqual
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 15:25:20 -08:00
Nicholas Van Sickle
fada7ace23
Add visitor support to Value
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-08 22:22:18 -08:00
Nicholas Van Sickle
f36255b22a
Initial value implementation
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-08 13:57:24 -08:00
Nicholas Van Sickle
6cf805256b
Make backend write API string-based
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-06 15:55:35 -08:00
Nicholas Van Sickle
ea9d7c9d82
Add optional size parameter to ReadFromBufferInPlace
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-06 10:45:45 -08:00
Nicholas Van Sickle
1c42cd98cc
Address a bit more review feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-06 10:31:35 -08:00
Nicholas Van Sickle
8165f54c05
Use temporary lifetimes for test
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 13:52:16 -08:00
Nicholas Van Sickle
037a93406a
Fix a couple format string issues
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 12:40:52 -08:00
Nicholas Van Sickle
f2f7dad972
Remove FormatVisitorErrorMessage
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 12:26:19 -08:00
Nicholas Van Sickle
016e261f36
Add DomUtils
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 11:25:15 -08:00
Nicholas Van Sickle
59a2216584
Fix a build issue
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-02 17:49:29 -08:00
Nicholas Van Sickle
4dbce4275b
Refactor the interface after some chatting with @amazon-employee-dm
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-02 17:46:07 -08:00
Nicholas Van Sickle
1aaa267585
Fix one last bit of minor feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:49:48 -08:00
Nicholas Van Sickle
2dddb97b7c
One last round of stray review feedback I missed
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:32:23 -08:00
Nicholas Van Sickle
d519d4cb03
Improve performance for both in-place and copy parsing (faster than AZ::JsonSerializationUtils::ReadJsonString now!)
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 16:22:48 -08:00
Nicholas Van Sickle
e0508ddefc
Make JsonBackend templated
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-01 12:10:22 -08:00
Nicholas Van Sickle
f87021d856
Expose JSON parse flag options
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 22:08:48 -08:00
Nicholas Van Sickle
a9c05372d5
API tweaks
...
- Use ref types
- Support using rapidjson::Value in lieu of rapidjson::Document
- Use the existing JSON comparison util function in tests
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 18:00:59 -08:00
Nicholas Van Sickle
5dbe9e387b
Address some review feedback, remove DomBackendRegistry
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 12:10:16 -08:00
Nicholas Van Sickle
5e4bdac2e1
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomJson
2021-11-29 09:40:56 -08:00
amzn-sean
b882eddca8
fix dev break. AZStd::fixed_vector cannot be constexp error ( #5995 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-11-29 14:05:03 +00:00
lumberyard-employee-dm
97106f9e60
Adding missing C++20 std::erase implementations ( #5735 )
...
There were already implementations for std::erase_if.
This adds the counterpart AZStd::erase versions
resolves #5734
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-26 11:31:13 -06:00
Tom Hulton-Harrop
b0c522be51
Rename QtEventToAzInputManager.h/cpp to QtEventToAzInputMapper.h/cpp ( #5905 )
...
* rename QtEventToAzInputManager.h/cpp to QtEventToAzInputMapper.h/cpp to match type name
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update #includes to refer to QtEventToAzInputMapper.h
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-25 09:43:57 +00:00
Artur K
eca2e36687
Fix clang 13 compilation problems ( #5791 )
...
* Fix clang 13 compilation problems
Re-instated ShowPlayedSequencesDebug logic by introducing no-op lambda
which replaces missing `Draw2dLabel` functionality ( added TODO marker
there )
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* apply review suggestions
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Fix type in assert message
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2021-11-25 09:24:39 +00:00
John
d75b6f9d64
Add call to ViewportEditorModeNotifications::Reflect
...
Signed-off-by: John <jonawals@amazon.com >
2021-11-24 10:41:48 +00:00
John
7b9038e750
Fix warning as error.
...
Signed-off-by: John <jonawals@amazon.com >
2021-11-24 10:40:53 +00:00
John Jones-Steele
2259cb3dc0
Moved TerrainDataRquestBus to AzFrameworkTestShared ( #5835 )
...
* Moved TerrainDataRquestBus to AzFrameworkTestShared
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-11-24 09:29:40 +00:00
Michael Pollind
1649d86568
chore: update static const declerations in AzQtComponent ( #5826 )
...
* chore: update static const declerations in AzQtComponent
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: update static const
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-11-24 09:17:54 +00:00
Tom Hulton-Harrop
5bd751531d
Update return type for viewport screen functions ( #5803 )
...
* update return type for viewport screen functions
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add tests for AZ::Matrix3x4::CreateFromMatrix4x4 and add TransformPoint to Matrix3x4
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update NDC -> Ndc
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following review feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates and improvements following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add forward declaration of Matrix3x4 type
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update where forward declarations are defined for Matrix3x4
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-24 09:17:43 +00:00
Ronald Koppers
7975629a7a
Merge pull request #5872 from aws-lumberyard-dev/FixedVectorOptimization
...
Performance improvement for fixed_vector.
2021-11-23 15:43:24 -08:00
Junbo Liang
7086aa1a75
Merge commit 'dbc5d7a8bc5404b80fbc38b6b004aaa1f9e06df9' into junbo/gitflow_211123_o3de
2021-11-23 13:28:04 -08:00
Junbo Liang
e2649512b2
Merge commit '4be1e68bad1b627668a4517b00526bba6cc7acea' into junbo/gitflow_211123_o3de
2021-11-23 13:16:55 -08:00
Junbo Liang
6a40d21b66
Merge commit '4ee2f341dc0dc709aedb446b57d5cca61b86160d' into junbo/gitflow_211123_o3de
2021-11-23 13:14:59 -08:00
Junbo Liang
3b39be7fd0
Merge commit '4ad35f424e01356a4745e5f50631dc050b328c98' into junbo/gitflow_211123_o3de
2021-11-23 13:14:57 -08:00
AMZN-koppersr
389f29f0e7
Performance improvement for fixed_vector
...
AZStd::fixed_vector had all its functions marked with constexpr, but this requires all member variables to be fully initialized. This meant that the internal array used to store elements always has to be fully initialized. This was done for trivial classes but not for non-trivial classes. As a result trivial classes always did a memset (or more optimized versions for smaller buffers) while the non-trivial version couldn't actually be stored in a constexpr variable. Since AZStd::fixed_vector is meant to be dynamic the choice was made to remove the constexpr from all non-static member functions in favor of avoiding the overhead of memset, which profiling showed was a considerable overhead depending on the reserved size. If a truly constexpr array is needed than AZStd::array is a better choice as that's designed to not by dynamic.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2021-11-23 09:26:37 -08:00
Tom Hulton-Harrop
ea0afae502
Fix for how viewport icons highlight (accent) when sticky select is disabled ( #5833 )
...
* fix for how viewport icons highlight when sticky select is disabled
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* naming - update highlight to accent
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-23 12:28:38 +00:00
moraaar
ab1b6d057d
Fixed unused variable warning in Release configuration in Linux. ( #5830 )
...
Signed-off-by: moraaar <moraaar@amazon.com >
2021-11-22 13:25:29 +00:00
puvvadar
6eec6c8f8e
Merge pull request #5752 from aws-lumberyard-dev/puvvadar/gitflow_211118_o3de
...
Merge stabilization/2110
2021-11-19 15:46:16 -08:00
Esteban Papp
dbc5d7a8bc
Cherry-pick of Linux deb package to stabilization ( #5778 )
...
* Cherry-pick 49e8f35858
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Merging differences from development of other changes that need to be there for deb packaging
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Picks a needed change for the installer
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes warning in mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Takes version from environment if defined
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Do not pick up version if it is empty string since that will also break version comparison
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* creating temp directories if they dont exist
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* removing a dependency to itself (Multiplayer.Builders is an alias of Multiplayer.Editor)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Filters which runtime dependencies are passed from private build dependencies to only those that are actual targets.
This avoids something like a "d3d12" private build dependency from being passed to the runtime dependencies
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-11-19 14:07:25 -08:00
amzn-mike
af85060856
[SPEC-7644] Cherry Pick - ParallelDeepAssetReferences is failing intermittently ( #5797 )
...
* [SPEC-7644] ParallelDeepAssetReferences is failing intermittently (#5721 )
* Fixed race condition caused by trying to handle asset ready event before asset container has finished filling out all the data structures.
Added check to only handle asset ready once init is complete
Added unit test to verify fix
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Re-enable test
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing space to error message
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add comment on sleep
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Collapse nested namespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Collapse nested namespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
(cherry picked from commit 56900484fc )
# Conflicts:
# Code/Framework/AzCore/AzCore/Asset/AssetContainer.cpp
* Fix indentation
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-11-19 11:22:43 -08:00