deb3568aaa
Fix up a couple opaque value cases
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-21 16:19:32 -08:00
68c93273d6
Add 8 and 16 bit numeric type API
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-21 16:09:11 -08:00
37330c43a9
Address some more Generic Dom Value perf feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-21 15:47:42 -08:00
1da99eaea0
Add type-safe GetTypeIndex instead of hardcoded index lookups
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-20 18:27:00 -08:00
bbd00adade
Address some AZ::Dom::Value feedback
...
- Use a vector for shared string storage (to avoid the double heap allocation for AZStd::string)
- Use a shared heap allocated any for opaque types (instead of an unsafe ref)
- Add a string comparison key lookup benchmark to measure the impact of Name
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-20 16:54:06 -08:00
748f2a5c05
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2021-12-20 11:51:15 -08:00
bb14675db7
Fix tests Debug ( #6405 )
...
Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com >
2021-12-20 16:53:41 +00:00
d5b9cf10cf
Collection of miscellaneous PAL changes required for restricted platforms. ( #6482 )
...
Signed-off-by: bosnichd <bosnichd@amazon.com >
2021-12-20 08:15:10 -07:00
fea4d0e6b1
adding TimeSystem unit tests ( #6446 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-12-20 14:32:25 +00:00
2ddf55474e
chore: remove "using namespace " from AZCore Memory ( #6373 )
...
* chore: remove "using namespace " from AZCore Memory
REF: https://github.com/o3de/o3de/issues/6281
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: fix formatting
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: fix indentation for AllocatorBase.cpp
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: fix formatting
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: address minor checkstyle problems
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-12-17 13:26:31 +00:00
d20aa935ba
Quaternion to scaled-axis angle representation (and back) helpers ( #6421 )
...
Direct conversion helpers for quaternion to the scaled axis-angle representation and back without the need to convert them first to the axis-angle format and manually scale (or normalize on the way back). This also avoids having to deal with the special case of an identity representation which is 0,0,0 in the scaled axis-angle format while our convention for axis-angle is 0,1,0 for the axis and 0 for the angle.
Added unit tests that check the conversion round-trips from quaternion -> (scaled) axis-angle -> quaternion as well as comparing the scaled axis-angle representations from the direct helper functions as well as the axis-angle while manually scaling/normalizing.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
2021-12-17 09:43:35 +01:00
18cfcd659b
Fix missing parent class reflection for ProceduralPrefabSystemComponent ( #6413 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-16 07:49:32 -08:00
f4ae3a5b7d
Fix: Find function reports code with a line offset of 1 ( #6331 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
2021-12-16 15:39:03 +00:00
01770a1574
Fixes for CameraInput handling ( #6425 )
...
* add temporary optimize off calls
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix + tests for camera input issue
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* simplify boolean expression (PR feedback)
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:39 +00:00
d065eb9498
Initial improvements to fix viewport icon selection and draw order ( #6284 )
...
* wip fixes for entity viewport icons displaying in the correct order and handling selection correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add additional comment about z value
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move manual sorting and some small tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following initial round of PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* additional changes to support tests for entity icon intersection
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add support to enable/disable icons separately from helpers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* final tests added and small tidy-up to display EntityId correctly
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update some manipulator test framework calls after utility functions were moved
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for implicit cast
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* move icon scale values to AZ_CVARS
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix failing tests caught in AR and update some naming conventions for tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update naming convention for members of ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update other references to ProjectedViewportRay
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update more references to ProjectedViewportRay change
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update menus for python tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-12-16 09:35:23 +00:00
10cb618ba6
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2021-12-15 10:24:39 -08:00
352b4ab690
Make DomValue final
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-15 10:23:58 -08:00
33bfdc0bd3
corrected implementation of GetRealElapseTime ( #6422 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-12-15 16:44:38 +00:00
e2679aad57
Merge pull request #6195 from tjmgd/bug-keyword-22
...
keyword bug fixed
2021-12-15 10:00:58 -06:00
50e06ea8c5
Merge pull request #6328 from tjmgd/bug-lua-debugging-62
...
Fix: Lua script debugging loading problem
2021-12-15 09:58:11 -06:00
0a31483faa
Merge pull request #6333 from tjmgd/bug-lua-breakpoint-67
...
Fix: Lua breakpoint error
2021-12-15 09:57:54 -06:00
f3d426e638
Merge pull request #4965 from aws-lumberyard-dev/APTetherLifetimeOnByDefault
...
Enable lifetime tethering of the AP by default
2021-12-14 09:31:24 -07:00
8b7cdd45a3
Merge pull request #6344 from aws-lumberyard-dev/daimini/ReadOnly/TransformResetFix
...
Disable invalid operations related to procedural prefabs in the Inspector
2021-12-14 09:33:43 -06:00
aa9799a63b
Use the high perf allocator for DomValueWriter
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 15:05:17 -08:00
d951e1f652
LyShine cleanup of TODOs ( #6138 )
...
* LyShine cleanup pass for Atom conversion
Signed-off-by: abrmich <abrmich@amazon.com >
* Add GHI numbers to comments
Signed-off-by: abrmich <abrmich@amazon.com >
2021-12-14 00:00:26 +01:00
04669544cc
Remove unused trait AZ_TRAIT_DISABLE_FAILED_MULTIPLAYER_GRIDMATE_TESTS ( #6389 )
...
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-13 14:54:57 -08:00
7188529652
Fix for GHI-4644: mesh optimization breaking skin influences (DCO fix) ( #6336 )
...
* Average incoming skin influences when multiple vertices have been welded. This is one option which will average out the weights even if two welded vertices have differing boneIds, but we probably also need to add the influences earlier in the process and enforce a process where the vertices do not get welded if they have influences with differing boneIds
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Move skin influences from MeshBuilderSkinningInfo to the vertex attribute layers so they are considered when choosing which vertices can be welded and so they are not duplicated when compatible vertices have been welded
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Updating unit tests
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Remove unused functions
Signed-off-by: Tommy Walton <waltont@amazon.com >
* Update based on feedback from burelc
Signed-off-by: Tommy Walton <waltont@amazon.com >
2021-12-13 13:07:04 -08:00
71bb200e0a
[LYN-7064] Hot Loading of Procedural Prefabs ( #4923 )
...
* Prefab hotloading - load and maintain asset references
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Working hotloading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up code, add comments
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add event for template removal.
Clear ProceduralPrefabSystemComponent lookup when templates are removed.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add unit test.
Fix missing include, make sure source name is set
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Update comments to make ebus event behavior more clear
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing includes
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing include
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix temp directory usage which doesn't work on linux
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Use AZ::IO::Path for comparison. Print paths on failure
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix unit test - register asset with catalog so it can be looked up later
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 12:44:41 -08:00
946a77e914
Document ValueWriter, add basic OpaqueValue handling
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 12:06:24 -08:00
af91cea8ef
Add copy-on-write note
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 11:56:53 -08:00
45abb9f88e
Proc Prefabs: Remove feature toggle ( #6348 )
...
* Disable feature flag - redirect proc prefab check to IsPrefabSystemEnabled.
Procedural Prefabs are now on by default when the prefab system is enabled.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Bump scene builder version to cause all procedural prefabs to rebuild
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Switch to lambda for ebus call
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused const
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-13 11:52:03 -08:00
202226c2cb
Document short string usage
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 11:31:23 -08:00
d044f51a89
Remove DomDocument for now
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 11:21:38 -08:00
8da04f15d3
Add some Value documentation
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 11:15:02 -08:00
0dfb8d42c4
Disable the ability to instantiate into closed prefabs, and to move the root prefab in focus mode. ( #6320 )
...
* Disable "Move Up" and "Move Down" for focused prefab containers.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Disable the ability to instantiate prefabs inside closed prefab instances.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor comment fix.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-13 19:10:04 +01:00
586f146a84
Fixed nullptr error ( #6386 )
...
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-13 17:56:46 +00:00
ae3dedfe59
Merge pull request #6172 from aws-lumberyard-dev/Prism/RefactorProjectSettings
...
Refactor Project Manager Settings
2021-12-13 09:40:48 -08:00
0216d0ae9f
Clarify shared string semantics
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 09:11:06 -08:00
f941d03f9e
Fix namespace Az for AZ in ProcessWatcher for iOS ( #6382 )
...
Signed-off-by: moraaar <moraaar@amazon.com >
2021-12-13 14:03:00 +00:00
e080ade885
Switch high perf allocator back on for containers, modest perf boost
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 14:20:16 -08:00
d9ac3c2120
Tidy up Type enum
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 13:56:10 -08:00
cc120c772c
Add RapidjsonCopyAndMutate to compare w/ shallow copy
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 12:58:52 -08:00
c53c97cf5f
Add another round of benchmarks
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-11 15:54:57 -08:00
1f2635d24b
Switch to the high pref heap allocator, roll back pool interface changes
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 16:35:26 -08:00
809ee2dce9
Fix "force string copy" logic
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 16:18:38 -08:00
1af39a5c5c
Add benchmarks, some light optimizations like SSO
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 15:57:52 -08:00
c06b697c6b
Revert part of the fix as it would break unit tests. Verified the remaining code still achieves the same purpose on the UI side without impacting the backend.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-12-10 15:06:55 -08:00
4670003aaf
Fix failed Atom rpi tests linux ( #6319 )
...
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS
- Add template specialization for ConstantsData::SetConstant<Color> and ConstantsData::GetConstant<Color>
- Remove trait AZ_TRAIT_DISABLE_FAILED_ATOM_RPI_TESTS from source code
- Fix ConstantsData::SetConstantArray<bool> to pass unit test SetConstant_GetConstant_FalsePackedInGarbage_Bool on Linux, cause by an unwanted optimization (comments describe the situation). This will make this behavior consistent across platforms
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-10 14:54:08 -08:00
502578293b
Merge branch 'development' of https://github.com/o3de/o3de into daimini/ReadOnly/TransformResetFix
2021-12-10 14:35:25 -08:00
3ae6b601a2
Focus issue in editor settings menu #3921 ( #6296 )
...
* Changes to fix DCO
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Moved the keyEvent to a helper function for ease of testing
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Split definition and declaration of WidgetHandleKeyPressEvent
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-12-10 22:34:41 +00:00
Nicholas Van Sickle
AMZN-Igarri
bosnichd
amzn-sean
Michael Pollind
Benjamin Jillich
amzn-mike
tjmgd
Tom Hulton-Harrop
Chris Galvan
Jeremy Ong
michabr
Steve Pham
Tommy Walton
Danilo Aimini
John Jones-Steele
AMZN-Phil
moraaar