birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,190 Commits 3 Branches 3 Tags
d9dbd439d417835edfc72177bae24f64fe3baa90
Commit Graph

4232 Commits

Author SHA1 Message Date
Benjamin Jillich afc531d4c3 Fixes VS2022 error C5233: explicit lambda capture 'isSlash' is not used (#6745) 
Signed-off-by: Benjamin Jillich <jillich@amazon.com>
 2022-01-10 10:22:02 +01:00
Chris Galvan 641f7be041 Removed more unused Editor code and images 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-07 14:24:53 -06:00
Nicholas Van Sickle 8b9e3d2175 Simplify disabling Value ctor for pointer types 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-07 09:53:14 -08:00
Michael Pollind 8503915cdd bugfix: correct mouseMove under AzToolsFrameworkHelper (#6493) 
* bugfix: correct mouseMove under AzToolsFrameworkHelper

REF: https://github.com/o3de/o3de/issues/6481
Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: added unit test

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: address comments

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: correct fixture

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: tweak mouse move logic

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* updates to track mouse/cursor position via events instead of using QCursor::pos()

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* rename AzToolFrameworkTestHelperTest.cpp to AzToolsFrameworkTestHelpersTest.cpp

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

Co-authored-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
 2022-01-07 14:43:34 +00:00
Tom Hulton-Harrop 1a8b7aeb48 Small workaround and fix to ensure line fade (alpha) displays correctly (#6733) 
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
 2022-01-07 09:37:33 +00:00
sphrose 98b0f206a0 Merge pull request #6705 from aws-lumberyard-dev/3495_preferences_panel_update 
3495 Preferences panel update: fix richtext elision and allow html links
 2022-01-07 08:52:45 +00:00
Nicholas Van Sickle 839bbd734a Make operator== avoid implicit comparisons 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-06 16:55:24 -08:00
Nicholas Van Sickle 25924c3d38 Use more explicit operator= override 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-06 16:54:57 -08:00
Nicholas Van Sickle e7f573d22a Make Value ctor explicit 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-06 16:48:07 -08:00
Esteban Papp 54e0b8b7b5 Enabling mac tests (#6716) 
* Adds mac test job

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Points to sysctl properly to handle zsh

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes some macos differences with Linux when reading the CTEST_RUN_FLAGS parameters

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* adding the test job to the profile pipe

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Disables some tests in Mac that are not passing

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* passes config to cli_test_driver and sets the right trait for the test (pytest instead of lytesttools)

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Set proper traits for AtomRHI

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Corrected AZ_TRAIT_UNIT_TEST_PERLINE_GRADIANT_GOLDEN_VALUES_7878 values for Mac

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Disables EMotionFX tests in Mac

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removes debugging prints

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removes filters that were meant just for Linux

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* quotes are re-quoted in the test_mac.sh script

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2022-01-06 16:16:48 -08:00
Ronald Koppers f376d7e379 Merge pull request #6468 from aws-lumberyard-dev/Prefabs/ProcessStackAddPrefabBug 
Spawnable Entity Alias improvements
 2022-01-06 14:58:27 -08:00
mrieggeramzn 273d6e225a Previous commit wasnt correct. Should be using a string not a int 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-06 14:00:33 -08:00
mrieggeramzn f1c8fbe7c0 remove std and replace with az 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-06 13:45:54 -08:00
Chris Galvan d3b36f1814 Added a couple more missing includes 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-06 13:55:52 -06:00
Chris Galvan 53e6f0f99f Added another missing include 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-06 13:27:44 -06:00
Chris Galvan e5c2d574fc Added a missing include and forward declare 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-06 12:51:10 -06:00
Chris Galvan fee88cf5c6 Removed legacy editor DatabaseLibrary code. 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-06 10:12:54 -06:00
sphrose 030ba4853b Merge branch 'development' into 3495_preferences_panel_update 2022-01-06 14:29:04 +00:00
T.J. McGrath-Daly dae82b3858 Fix: only files can be selected 
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>
 2022-01-06 10:10:46 +00:00
Tom Hulton-Harrop 66985e3569 Updates to ViewportTitleDlg to better expose grid snapping visualization (#6700) 
* updates to ViewportTitleDlg to better expose grid snapping visualization

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* small typo fix

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add escape handling for widget to be more consistent with other QMenu behavior

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* remove unneeded [[maybe_unused]]

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
 2022-01-06 09:26:16 +00:00
Michael Pollind 39c09ba6f7 chore: correct formatting and address comments 
Signed-off-by: Michael Pollind <mpollind@gmail.com>
 2022-01-05 21:03:16 -08:00
Michael Pollind 21850aa73e chore: replace stack trace logic with StackRecorder 
Signed-off-by: Michael Pollind <mpollind@gmail.com>
 2022-01-05 21:03:14 -08:00
Michael Pollind 833598d68f chore: remove signal handler 
Signed-off-by: Michael Pollind <mpollind@gmail.com>
 2022-01-05 21:03:12 -08:00
Michael Pollind ada7c41a34 feature: add Exception Handler support for unix 
REF: https://github.com/o3de/o3de/issues/5886

Signed-off-by: Michael Pollind <mpollind@gmail.com>
 2022-01-05 21:03:10 -08:00
AMZN-koppersr e2a960e442 Fixed a sync issue when a PrefaDOM was taken from a PrefabDocument. 
When a PrefabDOM was taken from a PrefabDocument the Instance would continue to have the data from the original Prefab, which means they'd no longer be in sync as the Prefab would be empty. This was fixed by resetting the Instance so they're both clear.

Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com>
 2022-01-05 17:21:15 -08:00
Esteban Papp 09fd52ef73 AzCore Math tests produce errors that need to be disabled in debug (#6678) 
* Tests produce errors that need to be disabled in debug

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR suggestion

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2022-01-05 16:07:52 -08:00
mrieggeramzn 0bcb514c27 removing qlocale.h compile issue 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-05 15:56:53 -08:00
mrieggeramzn 7d9f9f99e6 fix unit test 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-05 14:50:03 -08:00
Allen Jackson 6c3d5c434e {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic (#6396) 
* {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic

- Give the user an option how to handle fallback logic for script rules

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* the new code found an error in a Python script... it seems to work!

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* fixing up the regression test

Signed-off-by: Jackson <23512001+jackalbe@users.noreply.github.com>

* dump version number

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
 2022-01-05 16:08:58 -06:00
Nicholas Van Sickle d347a9d2c0 Fix Linux build (a static_assert unfortunately fires for Clang) 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-05 12:56:22 -08:00
Chris Galvan 233349ffe3 Removed unused Editor code from EditMode/Geometry/Include/LightmapCompiler 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-05 13:35:09 -06:00
Nicholas Van Sickle acc6248ec9 Move deep comparison / copy to utils 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-05 11:31:09 -08:00
AMZN-koppersr 13375cd7d9 Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug 2022-01-05 11:12:57 -08:00
AMZN-koppersr 31e51f8c3a Minor updates to the Spawnable Entity Aliases in response to PR feedback. 
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com>
 2022-01-05 10:47:23 -08:00
Esteban Papp 89067fe667 Memory/benchmarks (#5896) 
* initial version ported from an old implementation

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* simplification of code

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes a recursive loop

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removing commented code of different options for getting memory usage of a process

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR comment (NULL->nullptr)

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds mulit-threaded tests

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Improving runtime and making the whole duration manageable

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes Linux build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes for mac

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes for HeapSchema to get a default block if none is passed

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds recording functionality (disabled) and a benchmark that can run recordings

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Removes Heap allocator from being possible to use as a SystemAllocator since it doesnt allow dynamic allocating (only works with pre-allocated blocks)

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* WIP trying to use SystemAllocator instead of raw reads

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Makes the recorded benchmark more stable

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* More stability changes, improvement on type usage within the benchmark, cleanup of unstable stats

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Adds benchmark files for Android

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Fixes Linux nounity build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR comments

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process)
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2022-01-05 10:40:03 -08:00
mrieggeramzn 8ed3da5b7f Adding header file 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-05 10:24:53 -08:00
sphrose 783a04b880 3495 Preferences panel update: fix richtext elision and allow html links 
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
 2022-01-05 18:00:07 +00:00
Esteban Papp c548fd7682 Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process) (#6683) 
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
 2022-01-05 08:15:08 -08:00
Chris Galvan ff947dfcc3 Merge pull request #6682 from aws-lumberyard-dev/cgalvan/RemoveUnusedEditorControls 
Removed some unused classes from Editor/Controls
 2022-01-05 06:05:29 -06:00
Nicholas Van Sickle 41c0fb2b02 Address some review feedback 
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com>
 2022-01-04 17:41:58 -08:00
Chris Burel 648a21ab5c [Linux] Correct handling of new dirs added to non-recursive watch roots 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Chris Burel 2bc1d8620e Rename file to adhere to PAL conventions 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Chris Burel 484e27c109 Use AZStd::equal to implement path comparison 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Chris Burel ce0bb1ca2b [AssetProcessor] Refactor the FileWatcher to use only one watch thread 
This change reworks the AssetProcessor's FileWatcher so that it only uses
one thread. This is motivated by getting better support for inotify on
Linux. The previous architecture required calling `inotify_init` once for
each directory that was being watched, and using separate inotify instances
for each watched tree. In addition, having separate threads per watched
tree is not necessary, and just consumes system resources. Each platform
supports watching multiple directories with the same platform-specific
watcher API, so each platform has been updated accordingly.

The interface to the FileWatcher class is greatly simplified. Previously,
it supported client-supplied filtering of the paths that would generate
notifications. This was done by subclassing `FolderWatchBase` and
implementing `OnFileChange`. However, only one filter was ever used, so
that filter is now hard-coded in the FileWatcher class, and the classes
driving the old filtering mechanism are removed. Users of the interface
now have a much easier time, they just call `AddFolderWatch` with the path
to watch, and only have to connect to one set of signals, instead of
separate signals per watched directory.

Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Chris Burel 7ac5bc3d5c [Linux] Display a warning in AP if inotify fails to initialize 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Chris Burel 04f4d5e031 [Linux] Avoid recursive inotify when a watch folder is set to recursive=false 
Signed-off-by: Chris Burel <burelc@amazon.com>
 2022-01-04 16:12:17 -08:00
Nicholas Van Sickle e518faa8be Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument 2022-01-04 15:41:17 -08:00
mrieggeramzn 30e21bc2d1 Updating formatting 
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
 2022-01-04 14:52:00 -08:00
Chris Galvan c773c9e9aa Removed some unused classes from Editor/Controls 
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
 2022-01-04 16:39:04 -06:00
Vincent Liu 2b9d1ca813 Update to use AWSNativeSDK 1.9.50 (#6618) 
* Update to use AWSNativeSDK 1.9.50
* After SDK upgrade, some AWS objects are bound to SDK allocator, init AWS SDK for unit test
 2022-01-04 12:45:51 -08:00