52604d79f6
Address some review feedback
...
Signed-off-by: nvsickle <nvsickle@amazon.com >
2021-11-04 12:06:37 -07:00
c9fb41d0e5
Fix Entity Outliner sort order with Prefabs enabled
...
The EditorEntitySortComponent was relying on serialization callbacks not exposed to the JSON serializer to marshal data between its serialized state and its runtime state, which led to the outliner sort order becoming disrupted every time a prefab propagation occurs (and the component is subsequently serialized and deserialized). This change:
- Forces `PrepareSave` and `PostLoad` for `EditorEntitySortComponent` to be called at update (direct descendant added or removed) and activation time respectively while prefabs are enabled. While this could be optimized, and this logic stands to be refactored once slices are fully removed, I was unable to gather any samples in which `PrepareSave` are called in a sampling profiler in a scene with 1000 top-level entities, so I don't anticipate this introducing a meaningful performance regression in the short term.
- Disables updates in `EditorEntitySortComponent` during prefab propagation, as any detected changes do not signal authored intent at this time
- Made `GetEntityChildOrder` in `EditorEntityHelpers` work with prefabs enabled, which restores the existing "Sort: A -> Z" and "Sort: Z -> A" behaviors (which have some preexisting issues this does not fix)
- Adds a Python regression test to the Editor suite to validate this behavior - the test is currently in TestSuite_Main and not TestSuite_Main_Optimized because it requires an Editor launch with prefabs enabled, this can be fixed once AutomatedTesting is further migrated away from slices
@AMZN-daimini has a larger change that improves the JSON serialization format (https://github.com/o3de/o3de/pull/1292 ) which we should absolutely bring in in the future to improve the legibility of the Prefab format, but this change fixes the functionality (including saving & reloading a level and keeping a consistent order) without altering the Prefab format - this lower impact radius fix is my preference for our stabilization period.
Signed-off-by: nvsickle <nvsickle@amazon.com >
2021-11-03 19:57:51 -07:00
f009e06cab
responding to code reviews
...
Signed-off-by: kritin <kritin@amazon.com >
2021-10-06 13:20:48 -07:00
f1fe2912e4
responded to code reviews
...
Signed-off-by: kritin <kritin@amazon.com >
2021-10-05 14:54:07 -07:00
b7e3a63fae
responded to code reviews
...
Signed-off-by: kritin <kritin@amazon.com >
2021-10-04 23:18:31 -07:00
779edb7fe5
Sample Editor test for QA Automation project
...
Signed-off-by: kritin <kritin@amazon.com >
2021-09-30 16:43:15 -07:00
2ca03367bb
Re-added removed xfails by accident ( #3901 )
...
Co-authored-by: Garcia Ruiz <aljanru@amazon.co.uk >
2021-09-03 18:32:15 +02:00
082273b543
Whitespace cleanup
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 18:19:38 -05:00
789d5904da
More test filename cleanup/re-org and enabled existing tests alongside optimized tests
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 18:18:19 -05:00
cb1d680a56
Removing sandbox tests from main suite
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:43:16 -05:00
2f8d029832
Moving 2 tests to sandbox that are intermittently failing on Jenkins but passing locally
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:35:11 -05:00
4458a245d1
Adding xfail marker to test run, and updating CMakeLists to point to the optimized test file
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:19:01 -05:00
fb39aa5b86
Removing old test files
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:14:15 -05:00
8c1ab46901
Removing unneeded periodic suite test file
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:02:01 -05:00
fc44063a0a
Renaming test files for standardization. Keeping old, unoptimized files temporarily.
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 16:00:45 -05:00
871cb6761e
More Editor automation conversions to TestAutomationBase
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-24 11:47:46 -05:00
182d410562
Updating base.py to allow for turning off batch and autotest modes
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-20 16:29:48 -05:00
7daef6ab03
Converting Editor Main tests to use TestAutomationBase, and preparing for optimization
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-08-20 15:58:43 -05:00
88bef1074b
Replaced some Lumberyard references with O3DE.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-08-16 15:43:01 -05:00
181998f810
Fixes a nightly build and a CMake warning ( #2941 )
...
* Addressing CMake warning and removing timeouts that are the same as the default
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* missed this one
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Making it an error so developers stops putting timeouts longer than the allowed one since it causes AR issues
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* fixing warning from the nightly build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* disabling test that is triggering a timeout
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-08-10 14:05:14 -07:00
38261d0800
Shorten copyright headers by splitting into 2 lines ( #2213 )
...
* Updated all copyright headers to split the longer original copyright line into 2 shorter lines
Signed-off-by: Steve Pham <spham@amazon.com >
2021-07-16 15:25:48 -07:00
2fc1062802
Removed deprecated graphics settings/performance menu options. Updated automated test accordingly.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-07-12 13:42:08 -05:00
ea0e38aaf4
Updating expected View menu options for test_Menus_ViewMenuOptions_Work
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-07-08 08:10:09 -05:00
b4a2edec6a
Final update copyright headers to reference license files at the repo root ( #1693 )
...
* Final update copyright headers to reference license files at the repo root
Signed-off-by: spham <spham@amazon.com >
* Fix copyright validator unit tests to support the stale O3DE header scenario
Signed-off-by: spham <spham@amazon.com >
2021-06-30 19:51:55 -07:00
149863c527
Removed Amazon as Company for QSettings ( #1649 )
...
* Removed Amazon as Company for QSettings
Signed-off-by: Terry Michaels <miterenc@amazon.com >
2021-06-29 14:00:11 -05:00
70042fcdcd
O3DE Copyright Updates for Linux Foundation ( #1504 )
2021-06-23 10:55:22 -07:00
3fb3836b54
Simplifying test filtering in CMakeLists
2021-06-22 11:44:29 -05:00
4c294c0931
Merge branch 'stabilization/2106' of https://github.com/aws-lumberyard/o3de into jckand/FoundationAutoStabilization
2021-06-22 10:07:50 -05:00
a8ba1a99af
Update BasicEditorWorkflows_LevelEntityComponentCRUD.py
2021-06-21 11:57:14 +01:00
67cd1ff52f
Ensuring Main suite tests don't run GPU tests
2021-06-17 14:44:44 -05:00
6cf3a26574
Duplicating test to run on GPU node
2021-06-16 16:41:50 -05:00
b31de1da33
LYN-4518: Updating expected actions for test_Menus_ViewMenuOptions_Work
2021-06-14 13:46:53 -05:00
d1f23aff62
SPEC-7008: Excluding more main tests from Debug test runs
2021-06-03 17:38:22 -05:00
5fbf587b9e
Updating File Menu actions in test_Menus_FileMenuOptions_Work. Temporarily marking test as xfail due to LYN-4208
2021-06-03 10:50:27 -05:00
1ebfa86f87
Added missing indent to test registry in CMakeLists.txt
2021-05-26 13:02:55 -05:00
1fb8dd7dcd
SPEC-7008: Moving failing Editor tests to Sandbox suite for investigation
2021-05-26 10:00:33 -05:00
434fef4b8f
Adding missing copyright header to test file
2021-05-21 16:39:16 -05:00
053247931b
LYN-3769: Adding a basic Editor workflow automated test
2021-05-21 15:45:46 -05:00
6be126ec36
SPEC-6949: Updating menu actions for failing Menu tests
2021-05-19 14:24:29 -05:00
906780a01f
Reorganized PythonTests CMakeLists ( #716 )
...
Reorganized Python Tests CMakeLists.txt
Co-authored-by: Garcia Ruiz <aljanru@amazon.co.uk >
2021-05-18 19:11:56 +01:00
1a90528e6c
Marking AssetPicker test as xfail due to ATOM-15493
2021-05-06 16:18:22 -05:00
b2f0df99a7
- Removing re-merged unneeded tests
...
- Updating imports for Editor tests to new utils location
2021-04-23 11:28:44 -05:00
52731b478d
Resolving conflicts with deleted files and main merge
2021-04-22 17:16:17 -05:00
8ee6a16567
- Removing another mistakenly re-merged test file
...
- Updating conftest.py to point to new location for saved layouts
2021-04-22 16:22:11 -05:00
9f2386fd09
- LYN-2764: Updating asset in TreeNavigation test
...
- Removing mistakenly re-merged test file
2021-04-22 15:29:13 -05:00
c1e3e0fe5e
Moving hydra util files into a package
2021-04-19 16:31:05 -07:00
8469c9ca0a
Integrating github/staging through commit 5f214be
2021-04-13 17:18:57 -07:00
1044dc3da1
Integrating github/staging through commit ab87ed9
2021-04-09 11:27:37 -07:00
e8bbb5a0d5
Set scripts to be executable
...
This is required to build on linux/mac
2021-03-26 09:26:12 -07:00
75dc720198
Integrating latest 47acbe8
2021-03-25 13:57:57 -07:00
nvsickle
kritin
AMZN-AlexOteiza
jckand-amzn
Chris Galvan
Esteban Papp
Steve Pham
Terry Michaels
sphrose
evanchia
alexpete
Brian Herrera