cf4ef5e73b
Addressed feedback from previous PR plus some cleanup
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-11-18 13:37:06 -08:00
12e3a652d7
Merge pull request #5737 from aws-lumberyard-dev/Atom/antonmic/FixForCapsuleAuxGeom
...
Fixed capsule auxgeom draw for lights and other aux geom issues
2021-11-18 10:16:31 -08:00
06e5c394e2
Updating AssetBrowser tests around new TableView model and removed several xfails from tests that now pass ( #5727 )
...
Signed-off-by: jckand-amzn <jckand@amazon.com >
2021-11-18 10:07:19 -08:00
1b63ca3bc0
Terrain component icon updates. ( #5722 )
...
* Terrain component icon updates.
Refreshed using latest icons from UX.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
* Revised icons from UX.
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
2021-11-18 11:30:03 -06:00
44d693a444
Fix DOF flickering on Vk due to missing LDS sync ( #5723 ) ( #5732 )
...
* Fix DOF flickering on Vk due to missing LDS sync
Signed-off-by: moudgils <moudgils@amazon.com >
* Added another sync
Signed-off-by: moudgils <moudgils@amazon.com >
2021-11-18 09:11:58 -08:00
78263b7f13
Merge pull request #5681 from aws-lumberyard-dev/Prism/CLIDisplayLastError
...
Show python errors in Project Manager
2021-11-18 08:37:23 -08:00
a54a149877
Changes from comments made after merge ( #5738 )
...
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-11-18 16:06:54 +00:00
f18f5318c0
Fix for gizmo axis text not displaying correctly on high dpi screens ( #5745 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-18 15:34:30 +00:00
ca6b7d1d1f
Add test for ViewportInteractionImpl use of ViewportInteractionRequestBus ( #5741 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-18 13:09:06 +00:00
bf4f52e146
Updates and fixes to viewport placement ( #5712 )
...
* updates to use more modern viewport intersection logic
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to editor viewport ray intersection for object placement
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* make ed_defaultEntityPlacementDistance visible to Viewport.cpp
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix link error for AZ_CVAR variable
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following review feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-18 10:58:18 +00:00
cf540b6f44
Defaulting the joint setup display to ON instead of OFF ( #5696 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-11-18 09:57:29 +00:00
b533a9566a
Fix for viewport not updating correctly when switching camera views ( #5719 )
...
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-18 09:11:46 +00:00
8587c8e033
Fixed capsule auxgeom draw for lights and other aux geom issues
...
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com >
2021-11-17 22:55:29 -08:00
d222aeef48
Merge pull request #5571 from aws-lumberyard-dev/Atom/santorac/MaterialEditorHandlesMissingTextures
...
Updated Material Editor and Asset Processor To Gracefully Handle Missing Textures
2021-11-17 19:58:37 -08:00
734c2fb693
Merge remote-tracking branch 'upstream/stabilization/2110' into Atom/santorac/MaterialEditorHandlesMissingTextures
2021-11-17 15:11:32 -08:00
9a887bd690
Removed unused lambda function.
...
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com >
2021-11-17 15:11:05 -08:00
7787ceb04c
Merge branch 'stabilization/2110' of https://github.com/aws-lumberyard/o3de into Prism/CLIDisplayLastError
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-17 14:43:03 -08:00
555776fd7f
Fix AssetBus connection policy to re-lock the mutex afterward since some destructors in the calling methods are still altering the context ( #5575 ) ( #5664 )
...
Also made the unlock conditional.
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
(cherry picked from commit 63713ca284
2021-11-17 14:40:45 -08:00
c375f07339
Merge pull request #5637 from aws-lumberyard-dev/Prism/FixGemCart
...
Display Gem Cart in Gem Catalog Right Panel
2021-11-17 14:30:43 -08:00
e9ec37f20b
Moved global vector inside PythonBindings
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-17 14:03:24 -08:00
d3de1689ad
Removed unused lambda function.
...
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com >
2021-11-17 13:53:11 -08:00
a8dcfbbb13
Prevent settings from being saved to setreg files on editor close. Limiting this to avoid a bigger blast radius. ( #5717 )
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-11-17 13:27:57 -08:00
2774ac1811
Merge branch 'stabilization/2110' into Atom/santorac/MaterialEditorHandlesMissingTextures
2021-11-17 13:24:56 -08:00
713a3916f5
Merge pull request #5691 from aws-lumberyard-dev/Atom/guthadam/material_editor_viewport_settings_previews_uses_thumbnail_widget
...
Replacing material editor lighting preset selection dialog exr previews with lighting preset thumbnails
2021-11-17 14:57:52 -06:00
be9db80f99
Merge branch 'stabilization/2110' into Atom/santorac/MaterialEditorHandlesMissingTextures
2021-11-17 12:15:57 -08:00
95c8398c79
Merge pull request #5673 from aws-lumberyard-dev/Prism/AddEditGemsButton
...
Adds Configure Gems Options to Project Dropdown + Misc. Project Manager Fixes
2021-11-17 12:14:24 -08:00
2ae7a5ef9f
Added a unit test for the MaterialPropertyValue bug fix.
...
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com >
2021-11-17 12:04:46 -08:00
6b1fb04a1c
Terrain Supports Physics test ( #5706 )
...
* Terrain Supports Physics test
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
* Changes from PR
Signed-off-by: John Jones-Steele <82226755+jjjoness@users.noreply.github.com >
2021-11-17 19:16:30 +00:00
a1cf76ec65
Merge pull request #5652 from aws-lumberyard-dev/viewport/EditorModeUIBackButton
...
Viewport/editor mode UI back button
2021-11-17 18:32:46 +00:00
33abae1008
Merge pull request #5710 from aws-lumberyard-dev/cgalvan/FixSlowScriptCanvasLoading
...
Fixed slow Script Canvas loading by moving error icon construction in NodePaletteTreeItem.
2021-11-17 12:31:45 -06:00
7de4628747
Merge branch 'stabilization/2110' into Prism/FixGemCart
2021-11-17 10:19:47 -08:00
8d26251c93
Include DownloadController
...
Signed-off-by: nggieber <nggieber@amazon.com >
2021-11-17 10:16:41 -08:00
6819a1956d
Merge branch 'stabilization/2110' of https://github.com/aws-lumberyard/o3de into Prism/CLIDisplayLastError
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-17 10:01:00 -08:00
d0ebe4ee10
Follow up fix for ATOM-13512 ( #5689 )
...
* Follow up fix for ATOM-13512
Update the file mask mapping in ImageBuilder.settings.
Change Reflectance.preset to use BC4 format since it only needs once channel.
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com >
2021-11-17 10:00:31 -08:00
1457ef6ee9
Merge pull request #5692 from aws-lumberyard-dev/Atom/guthadam/throttle_material_editor_updates_when_inactive
...
Reduce material editor update interval when inactive
2021-11-17 11:47:37 -06:00
21c3aba7da
Fixed slow Script Canvas loading by moving error icon construction in NodePaletteTreeItem.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2021-11-17 11:13:38 -06:00
e34ea3bcaa
Fixes for viewport selection issues ( #5494 )
...
* improvements to editor selection in the viewport
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix issue with being able to select icons that are not showing for entities inside entity containers
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update comment after review feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to viewport picking code to simplify the api
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add test to replicate near clip intersection issue
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small tidy-up changes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to how we perform world to screen and screen to world calculations, added test coverage and some tidy-up
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add some more tests for ViewportInteractionImpl
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* minor tweaks before PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix typo in fix
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for manipulator test framework tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates to RPI::View and RenderPipeline after review feedback from VickyAtAZ
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add constexpr to ScreenPoint, ScreenVector and ScreenSize initializing constructors
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add PrintTo functions for Screen* types
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* downgrade error to warning temporarily
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* check incoming view is null
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove pragma optimize off
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-17 17:12:21 +00:00
ef16207ac5
Merge pull request #5684 from aws-lumberyard-dev/Atom/jromnoa/cherrypick-dev-asset-gpu-test-fixes
...
Cherrypick GPU test changes (that also fix issues) to stabilization
2021-11-17 09:06:46 -08:00
72de78bb83
Reduce material editor update interval when inactive
...
Reduce the application update interval when it’s not in focus to reduce power consumption and interference with other applications
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 11:02:36 -06:00
cb552256f8
Moved asynchronous image loading function to atom tools framework
...
Moved settings registry wrapper function to atom tools framework
Created registry settings with default values for preview configurations based on asset type
Changed lighting preset previews and thumbnails to use reflective material
Created registry settings for preset selection dialog borders, padding, sizes
Updated shared preview utility functions to compare against registered asset types instead of passing them in individually
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 10:55:14 -06:00
a051bdeeb0
Enably QtForPython for Linux ( #5667 )
...
- Fix PALification and include Linux for the QtForPython gem
- Add Linux-only module loader for Pyside2 related modules
- Remove (unnecessary) #if !defined(Q_OS_WIN)
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-11-17 08:28:33 -08:00
593f03efb4
Camera fixes follow-up ( #5703 )
...
* allow unconstrained camera when tracking transform and fix some camera interpolation issues
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* tests for interpolation fixes
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add test for camera constraints change
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following review feeedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-17 16:23:01 +00:00
a7e90fd6c8
Fix copy paste variable name
...
Signed-off-by: AMZN-Phil <pconroy@amazon.com >
2021-11-17 08:15:41 -08:00
6dcbc64cd6
Removed preview image setting from model presets
...
It’s no longer needed because we use the thumbnail renderer
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 10:12:10 -06:00
123b422709
Updated shared preview fit to camera logic and viewing angle
...
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 10:12:07 -06:00
88569948e3
Changed preset selection dialog widget headings to not overlap preview images
...
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 10:12:05 -06:00
5311878e87
Replacing preset preview images with thumbnail widget to improve load times
...
Signed-off-by: Guthrie Adams <guthadam@amazon.com >
2021-11-17 10:12:02 -06:00
9f9aa8f2a6
[Linux] Avoid duplicating inotify watches in forked AssetBuilder processes ( #5683 )
...
The AssetProcessor on Linux uses `inotify` to monitor for file updates.
The AssetProcessor also uses a `ProcessWatcher` to launch child
AssetBuilder processes. `ProcessWatcher` accomplishes this by calling
`fork()`, which duplicates the current process, then calling `exec()`.
The `fork()` call also appears to duplicate any inotify fds. This
results in the subprocess consuming duplicate inotify watches, which is
a limited system resource (Ubunut 20 defaults
`/proc/sys/fs/inotify/max_user_watches` to 65536). The AssetProcessor
still has issues with this max, but this should free up at least half of
the uses.
Signed-off-by: Chris Burel <burelc@amazon.com >
2021-11-17 07:34:56 -08:00
823b5bde0b
Merge pull request #5645 from aws-lumberyard-dev/avoid-bad-mass-ratios
...
Avoid bad mass ratios
2021-11-17 14:15:25 +00:00
a6164ca2cd
Fix for camera roll behavior when in 'Be this camera' mode ( #5658 )
...
* fix for camera roll behavior when in 'Be this camera' mode
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates for camera tests
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* fix for failing unit test - require default function
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-17 12:27:23 +00:00
antonmic
jckand-amzn
Mike Balfour
moudgils
AMZN-Phil
John Jones-Steele
Tom Hulton-Harrop
amzn-sean
santorac
AMZN-Phil
amzn-mike
Danilo Aimini
Guthrie Adams
jonawals
Chris Galvan
AMZN-nggieber
nggieber
Qing Tao
jromnoa
Guthrie Adams
Steve Pham
Chris Burel
greerdv