Commit Graph

1206 Commits

Author SHA1 Message Date
John 0e6a266e89 Remove frontend console tests 2021-06-16 11:47:17 +01:00
John 58ad67dc44 Disable EntityIdGeneration test 2021-06-15 17:44:00 +01:00
John baab0cb43b Disable EntityIdGeneration test 2021-06-15 17:33:57 +01:00
John 2606234cfa Merge branch 'main' into TIF/Runtime 2021-06-15 17:32:21 +01:00
John 1cef72ab8d Fix uncommented tests 2021-06-10 17:32:16 +01:00
John af0bcb0636 Remove test files 2021-06-10 14:58:34 +01:00
John 169d4da288 Address PR comments 2021-06-10 14:54:46 +01:00
Danilo Aimini 80f62d0523 LYN-3708 | Optimize Prefab instance propagation to stabilize UX (#700)
* Add instanceToIgnore to calls leading to instances being added to the queue for propagation.

* Change PrefabUndoEntityUpdate to make it so that the instance triggering the prefab template change is not reloaded on propagation, since it will already be up to date due to the way we generated the patch to begin with.

* Add FindPrefabDomValue utility function for paths

* Expose the level root prefab template id in the Prefab EOS Interface

* Fix Instance Alias Path generation to work with the new FindValueInPrefabDom function

* Stop reloading ancestors on propagation, and fix instance reloading so that the level dom is used (and overrides are preserved)

* Remove commented out code, refactor FindPrefabDomValue for paths (was handling an edge case incorrectly, and it's not even triggered)

* Fix issue with PathView reference - with PathView already being a reference, this resulted in a copy and triggered a warning during automated review builds.

* Additional fix to the build warning, remove redundant error message

* Revert changes to Instance::GetAbsoluteInstanceAliasPath(), as they were impacting serialization.

* Remove the dependency to the level root prefab template in the propagation code, climb up the hierarchy instead. This allows tests to work despite not using the EOS properly.
Also use PrefabDomPaths to retrieve the instance dom from the root dom instead of iterating.

* Remove now unused PrefabDomUtils function, extend optimization to link updates.

* Trigger a full instance propagation to correctly refresh alias references.
This is an issue in the test because some operations are called from the backend API and will not trigger propagation properly. Tests will soon be rewritten to more properly represent frontend workflows.

* Fixes lingering issues with propagation:
- Restores code that fixes the selection if entityIds have changed;
- Fixes Do() function on link update. Prefab containers will propagate correctly while still being stable during editing.

* Remove GetRootPrefabInstanceTemplateId (no longer necessary after the code has been rewritten)

* Fix optimization code to account for instances being removed and propagation being run out of order in Create Prefab undo.

* Renamed variable, added comments for clarity.

* Restore asserts on instance not being found; Rename Do to Redo for clarity; Add comments.

* Fixed incomplete comment.
2021-06-08 10:44:20 -07:00
amzn-sean 47e5c72f2e fixed missing methods in SC from Trigger and Collision events (#1185) 2021-06-08 18:20:34 +01:00
Danilo Aimini 2d1e47793d Move Duplicate menu items and shortcuts out of the Prefab Wip flag
Make duplicate prefab workflows available by default in Prefab mode.
2021-06-08 10:06:25 -07:00
Terry Michaels 0fcd6e84ec Added mechanism for viewpanes to request buttons on the main toolbar (#1189) 2021-06-08 12:02:02 -05:00
jonawals e2d601ad59 Merge branch 'TIF/Runtime' into TIF/Jenkins 2021-06-08 16:52:26 +01:00
jonawals dd93c42342 Fix missing keys 2021-06-08 16:49:49 +01:00
jonawals a9e6eaa57a Fix anon enum clash with uber files 2021-06-08 16:43:02 +01:00
jonawals 98670a21bc Fix missing copyright header 2021-06-08 15:42:49 +01:00
jonawals 6db9a00315 Merge branch 'TIF/Runtime' into TIF/Jenkins 2021-06-08 14:27:18 +01:00
jonawals a2a9c23c7c Merge branch 'main' into TIF/Runtime 2021-06-08 14:23:05 +01:00
jonawals 656aa528d8 Implement new handling of tiaf seed data 2021-06-08 13:39:37 +01:00
jonawals 7a884c85b3 Address PR comments 2021-06-08 12:19:07 +01:00
jonawals 9e187d67a4 Fix typo with delete files filter 2021-06-08 12:08:42 +01:00
jonawals c9351f4d45 Make TestEngine clean up artifact dir before runs 2021-06-08 12:05:38 +01:00
jonawals e0f953cf6b Address PR comments 2021-06-08 11:59:06 +01:00
Alex Peterson 7ca7ad9b72 Fix missing user_tags exception and configure gems button 2021-06-07 19:50:40 -07:00
Terry Michaels 593b679fa3 Main toolbar consolidation and cleanup (#1167)
* Moving menu options around

* Consolidation and moving of toolbar functioanlity

* Fixed non-unity build missing header

* Updated camera icon to the correct one

* Addressed review feedback

* Addressed review feedback

* Moved icons to new folder structure/naming
2021-06-07 18:11:56 -05:00
Esteban Papp 36cb0f6d40 SPEC-7178 Removal of precompiled cpp files (#1171)
* SPEC-7178  Removal of precompiled cpp files

* Missing files...
2021-06-07 15:59:58 -07:00
amzn-mgwynn 38865c95e2 Merge pull request #1162 from aws-lumberyard-dev/Prism/gem-db
Adding python bindings for modifying project properties
2021-06-07 16:59:10 -04:00
mgwynn 1900a42203 remove const ref from iterator for python object conversion since pybind only returns copies and produces a clang error 2021-06-07 15:43:47 -04:00
mgwynn 01b200ad42 removing unused define 2021-06-07 14:19:48 -04:00
mgwynn 6d6f8413c8 Incorporating review comments. Some parameter modifications. Some cli edge case handling. Remove remove_tag member from project info 2021-06-07 14:14:32 -04:00
jonawals a56591fa12 Address PR comments 2021-06-07 18:38:54 +01:00
jonawals f603b08d05 Address PR comments 2021-06-07 18:37:20 +01:00
jonawals cc9e8a72e4 Fix coverage clear bug and other minor refactors 2021-06-07 17:45:48 +01:00
Nicholas Van Sickle 9e3d472700 Switch EditorContextMenu back to using popup instead of exec (#1158)
Switch EditorContextMenu back to using popup instead of exec

The switch to exec was a deliberate change, but upon further testing with the latest version of our camera input controllers (both the Legacy and Modern variants) it is no longer necessary to call exec, and doing so can cause a bug in which the cursor is still hidden when the context menu appears.
2021-06-07 09:21:10 -07:00
jonawals 796b5be286 Address PR comments 2021-06-07 15:32:17 +01:00
jackalbe 1a6b6d5bc0 {LYN-4230} Fixed loading *.pak files in Release builds (#1127)
* {LYN-4230} Fixed loading *.pak files in Release builds

* Helios - Release mode should load all *.pak files
* Tests: made a separate installation folder with a reduced "engine.pak" and a full "game.pak" which loads in release

* added unit test to regress the bug fix
2021-06-07 09:04:37 -05:00
Tom Hulton-Harrop cf8a6761bf Formatting-only change - Update Manipulator and Viewport AzToolsFramework files (#1143)
* formatting changes to AzToolsFramework viewport related types + API comment style updates

* minor format change - include ordering

* improve formatting by moving comment

* fix compile error and switch to use AZ_Printf

* small polish changes after review feedback
2021-06-07 14:50:49 +01:00
Hasareej 5b940e8ed6 Viewport Ui Cluster Locked State Overlay (#1139)
* Viewport Ui Cluster Locked State Overlay

* PR feedback changes.
2021-06-07 13:32:13 +01:00
jonawals a0feeec608 Add console output to runtime 2021-06-07 10:56:07 +01:00
jonawals d341dab7f5 Address PR comments 2021-06-07 10:39:58 +01:00
jonawals 0da739ef18 Add curiously missing comments 2021-06-07 09:05:29 +01:00
jonawals 4ed0c7b1d8 Add drafting of failed tests 2021-06-07 08:52:20 +01:00
jonawals b00f569090 Address PR comments 2021-06-06 19:09:24 +01:00
Alex Peterson aeaf1bcdbe Fix engine settings not populating or saving
* Allow multiple settings to be registered at once
* Old manifests versions may not have default_third_party_folder
2021-06-04 21:29:36 -07:00
amzn-hdoke bf29b27937 Add AWSAttribution feature (#1164)
* LYN-3601: Provide skeleton classes for AWS Attribution (#31)

Provide skeleton classes for AWS Attribution, along with some basic unit tests

* Add AWS Attribution UI and settings (#56)

* Adding AWS Attributions UX and corresponding editor preference s setting

* Fix serialized field description

* Fixed update frequency to be  a day

* Handling editor startup with default values for AWSAttribution

* Add missing header and remove AWSCoreSystemComponentMock fron test

* Generate and post AWSAttribution metric (#69)

* Adding AWS Attribution Api service job

* Adding support for config endpoint override

* Update Api endpoint formatting, fix default region

* Remove extra header

* Fixes for link issues

* Fix Unittest namespace

* Instantiating AWSAttributionSystemComponent in AWS.Editor module

* Update AttributionMetric with engine version and AWS enabled gems (#77)

* Update AttributionMetric with engine version and AWS enabled gems

* Fix warnings

* Undoing accidental change

* Saving level PrefabLevel_OpensLevelWithEntities

* Remove overriding editorprefrences.setreg

* Revert "Saving level PrefabLevel_OpensLevelWithEntities"

This reverts commit 529af70c55ece70fc6bc29ceb83bef60413713a3.

* Move AWS preferences to its own temp settings file

* Undo accidental file add

* Add missing string params in warning messages

Co-authored-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
2021-06-04 20:48:35 -07:00
amzn-mgwynn ffdce2ef7f Merge branch 'main' into Prism/gem-db 2021-06-04 23:19:47 -04:00
mgwynn d2f8e49037 resolving merge conflict due to variable name change from main 2021-06-04 23:16:25 -04:00
mgwynn 155271a0ee Fixed data type changed by mistake for project info image path 2021-06-04 23:07:36 -04:00
mgwynn 7984f82e48 Bing project_properties CLI to updateProject method. Update project info struct.
Update project properties cli to support lists for tags. Minor adjustments to support
changes.
2021-06-04 23:03:17 -04:00
AMZN-nggieber 3b60bcc0f1 Project Manager Build Project from Projects Page (#1142)
* Added loading bar mode to project button

* Added ProjectBuilder files

* commmit current progress for project building

* Push current project building work

* Full build commands built out and message boxes for lots of situation

* Replaced defaultProjectImage placeholder

* Added installed cmake path to builder process env PATH
2021-06-04 18:41:30 -07:00
lumberyard-employee-dm 77f0d983c8 Mac SystemFile_Apple.h build fix (#1159) 2021-06-04 19:34:28 -05:00