Commit Graph

8645 Commits

Author SHA1 Message Date
jromnoa a38c59372c improve docstring descriptions for FOV degrees and Asset.id not asset paths for diff asset properties
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:02:46 -08:00
jromnoa b36ad7aaff move component descriptions above the property param in the docstrings
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:02:23 -08:00
jromnoa d07cbb7af6 add AtomComponentProperties.grid('Secondary Grid Spacing') direct call, remove fmt:on comment
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:02:15 -08:00
jromnoa 222581318d add some docstring descriptions for Cubemap Texture, Material Asset, Secondary Grid Spacing, & Field of View component properties
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:02:06 -08:00
jromnoa e27e6cc5ef update asset called in global skylight test as well
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:58 -08:00
jromnoa 3b0e3a5d52 update golden images for spot light and area light tests, update asset used
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:49 -08:00
jromnoa bbbcc94634 saving progress on test fixes to swap branches
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:39 -08:00
jromnoa 53275fcb70 add new golden image that uses smaller asset file
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:30 -08:00
jromnoa 33493b5c8e add new component property paths to mesh, material, camera, hdri_skybox, and global_skylight components
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:17 -08:00
jromnoa 0efb8847aa drop the 'as helper' for TestHelper and re-factor the helper. calls to TestHelper.
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:01:06 -08:00
jromnoa 9c2a50d686 use smaller asset files, fix asset to use asset.id for tests
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:00:55 -08:00
jromnoa c83d0432dd saving initial round of edits for the using the Asset class
Signed-off-by: jromnoa <80134229+jromnoa@users.noreply.github.com>
2021-11-16 16:00:41 -08:00
mrieggeramzn 6c1eefe605 Fix for two viewports not computing the right camera matrices (#5672)
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-11-16 15:08:28 -08:00
Mike Balfour a74fa5c5b8 Workaround for NVidia flicker bug. (#5669)
Somehow, accessing IN.m_uv before the later calculations use it seems to make the values become stable and stop flickering.

Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com>
2021-11-16 17:06:27 -06:00
Alex Peterson fc805594d0 Fixes for misc gem download issues (#5665)
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
2021-11-16 14:51:28 -08:00
allisaurus 3ad07a2295 AWSClientAuth updated to use custom CognitoCachingCredentialsProvider (#5525)
Signed-off-by: Stanko <stankoa@amazon.com>
2021-11-16 14:50:37 -08:00
amzn-phist 6651ae3d78 Fix for python load errors on Linux (#5627)
* Explicitly load libpython on Linux

Downstream loads of python modules that weren't linked to libpython would
fail to load because libraries were loaded using the RTLD_LOCAL flag.  This
adds a function that will explicitly load libpython on Linux using the
RTLD_GLOBAL flag.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix misspelled function name

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Addressing PR feedback

- Updates naming and location of things.
- Adds load code to a Gem template.
- Updates error checking.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address further feedback

Removes the api function in favor of just having modules inherit off a
PythonLoader class, that way we get RAAI behavior and lifetime management
for free.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
2021-11-16 15:32:24 -06:00
AMZN-Phil 4854023eb1 Merge pull request #5592 from aws-lumberyard-dev/Prism/ShowProjectBuildReq
Store whether O3DE Project Manager built the project successfully
2021-11-16 12:22:20 -08:00
Esteban Papp 265f624612 Detects runtime dependency cycles (#5634)
* Detects runtime dependency cycles

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* PR comments/suggestions

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
2021-11-16 11:31:41 -08:00
mrieggeramzn dd1d515e37 Atom/mriegger/normaloffsetbiasarealight (#4917)
* Adding directional light shadow bias
* Adding normal offset bias for projected shadows

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-11-16 11:08:25 -08:00
Junbo Liang d468cbad85 AWS Core CDK: Add option to cleanup resources that are retained by default (#5470) (#5618)
* Add option to cleanup resources that are retained by default

Signed-off-by: Pip Potter <61438964+lmbr-pip@users.noreply.github.com>
2021-11-16 10:33:57 -08:00
Allen Jackson c73417a9c1 {lyn7352} adding more logging to mock asset builder test (#5591)
* {lyn7352} adding more logging to mock asset builder test

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* put the guts of the test case into an event callback


Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2021-11-16 12:21:33 -06:00
antonmic 34921d680a Merge pull request #5656 from aws-lumberyard-dev/stab/Atom-16694
upgraded capture_displaymapper util and some cleanup
2021-11-16 10:03:27 -08:00
AMZN-stankowi c3dacb1e52 Unlocked a mutex after modifying the associated variable (#5625)
* Unlocked a mutex after modifying the variable the mutex was meant for.
This fixes an issue where mounting bundles in the Editor was causing the Editor to freeze up, because the following line, m_levelOpenEvent.Signal, resulted in another attempt to lock that same mutex.

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Added a comment describing why the unlock is necessary.

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>
2021-11-16 08:07:20 -08:00
Jonny Gallowy 6cc98f1802 upgraded capture_displaymapper util and some cleanup
Signed-off-by: Jonny Gallowy <gallowj@amazon.com>
2021-11-16 10:04:03 -06:00
Chris Galvan 5e04ddcc02 Merge pull request #5647 from aws-lumberyard-dev/cgalvan/UpdateSplashScreenName
Updated splash screen and about dialog with Stable 21.11 name
2021-11-16 09:34:22 -06:00
bosnichd b20a9b5f39 Some modifications required for restricted platforms: (#5624)
- Replace AZ_TRAIT_MAX_JOB_MANAGER_WORKER_THREADS with AZ_TRAIT_THREAD_NUM_JOB_MANAGER_WORKER_THREADS that allows the number of threads created by the job manager to be set directly.
- Add AZ_TRAIT_THREAD_NUM_TASK_GRAPH_WORKER_THREADS that allows the number of threads created by the task graph to be set directly.
- Add a define that forces the AsyncUploadQueue to use the primary copy queue instead of creating a secondary copy queue.

Signed-off-by: bosnichd <bosnichd@amazon.com>
2021-11-16 08:27:32 -07:00
Chris Galvan ce10906671 Updated splash screen and about dialog with Stable 21.11 name
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-16 08:08:53 -06:00
amzn-sean 7da0913900 Fixed empty cluster UI appearing in joints component mode. (#5547)
Happens if 'limits' or 'breakable' settings are off on the joint when entering component mode.

Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com>
2021-11-16 10:57:32 +00:00
AMZN-Igarri a5adf33427 Deactivate new Asset Picker View by default in the Editor (#5614)
Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>
2021-11-16 10:47:02 +00:00
Chris Galvan 7031147e32 Added event to signal when the Editor is fully initialized so test scripts can listen for that instead of needed arbitrary wait commands. (#5623)
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
2021-11-15 17:01:47 -06:00
allisaurus e1fb2ad368 Update resource mapping schema to make default account ID optional (#5475)
Signed-off-by: Stanko <stankoa@amazon.com>
2021-11-15 14:48:32 -08:00
amzn-mike 8b7e538dd3 Cherry Pick: [LYN-7463] Fix insert streaming request failure (#5604) (#5622)
* Fix race condition where asset would finish loading and another request would start before the streamer request could be cleared

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Re-enable disabled test which was failing for the same reason.

Fix test timeout which was way too long.
Reduce test iterations to keep test time safely under 5 seconds.

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Instead of using a mutex, re-order the statements to remove the streamer request first

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
(cherry picked from commit 0cea59d669)
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-11-15 14:14:43 -08:00
carlitosan 82c83b2c5a Merge pull request #5600 from aws-lumberyard-dev/carlito_fix_sc_rt_asset_load
Move SC runtime asset static initialization out of data loading threads
2021-11-15 12:19:22 -08:00
amzn-sj fc547d902c Add message to indicate Json serialization of bitset is not supported (#5590)
Signed-off-by: amzn-sj <srikkant@amazon.com>
2021-11-15 14:09:43 -06:00
AMZN-Phil 18cf128854 Remove some code duplication
Signed-off-by: AMZN-Phil <pconroy@amazon.com>
2021-11-15 11:50:28 -08:00
Guthrie Adams bc82afa87a Merge pull request #5606 from aws-lumberyard-dev/Atom/guthadam/fixing_double_registration_of_hair_asset
Fixing double registration of hair asset
2021-11-15 13:27:31 -06:00
Guthrie Adams 3d84876e87 Merge pull request #5615 from aws-lumberyard-dev/Atom/guthadam/material_editor_taking_focus_when_opening_new_document
Bug fix for material editor not taking focus when opening a new docum…
2021-11-15 13:26:57 -06:00
Mikhail Naumov b3e2c3f075 SetComponentProperty is now supported by undo operation (#5599)
* Adding undo support to SetComponentProperty to make it function with prefab system

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* Renaming a variable

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>

* PR feedback

Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
2021-11-15 11:01:42 -08:00
mrieggeramzn 5c0fe6a54f Fix for CSM shimmering (#5607)
* Fix for CSM shimmering

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* removing debug code

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-11-15 10:16:25 -08:00
mrieggeramzn 533b80095b Fix for cascade shadow map clipping out too close to the camera (#5509)
Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-11-15 10:16:06 -08:00
AMZN-stankowi c44d03a40d Asset bundler test fixes (#5548)
* Cleaning up errors with default assets, used in bundled release builds

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Updated simple asset references to be to the product, not source assets

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Fixed test_WindowsAndMac_FilesMarkedSkip_FilesAreSkipped to pass again.

Updated the test to verify the assets are actually skipped and not just missing, by having it first run without the skip command and verify they are in the first run. Also updated logging to print out sorted lists, to make it easier to debug failures on Jenkins in the future.

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Removed a test marked skip for legacy levels that featured a lot of assets that are no longer valid.

I don't think we need this specific test anymore in the future because prefabs replace the level system, and prefabs should have their own tests for product dependencies.

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Updated project path to use absolute path (#5459)

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Updated project path to work with latest project path changes

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

* Changed to workspace.paths.project() for getting full path to projects

Signed-off-by: AMZN-stankowi <4838196+AMZN-stankowi@users.noreply.github.com>

Co-authored-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-11-15 09:10:04 -08:00
Guthrie Adams d9746647e1 Bug fix for material editor not taking focus when opening a new document from the main editor or outside of the material editor
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-11-15 10:54:34 -06:00
AMZN-Phil 07c142b975 Remove temporary changes and remove key before building
Signed-off-by: AMZN-Phil <pconroy@amazon.com>
2021-11-15 08:51:00 -08:00
AMZN-Igarri f2068397fa CameraRigComponent - Disable Component Checkbox when the two others are toggled (#5546)
* Disable component checkbox when the other two components are already ignored.

Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>

* Fixed EditContext Indents

Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>

* Fixed Header file

Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>

* Fixed Spaces

Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>

* fixed new line

Signed-off-by: AMZN-Igarri <82394219+AMZN-Igarri@users.noreply.github.com>
2021-11-15 10:51:16 +00:00
Guthrie Adams 1925d08f41 Fixing double registration of hair asset
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-11-13 13:52:56 -06:00
AMZN-nggieber 76b7e73f6f Fully Replaces Remote Gems in Model and Selects Them When Downloading and Deleting (#5593)
Signed-off-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
2021-11-12 16:23:04 -08:00
carlitosan d0cf18e778 remove test code artifact
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-11-12 14:56:27 -08:00
carlitosan c140b882d2 Fix mis-spelled comment
Signed-off-by: carlitosan <82187351+carlitosan@users.noreply.github.com>
2021-11-12 14:19:22 -08:00
Danilo Aimini 5ec5824849 Hide the "up one level" button temporarily. (#5595)
Signed-off-by: Danilo Aimini <daimini@amazon.com>
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2021-11-12 14:16:44 -08:00