* Refactor existing tests and fixtures, split them up in more granular tests, and add more comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Refactor test fixture for FocusMode to make it more reusable
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Fixture rename, draft of selection test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Split SetFocus and ClearFocus tests for Editor Focus Mode
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Move BoundsTestComponent to its own file so that it can be reused in Focus Mode Selection tests
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Making progress on selection test. Test compiles now, but selection doesn't seem to be working.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Removed commented out code from previous iteration.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Move BoundsTestComponent under the UnitTest namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Viewport selection tests + minor fixes.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Minor fixes
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
* Fix a bug in recursion of prefab links when checking for dirty prefabs
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
* Added a missing EntityId header
Signed-off-by: srikappa-amzn <srikappa@amazon.com>
* Provisional impl and testing of central state tracker.
Signed-off-by: John <jonawals@amazon.com>
* Add missing namespace comment.
Signed-off-by: John <jonawals@amazon.com>
* ViewportEditorModeState -> ViewportEditorModes
Signed-off-by: John <jonawals@amazon.com>
* ViewportEditorModesTracker -> ViewportEditorModeTracker
Signed-off-by: John <jonawals@amazon.com>
* GetEditorModeState ->GetViewportEditorModes
Signed-off-by: John <jonawals@amazon.com>
* GetNumTrackedViewports -> GetTrackedViewportCount
Signed-off-by: John <jonawals@amazon.com>
* IsViewportStateBeingTracked -> IsViewportModeTracked
Signed-off-by: John <jonawals@amazon.com>
* Fix API comments.
Signed-off-by: John <jonawals@amazon.com>
* Delete hangover file.
Signed-off-by: John <jonawals@amazon.com>
* Delete more hangover files.
Signed-off-by: John <jonawals@amazon.com>
* Minor member name refactor.
Signed-off-by: John <jonawals@amazon.com>
* Refactor nonclemanture.
Signed-off-by: John <jonawals@amazon.com>
* Rename Enter/ExitMode to Register/UnregisterMode.
Signed-off-by: John <jonawals@amazon.com>
* Error and warning msgs now return AZ::Outcomes.
Signed-off-by: John <jonawals@amazon.com>
* Change all nomenclature to Activate/Deactivate for consistency.
Signed-off-by: John <jonawals@amazon.com>
* Change tense of notification bus methods.
Signed-off-by: John <jonawals@amazon.com>
* Fix malformed string format.
Signed-off-by: John <jonawals@amazon.com>
* Fix malformed string format (again).
Signed-off-by: John <jonawals@amazon.com>
* Fix Linux warning.
Signed-off-by: John <jonawals@amazon.com>
* Call sites for editor mode activate/deactivate.
Signed-off-by: John <jonawals@amazon.com>
* Move Component editor mode logic to ComponentModeCollection.
Signed-off-by: John <jonawals@amazon.com>
* Delete non-source data.
Signed-off-by: John <jonawals@amazon.com>
* Remove line breaks and forward declare class.
Signed-off-by: John <jonawals@amazon.com>
* Remove constructors without ViewportEditorModeTrackerInterface ptr.
Signed-off-by: John <jonawals@amazon.com>
* Add integration tests for viewport editor modes.
Signed-off-by: John <jonawals@amazon.com>
* Address PR comments.
Signed-off-by: John <jonawals@amazon.com>
* Removed ununeeded includes from EBus EBus.h and Policies.h
Updated the locations which needed those includes
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Adding missing include for <memory> to AWsClientAuthBus.h
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Remove the while true loop in the EBusQueuePolicy Execute() function
The while true loop in Execute was for allowing additional functions to be queued in the middle of execution of current list of functions.
That functionality was dangerous, because if a queued function added itself during execution unconditionally, then it would result in an infinite loop
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated the AssetManager::DispatchEvents function to pump the AssetBus event queue until empty
Queued Events on the AssetBus is able to queue additional events on that Bus during execution of those events.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Changed the AssetManager::DispatchEvents function to only execute the
AssetBus queued events once
Changed the AssetJobsFloodTest.AssetWithNoLoadReference_LoadDependencies_BehaviorObeyed test to dispatch events until the OnAssetContainerReady callback is signaled.
This happens after every asset load to make sure that the
expiring AssetContainer instances are removed from `AssetManager::m_ownedAssetContainer` container before retrying to load the same asset.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Added a MaxTimeoutSeconds constant for the maximum amount of the time to run a single DispatchEvents loop
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Disables a problematic child reparenting code path in EditorEntityModel that led to the series of remove -> add -> remove notifications for reparented entities that led to unnecessary updates and a sporadic QSortFilterProxyModel crash
Signed-off-by: nvsickle <nvsickle@amazon.com>
* No longer can instantiate prefabs in an empty level
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* PR feedback from Ram
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* removing tab
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* PR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Implement Project Manager 'build' button for Mac and Linux(#4248)
Signed-off-by: Steve Pham <spham@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Remove the PrefabEditManager. Introduce the FocusMode system on the Editor side, and a PrefabFocusHandler on the Prefab side to handle focus.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Changed FocusOnOwningPrefab to return Outcome. Added comments and error checking.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Remove assert for edge case that can actually happen in normal circumstances, simply return false in those cases.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Remove nested FocusModeFramework namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Minor fixes to variable names and comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* ClearFocusRoot implementation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Remove pragma once from cpp file
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Fix header formatting to pass validation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Do not assert if m_focusModeInterface can't be initialized
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Initialization changes to pass unit tests. Some interfaces are now retrieved on demand and there's clearer failure paths that don't involve asserts to better handle test/headless initializations.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS (#4268)
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS
The issue was because the compression of ETC formats took too long.
Replaced all ETC and PVRTC formats with ASTC formats.
Update all pixel operation for formats with single R channel to align the change with R8.
Signed-off-by: Qing Tao <qingtao@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Use resize_no_construct when creating a buffer asset, since the initial data is going to be memcopy'd anyways. (#4249)
Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Fix a minor spelling mistake (#4247)
Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* 1. Update iOS deployment target to 14 (#4266)
2. Set MacOS default deployment target to 11.
Signed-off-by: amzn-sj <srikkant@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Debug build clang fixes
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Fix failed 'server' platform assets on Linux related to Shaders (#4275)
* Add missing 'server' platform identifier for the ShaderBuilder
* Use the current host platform as the fallback platform identifier (and not 'pc')
Signed-off-by: Steve Pham <spham@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* [development] Atom CPU profiler include cleanup (#4272)
- Removed all unnecessary includes to Atom CpuProfiler.h
- Added includes to AzCore Profiler.h where necessary
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Add guard against edge case.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Expose Transform::CreateLookAt to behavior context to use with hydra tests
Signed-off-by: amzn-tommy <waltont@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Cached BLAS objects at the sub-mesh level
Signed-off-by: dmcdiar <dmcdiar@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* EMotion FX: Asset Processor generates an Actor for every FBX (#4284)
Fixing the actor behavior to ignore actor asset generation for files that only contain nodes/bones. We're only checking for blend shapes and skins now. In case neither is present in an FBX, we don't export the actor asset.
This makes a plain skeleton a special case where users manually need to add the actor group for the fbx. The most common use case for these are animation files anyway, where we don't want to export actor assets.
Also increased the version number of the actor group so that they are all getting reprocessed and the unneeded actor assets get removed.
Signed-off-by: Benjamin Jillich <jillich@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* EMotion FX: Crash in the actor builder when fbx meta data contains node groups (#4283)
Fixing a crash related to the small array conversion that made multiple assets crash the actor builder.
Signed-off-by: Benjamin Jillich <jillich@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Project Manager Gem Dependencies (#4132)
* Fix engine API change and add gem dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Add GemCatalog dependency test
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Clarify display name and fix missing const
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Moving a couple helper functions into private scope
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Update gem count when unselecting a gem #4074
This addresses the following issue https://github.com/o3de/o3de/issues/4074
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Active/Inactive filter and dependency tooltips
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Accessors for previously added and dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Cart displays gem dependency changes
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Shorten titles to fit in summary popup
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Remove QString::number
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Remove extra space
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Consolidate source model accesor helpers
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Addressing minor feedback
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
* Remove unused local variable
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Fix AutoGen of RPCs with no params
Signed-off-by: puvvadar <puvvadar@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Adds Inspector to Gem Repo Screen (#4242)
* Adds the gem repo screen with the UI built but with mocked data and not connected to the o3de scripts
Signed-off-by: nggieber <nggieber@amazon.com>
* Changed name of added to enabled, disabled define, removed unused functions
Signed-off-by: nggieber <nggieber@amazon.com>
* Added Repo Screen Inspector UI
Signed-off-by: nggieber <nggieber@amazon.com>
* Addressed minor PR feedback
Signed-off-by: nggieber <nggieber@amazon.com>
* Add some more minor PR changes
Signed-off-by: nggieber <nggieber@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Updated NetworkSpawnableHolderComponent to use TransformBus instead of FindComponent. Added dependency on TransformService
Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Fixed Entity::GetTransform to work for the components of an activating entity. Made the cached transform lazy evaluated.
Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Changed NetworkSpawnableHolderComponent to use Entity::GetTransform instead of an ebus call
Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Moved local variable to a smaller scope
Signed-off-by: pereslav <pereslav@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Signed-off-by: LesaelR <LesaelR@amazon.com> (#4278)
* Signed-off-by: LesaelR <LesaelR@amazon.com>
* Removing the un-needed sandbox marks.
Signed-off-by: LesaelR <LesaelR@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Small fix for color node tooltip to ask for values 0-1 instead of 0-255
Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Exposing NetworkCharacterComponent::TryMoveWithVelocity to script. Updating Multiplayer AutoComponent baseclass behavior context to Reflect itself instead of its derived (human made) component. This is so the derived class can also create behaviorcontext classes of its own if needed. Misc copyright header edit.
Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Make sure Multiplayer AutoComponents dont generate property OnChange script events if GenerateEventBindings is disabled
Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Adding parameter names to NetworkCharacterComponent script events so people know what the parameters are used for in scriptcanvas
Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Small fix to use AZ_CRC_CE
Signed-off-by: Gene Walters <genewalt@amazon.com>
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Disabling some tests when prefab mode is enabled
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Revert "Disabling some tests when prefab mode is enabled"
This reverts commit 3fe9358d42ec9d7fa5ffaee458e4c6ca3ecbed6e.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Revert "PR feedback"
This reverts commit a5b86d1954974b950b7719d1bc7dd56bc2a2a21b.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Revert "removing tab"
This reverts commit ff6ef4bfb514d82a1b668baa95901ad363e648d0.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Revert "PR feedback from Ram"
This reverts commit cba7f9c2a114d3bb51c9b64f38a7e1fef7bb8fe8.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
* Renaming level->rootInstance
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com>
Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
Co-authored-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
Co-authored-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
Co-authored-by: Tommy Walton <82672795+amzn-tommy@users.noreply.github.com>
Co-authored-by: SJ <srikkant@amazon.com>
Co-authored-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com>
Co-authored-by: Scott Romero <24445312+AMZN-ScottR@users.noreply.github.com>
Co-authored-by: amzn-tommy <waltont@amazon.com>
Co-authored-by: dmcdiar <dmcdiar@amazon.com>
Co-authored-by: Benjamin Jillich <43751992+amzn-jillich@users.noreply.github.com>
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Co-authored-by: puvvadar <puvvadar@amazon.com>
Co-authored-by: AMZN-nggieber <52797929+AMZN-nggieber@users.noreply.github.com>
Co-authored-by: pereslav <pereslav@amazon.com>
Co-authored-by: LesaelR <89800757+LesaelR@users.noreply.github.com>
Co-authored-by: Gene Walters <genewalt@amazon.com>
* first pass fixes for how entity space is handled in the viewport interaction model
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* small updates to simplify space handling
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* fix for influence group with one entity selected
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* some tidy-up and fix for scale manipulator snapping
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* couple of small fixes for scale manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* small comment update
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* fixes for integration test failures
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* add test for rotation manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* add test coverage for rotation manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* add tests for translation manipulators and some other tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* add tests for translating a group of entities
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* add some tests for scale manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* some updates and formatting changes (clang-format) to ViewportScreen
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* simplify usage of lround code
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* update missed name updates
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* update usage of WorldToScreenNdc
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* some more small tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* move static variables to be marked inline
Signed-off-by: hultonha <hultonha@amazon.co.uk>
* small formatting fixes
Signed-off-by: hultonha <hultonha@amazon.co.uk>
Danilo Aimini
srikappa-amzn
jonawals
amzn-sean
AMZN-Igarri
Steve Pham
lumberyard-employee-dm
Artur K
Nicholas Van Sickle
Chris Galvan
Mikhail Naumov
hultonha