ac959bcc01
Dragging an entity from outside the focused Prefab into it may crash the Editor ( #5762 )
...
* Replace Instance References with EntityId of the Prefab Container (WIP)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Use the invalid entity id for the root instance and get the root instance every time to prevent weird Prefab EOS shenanigans.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Revert unnecessary changes, fix IsOwningPrefabBeingFocused to match previous behavior. Disable some tests that no longer apply correctly due to the testing environment not relying on the Prefab EOS.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fix minor typo in test comment
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-11-18 15:06:58 -08:00
da3a39a6a0
LYN-7121 | Focus Mode - Make editing a prefab an undoable operation ( #4582 )
...
* Refactor the PrefabFocusInterface to differentiate between Public and Internal functions. Introduce PrefabFocusUndo nodes to allow undoing Prefab Edit operations.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fix selection code to avoid warning message
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Removed changed property from PrefabFocusUndo node
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Switch from size == 0 to empty in EntityOutlinerWidget::OnSelectionChanged
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* condense if check on Prefab Edit context menu item setup
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Correct interface usage in PrefabIntegrationManager (interface was renamed to public)
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Remove rej file that was included by mistake
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fix missing interface initialization in PrefabFocusTests
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-10-13 12:37:07 -07:00
23322edde7
Fix Entity id consistency issue & refactor prefab workflows/tests ( #4373 )
...
* Fix Entity id consistency issue & refactor prefab workflows/test framework
Signed-off-by: chiyteng <chiyteng@amazon.com >
* Update comments
Signed-off-by: chiyteng <chiyteng@amazon.com >
* Modify CreatePrefab and remove extra spaces
Signed-off-by: chiyteng <chiyteng@amazon.com >
* Address comments
Signed-off-by: chiyteng <chiyteng@amazon.com >
* Refactor prefab instance constructors
Signed-off-by: chiyteng <chiyteng@amazon.com >
* Remove commented out code
Signed-off-by: chiyteng <chiyteng@amazon.com >
2021-10-01 10:02:00 -07:00
225d9d3b3c
Fixes to unit tests after merge
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-30 10:33:32 -07:00
d3bc7d8f12
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzToolsFramework/Tests/FocusMode/EditorFocusModeTests.cpp
# Code/Framework/AzToolsFramework/Tests/Prefab/PrefabFocus/PrefabFocusTests.cpp
2021-09-30 10:32:03 -07:00
8d67f184c8
LYN-7008 | Focus Mode - Selection unit tests ( #4357 )
...
* Refactor existing tests and fixtures, split them up in more granular tests, and add more comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Refactor test fixture for FocusMode to make it more reusable
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fixture rename, draft of selection test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Split SetFocus and ClearFocus tests for Editor Focus Mode
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Move BoundsTestComponent to its own file so that it can be reused in Focus Mode Selection tests
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Making progress on selection test. Test compiles now, but selection doesn't seem to be working.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Removed commented out code from previous iteration.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Move BoundsTestComponent under the UnitTest namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Viewport selection tests + minor fixes.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor fixes
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-30 18:05:50 +01:00
a7f6bfbb50
Fix tests to work with new interface APIs using EditorEntityContextId
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-29 14:21:19 -07:00
80e6a6903a
Remove unused CreateEditorEntity function
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:55:02 -07:00
72110e40cf
Add Unit tests for EditorFocusMode and PrefabFocus. Minor change to PrefabFocusHandler to avoid instantiating a new AZ::EntityId() for checks.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:05:34 -07:00
Danilo Aimini
chiyenteng