54e0b8b7b5
Enabling mac tests ( #6716 )
...
* Adds mac test job
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Points to sysctl properly to handle zsh
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes some macos differences with Linux when reading the CTEST_RUN_FLAGS parameters
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* adding the test job to the profile pipe
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables some tests in Mac that are not passing
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* passes config to cli_test_driver and sets the right trait for the test (pytest instead of lytesttools)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Set proper traits for AtomRHI
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Corrected AZ_TRAIT_UNIT_TEST_PERLINE_GRADIANT_GOLDEN_VALUES_7878 values for Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Disables EMotionFX tests in Mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes debugging prints
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes filters that were meant just for Linux
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* quotes are re-quoted in the test_mac.sh script
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-06 16:16:48 -08:00
f376d7e379
Merge pull request #6468 from aws-lumberyard-dev/Prefabs/ProcessStackAddPrefabBug
...
Spawnable Entity Alias improvements
2022-01-06 14:58:27 -08:00
d3b36f1814
Added a couple more missing includes
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-06 13:55:52 -06:00
53e6f0f99f
Added another missing include
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-06 13:27:44 -06:00
e5c2d574fc
Added a missing include and forward declare
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-06 12:51:10 -06:00
fee88cf5c6
Removed legacy editor DatabaseLibrary code.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-06 10:12:54 -06:00
66985e3569
Updates to ViewportTitleDlg to better expose grid snapping visualization ( #6700 )
...
* updates to ViewportTitleDlg to better expose grid snapping visualization
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* small typo fix
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add escape handling for widget to be more consistent with other QMenu behavior
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* remove unneeded [[maybe_unused]]
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2022-01-06 09:26:16 +00:00
e2a960e442
Fixed a sync issue when a PrefaDOM was taken from a PrefabDocument.
...
When a PrefabDOM was taken from a PrefabDocument the Instance would continue to have the data from the original Prefab, which means they'd no longer be in sync as the Prefab would be empty. This was fixed by resetting the Instance so they're both clear.
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 17:21:15 -08:00
09fd52ef73
AzCore Math tests produce errors that need to be disabled in debug ( #6678 )
...
* Tests produce errors that need to be disabled in debug
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR suggestion
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 16:07:52 -08:00
6c3d5c434e
{lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic ( #6396 )
...
* {lyn8865} Adding DataTypes::ScriptProcessorFallbackLogic
- Give the user an option how to handle fallback logic for script rules
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
* the new code found an error in a Python script... it seems to work!
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
* fixing up the regression test
Signed-off-by: Jackson <23512001+jackalbe@users.noreply.github.com >
* dump version number
Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com >
2022-01-05 16:08:58 -06:00
233349ffe3
Removed unused Editor code from EditMode/Geometry/Include/LightmapCompiler
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-05 13:35:09 -06:00
13375cd7d9
Merge branch 'development' into Prefabs/ProcessStackAddPrefabBug
2022-01-05 11:12:57 -08:00
31e51f8c3a
Minor updates to the Spawnable Entity Aliases in response to PR feedback.
...
Signed-off-by: AMZN-koppersr <82230785+AMZN-koppersr@users.noreply.github.com >
2022-01-05 10:47:23 -08:00
89067fe667
Memory/benchmarks ( #5896 )
...
* initial version ported from an old implementation
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* simplification of code
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes a recursive loop
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removing commented code of different options for getting memory usage of a process
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR comment (NULL->nullptr)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds mulit-threaded tests
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Improving runtime and making the whole duration manageable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes Linux build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes for mac
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes for HeapSchema to get a default block if none is passed
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds recording functionality (disabled) and a benchmark that can run recordings
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Removes Heap allocator from being possible to use as a SystemAllocator since it doesnt allow dynamic allocating (only works with pre-allocated blocks)
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* WIP trying to use SystemAllocator instead of raw reads
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Makes the recorded benchmark more stable
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* More stability changes, improvement on type usage within the benchmark, cleanup of unstable stats
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Adds benchmark files for Android
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Fixes Linux nounity build
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* PR comments
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
* Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process)
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 10:40:03 -08:00
c548fd7682
Death test relies on an exception from ocurring, that exception is an access violation, which could not happen (i.e. the memory could be valid for the process) ( #6683 )
...
The test didnt have to be a death test. Also handled the situation better in the code to be able to continue in that scenario (useful for release configurations)"
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2022-01-05 08:15:08 -08:00
ff947dfcc3
Merge pull request #6682 from aws-lumberyard-dev/cgalvan/RemoveUnusedEditorControls
...
Removed some unused classes from Editor/Controls
2022-01-05 06:05:29 -06:00
648a21ab5c
[Linux] Correct handling of new dirs added to non-recursive watch roots
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
2bc1d8620e
Rename file to adhere to PAL conventions
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
484e27c109
Use AZStd::equal to implement path comparison
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
ce0bb1ca2b
[AssetProcessor] Refactor the FileWatcher to use only one watch thread
...
This change reworks the AssetProcessor's FileWatcher so that it only uses
one thread. This is motivated by getting better support for inotify on
Linux. The previous architecture required calling `inotify_init` once for
each directory that was being watched, and using separate inotify instances
for each watched tree. In addition, having separate threads per watched
tree is not necessary, and just consumes system resources. Each platform
supports watching multiple directories with the same platform-specific
watcher API, so each platform has been updated accordingly.
The interface to the FileWatcher class is greatly simplified. Previously,
it supported client-supplied filtering of the paths that would generate
notifications. This was done by subclassing `FolderWatchBase` and
implementing `OnFileChange`. However, only one filter was ever used, so
that filter is now hard-coded in the FileWatcher class, and the classes
driving the old filtering mechanism are removed. Users of the interface
now have a much easier time, they just call `AddFolderWatch` with the path
to watch, and only have to connect to one set of signals, instead of
separate signals per watched directory.
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
7ac5bc3d5c
[Linux] Display a warning in AP if inotify fails to initialize
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
04f4d5e031
[Linux] Avoid recursive inotify when a watch folder is set to recursive=false
...
Signed-off-by: Chris Burel <burelc@amazon.com >
2022-01-04 16:12:17 -08:00
c773c9e9aa
Removed some unused classes from Editor/Controls
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-04 16:39:04 -06:00
2b9d1ca813
Update to use AWSNativeSDK 1.9.50 ( #6618 )
...
* Update to use AWSNativeSDK 1.9.50
* After SDK upgrade, some AWS objects are bound to SDK allocator, init AWS SDK for unit test
2022-01-04 12:45:51 -08:00
f051886789
Merge pull request #6675 from aws-lumberyard-dev/cgalvan/RemoveUnusedEditorCommonImages
...
Removed unused images under Editor/Common
2022-01-04 14:36:51 -06:00
8ee384f436
Asset Processor: Remove gem loading from AP ( #6488 )
...
* AssetBuilder sends builder registration network message to AP
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add AP activating status message
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* First builder handles registration.
Fixed deadlock caused by AP and AssetBuilder waiting on each other when registering by moving AP builder start code to a thread
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up external builder registration
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add thread description for builder manager idle thread
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove gem loading
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Clean up builder registration and remove unused functions
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove PostActivate call from batch application since it will be called after builders are registered
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Removal external builder dependency scanning since we no longer support builder dlls
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix missing bus disconnect
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused variable
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Moved AP-AssetBuilder specific types into AssetBuilder.Static library. Also removed some unused/old code
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-04 12:34:56 -08:00
6a45d36051
Merge pull request #6674 from aws-lumberyard-dev/cgalvan/RemoveUnusedBoneNamesClass
...
Removed unused bone name class.
2022-01-04 12:55:15 -06:00
9f500b1228
Merge pull request #6571 from aws-lumberyard-dev/Prism/RearrangeProjectsAfterRemoval
...
Reflow Project Tiles Everytime They Are Updated
2022-01-04 09:03:42 -08:00
685706f817
Removed unused images under Editor/Common
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-04 10:58:50 -06:00
2dfdabdfc9
ProcessWatcher fixes. ( #6570 )
...
* ProcessWatcher fixes.
Signed-off-by: bosnichd <bosnichd@amazon.com >
* Update based on review feedback.
Signed-off-by: bosnichd <bosnichd@amazon.com >
2022-01-04 09:54:20 -07:00
c15ead9c30
Removed unused bone name class.
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-04 10:32:52 -06:00
7581967da3
Merge pull request #6300 from tjmgd/bug-script-canvas-60
...
Script Canvas Groups - Updated keyboard shortcut bindings to avoid conflict with "play game" shortcuts
2022-01-03 14:56:06 -08:00
fd9574c648
Removed legacy QtUi/ClickableLabel and re-worked about dialog to use QLabel for terms of use label
...
Signed-off-by: Chris Galvan <chgalvan@amazon.com >
2022-01-03 14:21:44 -06:00
aa17120f09
Merge pull request #6496 from pollend/chore/add-assets-plane
...
chore: add assertions to plane to ensure normalization
2022-01-03 12:29:42 -06:00
81453defa0
Load QIcons once for asset tree and share with each Asset Tree Item to avoid file loads for every asset and improve start up time ( #6485 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:56:19 -06:00
a95b303f19
Remove Shader compiler tab from Asset Processor ( #6486 )
...
* Remove Shader compiler tab from Asset Processor
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove more references to shader compiler
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:44:51 -06:00
346a414aff
Change AP unit test project to a DLL like all others, add benchmarks project ( #6588 )
...
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2022-01-03 09:44:34 -06:00
79dd65e1cc
Quaternion shortest equivalent ( #6472 )
...
* Added new helper functions to get the shortest equivalent of the rotation. In case the w component of the quaternion is negative the rotation is > 180° and taking the longer path. The quaternion will be inverted in that case to take the shortest path of rotation.
* Added unit test.
* Renamed the angle parameter of the CreateRotationX/Y/Z() functions into angleInRadians.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
2022-01-03 10:20:27 +01:00
81b2841bd2
chore: correct text for assertion
...
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-12-28 09:16:48 -08:00
ad38c788f9
Merge pull request #6250 from BytesOfPiDev/issue6198
...
Prevent some slice-related commands from being enabled when the slice…
2021-12-27 16:31:46 -06:00
451ebf2691
Reflow Project Tiles Everytime They Are Updated
...
Signed-off-by: nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
2021-12-27 12:32:24 -08:00
24a3014e06
Merge pull request #6318 from aws-lumberyard-dev/PathSerializationSupport
...
Introduced a Json Serializer for the AzCore mutable path classes
2021-12-27 13:16:39 -06:00
e09a4d20d3
Merge pull request #6240 from tjmgd/bug-keyword-prefab-23
...
Fix for bug in entity outliner search box
2021-12-27 13:12:08 -06:00
c3de8034eb
Merge pull request #6560 from aws-lumberyard-dev/RemoveTimeTests
...
Remove time tests that relied on main-thread sleeps
2021-12-24 10:34:10 -07:00
174e27cbfb
Merge pull request #6559 from aws-lumberyard-dev/NullVariableInterfaceOptimization
...
Disambiguate null interface case
2021-12-24 10:33:58 -07:00
5b76d47e17
Remove time tests that relied on main-thread sleeps
...
Sleeping in tests and attempting to rely on fine-grained measurements to
check code validity is intrinsically brittle. Wall-clock time is
unreliable in an environment where tests are run under a hypervisor that
may choose to suspend your VM at any point, or in situations where the
OS cannot schedule your thread in time. The correct way to reintroduce
these tests in the future is provide an override for the timestamp
queries that can be injected in the test environment to control the wall
time deterministically.
Signed-off-by: Jeremy Ong <jcong@amazon.com >
2021-12-23 17:15:49 -07:00
6660c365b9
Disambiguate null interface case
...
In some cases, the interface being queried may be persistently nullptr
(e.g. a gem isn't active, or a feature was disabled by a cvar). In this
case, querying the interface would always enter the writer-lock branch
with existing code because nullptr was synonmous with "we haven't
queried for this variable yet."
This PR adds an additional state variable that is set when s_instance is
assigned to, so that after the variable is queried and found to be null,
future queries can enter the read-lock branch.
Signed-off-by: Jeremy Ong <jcong@amazon.com >
2021-12-23 16:25:44 -07:00
f1a1cb3ec0
Fix: Lua directory empty and always loading in editor ( #6207 )
...
* Fix: Lua directory empty and always loading in editor
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
* fixed naming convention errors
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
* Tidy up
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-23 12:12:40 -08:00
c2373f1f59
Fix: search results not expanded when searching for .lua files ( #6211 )
...
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com >
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com >
2021-12-23 12:12:27 -08:00
7dac0bac0d
chore: remove "using namespace " from AZCore Math ( #6372 )
...
* chore: remove "using namespace " from AZCore Math
REF: https://github.com/o3de/o3de/issues/6281
Signed-off-by: Michael Pollind <mpollind@gmail.com >
* chore: fix formatting
Signed-off-by: Michael Pollind <mpollind@gmail.com >
2021-12-22 13:11:41 -08:00
Esteban Papp
Ronald Koppers
Chris Galvan
Tom Hulton-Harrop
Allen Jackson
Chris Burel
Vincent Liu
amzn-mike
AMZN-Phil
bosnichd
Luis Sempé
Benjamin Jillich
Michael Pollind
nggieber
Jeremy Ong
Jeremy Ong
tjmgd