By setting the initialization flag before the CheckReady() call, the notifications get sent correctly, and no extra asset references remain. This checkin also includes a unit test for the AssetManager that specifically forces this condition to happen and validates that it works correctly.
* Created the Project Manager project with a barebone styled window and rough sketch of first screen
* Renamed to Project Manager, ect.
* Corrected string name for projectmanager and added comments on getting engine path
* Changed output name for Project Manager to lowercase o3de
* Added header guards
The AssetBundler is a new ToolsApplication that allows users to work through the entire Asset Bundling process without ever touching a command line.
* Integrating github/AssetBundler through commit 1d65018
* Asset Bundler bug fixes: platform initialization and GUI styling (#5)
* fixed enabled platform initialization
* fixed the cached engine root. This fixed some of my Seeds tab data issues. The default Engine Seed List appeared, and was able to display the contents on screen.
* updated my notes of active bugs
* changed some casing in various include lines to hopefully fix my linux build
* another include fix for linux
* AssetBundler GUI is now compiling on Mac
* removed some things off of my todo list because the mac build fix actually fixed the visuals! everything's the right color again
* removed the word Lumberyard from the bundler
* Asset bundler bug fixes - Bundles, Gems, and Tests (#9)
* Fixed the Bundle loading and generation problem. Turned out to be a FileWatcher issue.
* turns out gem loading wasn't broken, there were just no existing SeedListFiles for any of the gems loaded by the AutomatedTesting project. I added a default SeedListFile for the PrimitiveAssets Gem.
* fixed some failing AssetBundler Gem tests
* Misunderstood the need to have default seed lists for asset-only gems. removing the previously created seed list file
* Asset bundler bug fixes: Seeds Tab display issues and _dependencies.xml loading (#10)
* Fixed the Project Source column in the Seeds tab
* The AssetBundler will no longer attempt to copy a template version of the ProjectName_dependencies.xml file into your active project. However, it will throw an error if you do not have one. A follow-up ticket has been cut to address this issue.
* updated the AssetBundler icon. This one matches the current style guides
* PR feedback: pass a const ref instead of a value
* PR feedback: safer conversion from a string_view to a QString
Co-authored-by: alexpete <alexpete@amazon.com>
* ATOM-15369 Expose sorting paramers to DynamicDrawContext's draw functions
LYN-3352 LyShine: First element in Hierarchy does not properly draw in UI Editor
Add function to DynamicDrawContext to support set sort key for followed draw calls.
Use different sort key for background draw and top layer draw in UI canvas.
The specific mutex is "m_assetMutex" in the AssetManager. AssetManager::ReloadAssetFromData was holding this lock while calling AssignAssetData, which goes on to call OnAssetReloaded. This is dangerous, because any arbitrary logic can be executed during that call, including blocking asset loads, which is what happens in this specific deadlock case. The fix is to move the call to AssignAssetData outside of the mutex lock. AssignAssetData itself already grabs the assetMutex to protect the parts of its logic that are necessary, and then specifically releases the lock before calling OnAssetReloaded, so this change shouldn't introduce any dangerous threading conditions.
(cherry picked from commit 1581a28339f12d521955edef890acfb678a0df6f)
- Remove some references to gEnv->pRenderer/GetIEditor()->GetRenderer() that is now always null.
- Restore the debug console to existence.
- Stop building the following in preparation for their removal:
Code/CryEngine/Cry3DEngine/*
Code/CryEngine/RenderDll/*
Code/Tools/CryFXC/*
Code/Tools/HLSLCrossCompiler/*
Code/Tools/HLSLCrossCompilerMETAL/*
Code/Tools/RC/*
Code/Tools/ShaderCacheGen/*
Tools/CrySCompileServer/*
mbalfour
galibzon
Terry Michaels
AMZN-nggieber
dmcdiarmid-ly
lumberyard-employee-dm
SJ
AMZN-mnaumov
Zaladane
AMZN-Phil
Brian Herrera
mnaumov
Guthrie Adams
bosnichd
cgalvan
dmcdiar
Chris Galvan
garrieta
Jonny Galloway
Mike Balfour
Vicky
Luis Sempé
Esteban Papp
AMZN-puvvadar
luissemp
greerdv
Scott Romero
greerdv