Fixes a bug with the visualizer where there would be empty rows shown,
e.g. threads without any profiling regions. This was especially
noticable when going from a high thread count sample (MultiThread) to a
low thread count sample, where most of the visualizer would be empty
lines. This adds a data culling step to remove the threads without any
remaining execution data + an early out so that all threads shown
onscreen must have some regions recorded.
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: Implement continuous capture internals
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: extend ProfileCaptureSystemComponent
Implements dumping of saved CPU profiling data to a local file, blocking
call.
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: Working IO thread for serialization
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: switch to AZ::JobFunction for IO
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: move to a ring buffer for storage
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: switch back to IO thread
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: add TODO
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Profiler: correct thread safety issues
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
Current metrics are MTPC, max time, and invocations per frame. The
invocations per frame is buggy if switching between samples but I don't
know how to fix that in a context-agnostic way (editor vs ASV) - resetting
works for now.
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Histogram: Basic working graph of frame times
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Histogram: Improve usability
Implements horizontal frame limit lines, limit-based coloring, and a
viewport indicator.
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Histogram: Implement interactions
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Add missing RTTI include to fix non-unity build error
* Add missing includes that were automatically added as part of unity builds
Signed-off-by: Steve Pham <spham@amazon.com>
* Profiler: move to OnSystemTick polling
Migrates from implementing FrameEventBus::Handler to SystemTickBus::Handler.
When we were collecting data from threads on the start of a frame, it
turns out that the event only fired once the RHI began working, which
would exclude any events before that (ex. RPI, some AuxGeom regions)
from the next GetTimeRegionMap call.
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: update logic to avoid dangling frame
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: implement basic performance widget with controls
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: implement basic function statistics
- Fix floating point bug in drawing logic
- Implement color picker for regions
- Aggregate invocations and average time across frames
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: drawing execution time labels
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: fix fstring type errors
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: fix remaining fstring errors
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: implement cursor-relative zooming
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: try to update AR status
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address PR comments + cleanup
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address more PR comments
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* Visualizer: address more PR comments
Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
* ATOM-15939 Add support to capture attachment for ParentPass
- Moved the attachment read back support to Pass class so it supports both ParentPass and RenderPass.
- Added support to output input or output state of an InputOutput attachment.
- Enabled showing ParentPass attachments in PassTree tool.
Signed-off-by: Tao <qingtao@amazon.com>
* Final update copyright headers to reference license files at the repo root
Signed-off-by: spham <spham@amazon.com>
* Fix copyright validator unit tests to support the stale O3DE header scenario
Signed-off-by: spham <spham@amazon.com>
* Fixed organization of the AssetProcessor SourceAssetBrowser
Assets within the Engine Root were grouped under a '/' entry.
That has been fixed to use the relative path within the engine root for
those assets
Assets outside of the Engine Root, but on the same drive were using
absolute paths before. Now there are child entries that navigate up the
directory hierarchy to those asset locations
* Added ly_enable_gems call to Atom gems targets that are required
The DefaultLevel.prefab contains several Atom components, that require
the Atom RHI, RPI, Common_Feature, ShaderBuilder and AtomLyIntegration CommonFeatures
gems to be enabled in order to successfully process in the
AssetProcessor.
* Added ly_enable_gems call to make the Camera gem required in Tools,
Builders and Clients.
This is needed as the DefaultLevel.prefab contains an Editor Camera
Component
* Adding the ly_enable_gem call to make the Maestro gem required
CrySystem currently requires Maestro to be enabled in order to
initialize
* Added ly_enable_gems call to the SceneProcessing gem to make it required
The SceneCore and SceneData libraries that are part of the core engine
Code folder requires the SceneProcessing gem to be enabled in order to
invoke the InitializeDynamicModule hooks in DllMain.cpp in order to
initialize those libraries.
* Fixed bad argument in comment for Prefab CMakeLists.txt
* Fixed Assert in Asset Builders due to the Atom RPI Builder
The Atom RPI Builder was enabling the Asset Catalog for the ScriptAsset a second time
The Atom Feature Common EditorSystemCommonComponent.cpp which also loads
in the AssetBuilder is enabling the Asset Catalog for the ScriptAsset
Added BehaviorContext reflection to the OutputDeviceTransformType enum
to fix the BehaviorContext errors about reflecting a method that returns
such an enum
* Added TypeId output to the JsonDeserializer report message about missing
ClassData
Previously the report callback would indicate that the target type was
missing Serialization class data, but didn't indicate the TypeId of the
target type
* Added support to the ly_enable_gems function to be able to support
0 gems being enabled.
Updated the Install step for CMake to propagate any ly_enable_gems
within a CMakeLists.txt for a target into the generated CMakeLists.txt
that is made for each installed IMPORTED target
* Adding newline to the end of the Camera Gem CMakeLists.txt
* Fixing target TYPE parameter for actual Gem Modules to use the GEM_MODULE tag instead of MODULE
* Reverting change to the DESTINATION directory for the installed CMakeLists.txt to use the relative path to the installed directory
* Adding the Atom_Bootstrap gem as a required gem
The Client and GameLaunchers required the Atom_Bootstrap gem in order to create the NativeWindow
Added Atom_Feature_Common client module as a runtime dependency of the AtomLyIntegration CommonsFeature client module
* Fixed register.py --all-projects-path and --all-gems-path arguments to
NOT register projects or gems that are within a template folder
Fixed reading of old pre-1.0 o3de_manifest.json files where the
"engines" key was a json array
* Changed how the relative target source directory is calculated when that source directroy resides outside of the engine root.
The final dirname component is used with a unique SHA256 has to form a <dirname>-<8 char SHA256> folder for installing files into
* Adding newline to the end of Atom_Bootstrap CMakeLists.txt
* Moving ly_enable_gems variants for Tools and Builders inside of PAL_TRAIT_BUILD_HOST_TOOLS block
* Adding a comment to AWSCore.ResourceMappingTool target to indicate that it is not a GEM_MODULE.
Furthermore it cannot be loaded with the Gem system because the library is in a different directory the executable
- Added a pause button in imgui cpu profiler.
- Added a capture button to save cpu profiling data to a data file.
- Added some profile marks in both RPI and RHI.
- Added pause/resume button to ImGui Profiler to pause/resume profiling
- Added showing pass execution timeline
- Change TimestampResult to include both begin tick and duration tick. Update some function names of TimestampResult.
- Update some functions names in Pass.
- Stop showing accumulated time for ParentPass.
- Fixed a crash issue with ImGuiManager which doesn't have default font.
pappeste
Steve Pham
Jacob Hilliard
Jacob Hilliard
Chris Galvan
Qing Tao
lumberyard-employee-dm
moudgils
Chris Burel
qingtao
alexpete