Visualizer: switch to erase_if to improve performance (#2779)

Signed-off-by: Jacob Hilliard <jhlliar@amazon.com>
2021-08-04 10:26:06 -07:00
parent dbb6c1ae46
commit 6d345512c1
1 changed files with 6 additions and 5 deletions
@@ -520,13 +520,14 @@ namespace AZ
            {
                AZStd::size_t sizeBeforeRemove = savedRegions.size();

-                auto firstRegionToKeep = AZStd::lower_bound(
-                    savedRegions.begin(), savedRegions.end(), deleteBeforeTick,
-                    [](const TimeRegion& region, AZStd::sys_time_t target)
+                // Use erase_if over plain upper_bound + erase to avoid repeated shifts. erase requires a shift of all elements to the right
+                // for each element that is erased, while erase_if squashes all removes into a single shift which significantly improves perf.
+                AZStd::erase_if(
+                    savedRegions,
+                    [deleteBeforeTick](const TimeRegion& region)
                    {
-                        return region.m_startTick < target;
+                        return region.m_startTick < deleteBeforeTick;
                    });
-                savedRegions.erase(savedRegions.begin(), firstRegionToKeep);

                m_savedRegionCount -= sizeBeforeRemove - savedRegions.size();
            }