Commit Graph

57 Commits (3698c3c3a79de0ac3cafb579c30e09f775190a3a)

Author SHA1 Message Date
lumberyard-employee-dm f648cb1fd8
Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
jckand-amzn 36eac35bc3
Removing xfail from optimized Gradient Signal tests and disabling non-optimized suite (#4475)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e4479fff4a
Dynamic Vegetation automated test conversion/optimization (#4175)
* Initial batch of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding another round of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding more optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding another round of optimized Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Final batch of converted Dynamic Vegetation tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Re-organizing/cleaning up TestSuite files

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Running optimized tests without xfail marker for Jenkins test

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Corrected path on CMakeLists.txt to point to the correct TestSuite file for optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Adding xfail mark to DistanceBetweenFilter tests due to Editor deadlock

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating CMakeLists to build Launcher

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating xfail for DistanceBetweenFilter tests to skips as they timeout and cause cascading test failures

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Re-added xfail marker to optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Correcting a few typos

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn a4424ea820
Adding xfail mark to LayerBlender test due to Launcher crash on quit (#4173)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn b95e170f9e
Marking DistanceBetweenFilter tests with xfail due to Editor deadlock (#4156)
* Marking DistanceBetweenFilter tests with xfail due to Editor deadlock

Signed-off-by: jckand-amzn <jckand@amazon.com>

* Updating xfail mark

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
ANT\aljanru 9159eccb25 Fixes for periodic and gpu tests affected by the move 4 years ago
AMZN-AlexOteiza 2ca03367bb
Re-added removed xfails by accident (#3901)
Co-authored-by: Garcia Ruiz <aljanru@amazon.co.uk>
4 years ago
jckand-amzn c30642d855 Renaming test files for standardization and setting optimized tests to run alongside existing
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 860e6b0a5f Merge branch 'development' of https://github.com/o3de/o3de into jckand/PhysXVegTestFix 4 years ago
jckand-amzn e8bca8bc00 Updating test with a workaround for assigning a PhysX Mesh asset to a PhysX Collider component
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e67485b51f
Gradient Signal automation optimizations with TestAutomationBase/parallelization (#3316)
* GradientSignal automation optimizations with TestAutomationBase/parallelization
* Changing Gradient Signal test registration to use TestAutomationBase

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 1a430755df
Landscape Canvas automation optimizations with TestAutomationBase/parallelization (#3255)
* Convert Landscape Canvas main tests to use TestAutomationBase
* Updating main Landscape Canvas test suite to batch run tests
* Converting initial batch of Landscape Canvas periodic tests to use TestAutomationBase/test parallelization
* Renaming Editor Script to fit naming convention
* Updating explicit waits to wait_for_condition checks
* Additional test conversions
* Renaming Editor Script to fit naming convention
* Additional test parallelizations
* Additional test conversions
* Renaming optimized test file
* Adding Main test file for non-optimized tests

Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
Chris Galvan 5b0046ce78 Resolved conflicts in merge from stabilization/2106 -> development.
Signed-off-by: Chris Galvan <chgalvan@amazon.com>
4 years ago
Esteban Papp 181998f810
Fixes a nightly build and a CMake warning (#2941)
* Addressing CMake warning and removing timeouts that are the same as the default

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* missed this one

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* Making it an error so developers stops putting timeouts longer than the allowed one since it causes AR issues

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* fixing warning from the nightly build

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>

* disabling test that is triggering a timeout

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
4 years ago
Chris Galvan 7ec6feddb8
Merge pull request #2329 from aws-lumberyard-dev/jckand/VegDebuggerTestStabilization
Removing obsolete Vegetation Debugger test
4 years ago
jckand-amzn 7ebdde0be0 Adding xfail mark to test_LandscapeCanvas_GraphClosed_OnEntityDelete
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 3050a4db47 Removing obsolete Vegetation Debugger test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn e0c94dcf45 Updating xfail reason for tests currently failing due to instance spawning with null renderer
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 6fcf9aa9e1 Updated component configuration for new uniform scale in SlopeAlignmentModifier tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 2173693462 Updating component configuration and expected instance counts for SlopeFilter test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn d9874431e2 Moving test back to xfail due to remaining issues with instance planting on meshes while null renderer is enabled
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 605c17072e Updating test suite for Position Modifier test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn b7cb9fa5e3 Re-configured some component properties to account for uniform scaling in PositionModifier tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
Steve Pham 38261d0800
Shorten copyright headers by splitting into 2 lines (#2213)
* Updated all copyright headers to split the longer original copyright line into 2 shorter lines

Signed-off-by: Steve Pham <spham@amazon.com>
4 years ago
jckand-amzn ed788090d3
Adding xfail mark to test_LandscapeCanvas_GraphClosed_OnEntityDelete due to #2201 (#2208)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 4c8befe759
Removing obsolete Vegetation Debugger CVar test. CVars now function without the component present (#2200)
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 35a60cdf1a Removing unnecessary Mesh component refreshes and updating calls to scale meshes
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn ea99ed11a3 Updating mesh surface creation, filtering, and expected instance counts
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 9f5e91be88 Updating utility path for test import, and updating linked issue to disabled test
Signed-off-by: jckand-amzn <jckand@amazon.com>
4 years ago
jckand-amzn 0a68bbdf7c Updating camera position and null renderer args for launcher test
Signed-off-by: jckand-amzn <jckand@amazon.com>
5 years ago
jckand-amzn c32f00d73f Updating/re-enabling skipped/xfailed Dynamic Vegetation automated tests
Signed-off-by: jckand-amzn <jckand@amazon.com>
5 years ago
Steve Pham b4a2edec6a
Final update copyright headers to reference license files at the repo root (#1693)
* Final update copyright headers to reference license files at the repo root

Signed-off-by: spham <spham@amazon.com>

* Fix copyright validator unit tests to support the stale O3DE header scenario

Signed-off-by: spham <spham@amazon.com>
5 years ago
Steve Pham 70042fcdcd
O3DE Copyright Updates for Linux Foundation (#1504) 5 years ago
jckand-amzn d1f23aff62 SPEC-7008: Excluding more main tests from Debug test runs 5 years ago
jckand-amzn dbeee91e7b SPEC-7008: Setting up LargeWorlds main tests to be skipped in Debug builds 5 years ago
jckand-amzn 5fa67c23db SPEC-6685: Adding/updating more test summaries for TestRail decoupling effort 5 years ago
jckand-amzn b72cb2c601 SPEC-6685: Updating/adding test summaries for TestRail decoupling effort 5 years ago
jckand-amzn f2cb116240 Updating path to tests for LandscapeCanvasTests_main 5 years ago
jckand-amzn 48ef8747ef Re-enabling main suite for Dynamic Vegetation and Landscape Canvas suites 5 years ago
jckand-amzn 0caec71562 Re-enabling Foundation tests in main 5 years ago
AMZN-AlexOteiza 906780a01f
Reorganized PythonTests CMakeLists (#716)
Reorganized Python Tests CMakeLists.txt

Co-authored-by: Garcia Ruiz <aljanru@amazon.co.uk>
5 years ago
jckand-amzn a2cadb1d40 Restructuring DistanceBetweenFilter tests to allow for further debugging 5 years ago
jckand-amzn 85a25d3bc1 - Removing Debugger refreshes from DistanceBetweenFilter tests 5 years ago
jckand-amzn 20dd19c444 Cherry picking 13aa9113 from 1.0 branch 5 years ago
jckand-amzn abb5d56572 SPEC-6547: Updating intermittently failing tests to utilize instance validation util 5 years ago
Aaron Ruiz Mora 7f1e3b4054
Moving largeworlds's failing tests to sandbox 5 years ago
jckand 10361f0ae4 - LYN-3275: Marking several tests xfail due to Mesh planting issues with nullrenderer
- LYN-3273: Marking several tests xfail due to Mesh Blocker issues with nullrenderer
5 years ago
jckand 4c8401ec7a - Updating imports for LandscapeCanvas tests to new utils location
- Enabling Atom Null Renderer for launch_and_validate_results()
5 years ago
evanchia e7db0a64d6 Merge branch 'main' into hydra_util_package 5 years ago
jckand e5a990b05c LYN-3120: Temporarily disabling reset of view pane layout in editor_test_helper.py teardown. Updating view of planting area for several DynVeg tests that was changed with the addition of the default level entity. 5 years ago