e7f573d22a
Make Value ctor explicit
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-06 16:48:07 -08:00
acc6248ec9
Move deep comparison / copy to utils
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-05 11:31:09 -08:00
41c0fb2b02
Address some review feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2022-01-04 17:41:58 -08:00
e518faa8be
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2022-01-04 15:41:17 -08:00
79dd65e1cc
Quaternion shortest equivalent ( #6472 )
...
* Added new helper functions to get the shortest equivalent of the rotation. In case the w component of the quaternion is negative the rotation is > 180° and taking the longer path. The quaternion will be inverted in that case to take the shortest path of rotation.
* Added unit test.
* Renamed the angle parameter of the CreateRotationX/Y/Z() functions into angleInRadians.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
2022-01-03 10:20:27 +01:00
24a3014e06
Merge pull request #6318 from aws-lumberyard-dev/PathSerializationSupport
...
Introduced a Json Serializer for the AzCore mutable path classes
2021-12-27 13:16:39 -06:00
5b76d47e17
Remove time tests that relied on main-thread sleeps
...
Sleeping in tests and attempting to rely on fine-grained measurements to
check code validity is intrinsically brittle. Wall-clock time is
unreliable in an environment where tests are run under a hypervisor that
may choose to suspend your VM at any point, or in situations where the
OS cannot schedule your thread in time. The correct way to reintroduce
these tests in the future is provide an override for the timestamp
queries that can be injected in the test environment to control the wall
time deterministically.
Signed-off-by: Jeremy Ong <jcong@amazon.com >
2021-12-23 17:15:49 -07:00
37330c43a9
Address some more Generic Dom Value perf feedback
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-21 15:47:42 -08:00
bbd00adade
Address some AZ::Dom::Value feedback
...
- Use a vector for shared string storage (to avoid the double heap allocation for AZStd::string)
- Use a shared heap allocated any for opaque types (instead of an unsafe ref)
- Add a string comparison key lookup benchmark to measure the impact of Name
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-20 16:54:06 -08:00
1845eba6ee
Fixed compile error.
...
Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com >
2021-12-20 16:33:36 -06:00
a07534ea51
Merge commit '7e5115114ca9500abf67095acb71fbb6087d06c8' into mbalfour/gitflow_211220_stabilization_2111RTE
2021-12-20 14:43:13 -06:00
748f2a5c05
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2021-12-20 11:51:15 -08:00
fea4d0e6b1
adding TimeSystem unit tests ( #6446 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-12-20 14:32:25 +00:00
d20aa935ba
Quaternion to scaled-axis angle representation (and back) helpers ( #6421 )
...
Direct conversion helpers for quaternion to the scaled axis-angle representation and back without the need to convert them first to the axis-angle format and manually scale (or normalize on the way back). This also avoids having to deal with the special case of an identity representation which is 0,0,0 in the scaled axis-angle format while our convention for axis-angle is 0,1,0 for the axis and 0 for the angle.
Added unit tests that check the conversion round-trips from quaternion -> (scaled) axis-angle -> quaternion as well as comparing the scaled axis-angle representations from the direct helper functions as well as the axis-angle while manually scaling/normalizing.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
2021-12-17 09:43:35 +01:00
10cb618ba6
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomDocument
2021-12-15 10:24:39 -08:00
dc9d1a2f31
Introduced a Json Serializer for the AzCore mutable path classes
...
Added UnitTest for Json Serialization of AzCore Path types
resolves #2477
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-12-14 23:34:00 -06:00
f71b134a84
Ensure JsonSerializer::StoreTypeName stores the correct type for generic types
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 23:40:35 -08:00
8da04f15d3
Add some Value documentation
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-13 11:15:02 -08:00
d9ac3c2120
Tidy up Type enum
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 13:56:10 -08:00
cc120c772c
Add RapidjsonCopyAndMutate to compare w/ shallow copy
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-12 12:58:52 -08:00
c53c97cf5f
Add another round of benchmarks
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-11 15:54:57 -08:00
1af39a5c5c
Add benchmarks, some light optimizations like SSO
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-10 15:57:52 -08:00
53b88d4752
Preapre codebase for FileRequest compiletime improvements ( #6192 )
...
* Preapre codebase for FileRequest compiletime improvements
This is preparing grounds for the next PR that will contain the 'meat'
of the changes.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Remove spurious newline.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
2021-12-10 13:08:24 +00:00
947951b6c7
Add copy on write tests
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 23:43:22 -08:00
15e0bb1693
Add tests, fix missing bool in Accept and operator[] insert
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 21:37:22 -08:00
a2d474cc4f
Add some intial tests
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-09 17:47:01 -08:00
5cca52e73c
Merge branch 'development' into redcode/driller_removal
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzCore/AzCore/azcore_files.cmake
# Gems/Atom/Feature/Common/Assets/Materials/Presets/MacBeth/15_red_sRGB.tif
2021-12-07 13:31:55 -08:00
cd5306febf
Merging from development
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-07 12:35:41 -08:00
3d8664ee92
Merge pull request #5511 from aws-lumberyard-dev/nvsickle/GenericDomJson
...
Generic DOM: Add DomBackend abstraction and JSON support
2021-12-07 11:20:53 -08:00
6cf805256b
Make backend write API string-based
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-06 15:55:35 -08:00
be252d797d
Remove disabled failed asset load tests trait from linux ( #6100 )
...
* Remove trait AZ_TRAIT_DISABLE_FAILED_ASSET_LOAD_TESTS for Linux
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
2021-12-06 09:11:56 -08:00
8165f54c05
Use temporary lifetimes for test
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-03 13:52:16 -08:00
4dbce4275b
Refactor the interface after some chatting with @amazon-employee-dm
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-12-02 17:46:07 -08:00
498673ada0
Removes Driller from AzCore
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 17:15:46 -08:00
de06bb75e5
Fixes some unit tests due to the removal of the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:41:32 -08:00
19ddeeded9
Removes ThreadDrillerEvents, replaces handlers with TreadEventBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 12:40:39 -08:00
1b01ec18b0
Replaces handlers of TraceMessageDrillerBus with handlers of TraceMessageBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-02 10:09:39 -08:00
c3f035c4e3
Removes AssetMemoryAnalyzer that relies on the MemoryDrillerBus
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 19:08:12 -08:00
95ed1015a5
Removes the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:48:07 -08:00
3f6246ccbe
Removes recording of memory records through the MemoryDriller
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 18:21:39 -08:00
47de333e94
Removes m_enableDrilling
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-12-01 16:50:45 -08:00
828431f185
Update AssetManager unit tests to not interact with the disk ( #5815 )
...
* Changed AssetManager tests to use memory streams for asset reading/writing
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fix compilation on non-unity builds
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Fixed handling of path lookups when test folder path is non-empty
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add more detailed error message for "asset is not loaded"
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Make numThreads a constexpr
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add FindFile function
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove unused lambda capture
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Remove trailing whitespace
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
* Add size to assert
Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com >
2021-12-01 09:05:35 -06:00
a9c05372d5
API tweaks
...
- Use ref types
- Support using rapidjson::Value in lieu of rapidjson::Document
- Use the existing JSON comparison util function in tests
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 18:00:59 -08:00
5dbe9e387b
Address some review feedback, remove DomBackendRegistry
...
Signed-off-by: Nicholas Van Sickle <nvsickle@amazon.com >
2021-11-30 12:10:16 -08:00
879012b1ae
Added the --regset-file option for setreg file loading ( #5768 )
...
The SettingsRegistryMergeUtils.cpp now supports specifying a path to a JSON Merge Patch formated settings registry file via the --regset-file option.
The option supports specify an anchor key to merge the settings underneath that is separated from the filepath via "::"
Ex. `--regset-file="Registry/custom.setreg::/Custom/Anchor"`
An AZ::Console command of "sr_regset-file" has also been added to allow merging of a setting registry file as well.
closes #5767
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-30 13:03:46 -06:00
ca94e58399
Added SerializeContext Reflection of FixedMaxPath class ( #4453 )
...
* Added SerializeContext Reflection of FixedMaxPath class
Added UnitTest for validating path clas reflection
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Updated the paths loaded during the serialization to use test path
separator
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-29 13:50:39 -06:00
5e4bdac2e1
Merge remote-tracking branch 'upstream/development' into nvsickle/GenericDomJson
2021-11-29 09:40:56 -08:00
b882eddca8
fix dev break. AZStd::fixed_vector cannot be constexp error ( #5995 )
...
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-11-29 14:05:03 +00:00
97106f9e60
Adding missing C++20 std::erase implementations ( #5735 )
...
There were already implementations for std::erase_if.
This adds the counterpart AZStd::erase versions
resolves #5734
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-11-26 11:31:13 -06:00
5bd751531d
Update return type for viewport screen functions ( #5803 )
...
* update return type for viewport screen functions
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add tests for AZ::Matrix3x4::CreateFromMatrix4x4 and add TransformPoint to Matrix3x4
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update NDC -> Ndc
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates following review feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* updates and improvements following PR feedback
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* add forward declaration of Matrix3x4 type
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
* update where forward declarations are defined for Matrix3x4
Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com >
2021-11-24 09:17:43 +00:00
Nicholas Van Sickle
Benjamin Jillich
Chris Galvan
Jeremy Ong
Mike Balfour
amzn-sean
lumberyard-employee-dm
Artur K
Esteban Papp
Steve Pham
amzn-mike
Tom Hulton-Harrop