Added pathlib.Path.resolve() calls to make sure the compared paths were both absolute
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Validation lists cleanup
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more cleanup
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Updating LFS config to new endpoint (#1624)
Signed-off-by: AMZN-alexpete
* Updates licenses to APACHE-2.0 OR MIT (#1685)
Not to be committed before 7/6/2021
Signed-off-by: lawsonamzn <70027408+lawsonamzn@users.noreply.github.com>
* Updating CONTRIBUTING.md
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Fixed typo
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Updated text to be more descriptive
Signed-off-by: Terry Michaels <miterenc@amazon.com>
* Upload AP logs when there is an AP eeror
Signed-off-by: shiranj <shiranj@amazon.com>
* Add AP log upload step for single step Asset jobs
Signed-off-by: shiranj <shiranj@amazon.com>
* Address more comments
Signed-off-by: shiranj <shiranj@amazon.com>
* Only call CreateUploadAPLogsStage() once in try/catch block
Signed-off-by: shiranj <shiranj@amazon.com>
* Revert acciental update to README.md
Signed-off-by: shiranj <shiranj@amazon.com>
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Co-authored-by: Chris Galvan <chgalvan@amazon.com>
Co-authored-by: Nicholas Lawson <70027408+lawsonamzn@users.noreply.github.com>
Co-authored-by: Terry Michaels <miterenc@amazon.com>
* Fixed create-project/create-gem to use relative paths directly
It was previously making relative paths, relative to the default_projects_folder and default_gems_folders
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Removed uppercase of "Templates" param in get_registered call.
That method looks up the restricted template directory location based on the lowercase key of "templates"
Updated argparse doc to fix typos or clarify which directories a path is relative to.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
old vs. new defaults:
%USERHOME%/.o3de/Projects-> %USERHOME%/O3DE/Projects
%USERHOME%/.o3de/Gems-> %USERHOME%/O3DE/Gems
%USERHOME%/.o3de/Templates-> %USERHOME%/O3DE/Templates
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com>
Fixes the test screenshot upload build step:
- Added missing positional parameters
- Double quoting the command statements to allow variable expansion (also fixes broken Python call)
- Escaping the double quotes within the command statement
Signed-off-by: Mike Chang <changml@amazon.com>
Some Windows configs will automatically set new drives as online causing diskpart setup script to fail.
Signed-off-by: brianherrera <briher@amazon.com>
This change makes the inc_build_util script more resilient against transient network issues and issues encountered during node boot-up.
Signed-off-by: brianherrera <briher@amazon.com>
* adding Windows/release to PR-validation builds
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* changing trace back to expand to nothing for release
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* typo
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* more fixes
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* fixing some more unused variable cases
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* renaming file in ScriptCanvas that causes a msbuild warning
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* reverting a previous change
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Added a codesigning script to pre and post build steps in the Windows installer CD job
* Changed `windows_installer` job name to `installer_vs2019`
* Added `installer-nightly` tag for `installer_vs2019`
* Updated `build_config.json` to use an envvar for the installer url and bucket
Signed-off-by: Mike Chang <changml@amazon.com>
This change is required to support spot instances in the AR pipeline.
- When a node goes offline the job is retried on a new node
- Valid script errors are handled properly and the status is updated in Jenkins
Signed-off-by: brianherrera <briher@amazon.com>
Make awsi_test_profile_vs2019 a nonblocking step to make sure that resources are cleaned up even though automation tests failed
Signed-off-by: Junbo Liang <junbo@amazon.com>
* add s3 upload on screenshot test failure, should only apply to the test_gpu_profile_vs2019 job on nightly runs
* adds support for zipping screenshot files up prior to uploading to the s3 bucket and also adds the ACL extra arg to the upload_to_s3.py execution
* remove unused json import
* remove regex to use .endswith() instead and rename variables to be more clear (PR feedback)
* rename create_zip_archive to create_screenshots_archive
Signed-off-by: jromnoa <jromnoa@amazon.com>
* - Add support for a custom path root separator using a trait.
- Ensure to set both FilePathKey_ProjectUserPath and FilePathKey_ProjectLogPath to a writeable storage location on non-host platforms.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Remove az_trait_validator.py, as our PAL guidance no longer dictates that all traits must be defined for all platforms.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Updated based on review feedback.
Signed-off-by: bosnichd <bosnichd@amazon.com>
* Send SNS topic on build failure
* send build failure root cause data to SNS topic that triggeres lambda function to automatically create Github issues
* Change SNS topic subject to Build failure and add build url to the message
* Change SNS topic name
These scripts will configure build and test Ubuntu 18/20 nodes with:
Nvidia gaming drivers for GPU instances (g4dn)
lightdm for Ubuntu 18 and gdm3 for Ubuntu 20 (wayland is disabled here, but should have xcb capabilities)
NiceDCV for remote console access
Note: Does not include user setup and firewall configurations
Signed-off-by: Mike Chang <changml@amazon.com>
* Fixed invalid variable access in register.py
The register_restricted_path and register_template_path methods did not specify the parameter for project path
Updated register_o3de_object_path function to pass in absolute paths to the engine or project in order to make relative paths to the registered o3de object to it.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Fixed register_*_path resolve calls in register.py
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Add linux equivalents for all the places that enumerate platforms
Signed-off-by: Chris Burel <burelc@amazon.com>
* Fix the AssetFileInfoListComparisonTest fixture to not hardcode the PC platform
Signed-off-by: Chris Burel <burelc@amazon.com>
Allow customized Jenkins parameters for different pipelines so that we can define different Jenkins parameters for a new pipeline and doesn't affect AR build parameters.
Add aws integration deployment pipeline.
* Revert to regular run when invalid commits used.
* Cirrect s3 logging of last commit hash storage
* Add s3 top level url and build number script params.
* Use existing REPOSITORY_NAME env var.
Signed-off-by: John <jonawals@amazon.com>
* Fix typo in MARS document key.
Signed-off-by: John <jonawals@amazon.com>
* Add diff support for commits on different branches.
Signed-off-by: John <jonawals@amazon.com>
* Restore archiving of historic data objects.
Signed-off-by: John <jonawals@amazon.com>
* Correctly handle commit diffs for PR builds.
Signed-off-by: John <jonawals@amazon.com>
* Comment out archiving of historic data objects.
Signed-off-by: John <jonawals@amazon.com>
* Fix python typo
Signed-off-by: John <jonawals@amazon.com>
* Remove comment pertaining to s3 bucket.
Signed-off-by: John <jonawals@amazon.com>
* Fix test selection efficiency for MARS.
Signed-off-by: John <jonawals@amazon.com>
* Define a new Jenkins job to deploy AWS resources
Signed-off-by: junbo <junbo@amazon.com>
* Address PR comments
Signed-off-by: junbo <junbo@amazon.com>
* Add error checking for all the calls
Signed-off-by: junbo <junbo@amazon.com>
* Remove the weekly-build-metrics tag
Signed-off-by: junbo <junbo@amazon.com>
* Parameterize ARN/Region and move it to a Jenkins envvar.
Signed-off-by: junbo <junbo@amazon.com>
* Revert the changes for build_config.json
Signed-off-by: junbo <junbo@amazon.com>
* Fix for PathLib unlink wrong version parameter.
* Fix dst target for TIAF.
* Remove TIAF historic data arhciving on s3 buckets
* Change permissions for TIAF bucket upload
Signed-off-by: John <jonawals@amazon.com>
* Added new feature to the register command to auto detect the correct
o3de manifest file to write to based on the supplied registration path
Updated the create-gem command to register the gem on creation.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Added new feature to the register command to auto detect the correct
o3de manifest file to write to based on the supplied registration path
Updated the create-gem command to register the gem on creation.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Fix incorrect variable reference in register_project_path
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Fixed o3de python package unit test
The enable_gem, register and engine template test have been updated to
account for the logic to register a gem after creation
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Added a --no-register arg to engine-template.py
This allows registration of gems/projects using the create-project and
create-gem commands to be skipped
Prevented registration of a gems and projects in the engine_template
command test
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Wrapped first parameter to find_ancestor_dir_containing_file with
pathlib.PurePath
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Previously the script was using the full local path as the artifact key when uploading to s3. This was causing the installer artifacts to be uploaded incorrectly and non-functional for normal use.
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
* Changed blue text to white that is not meant as a link, made 'View in Director' link work for gems in the inspector, added parsing for gem documentation link
Signed-off-by: nggieber <nggieber@amazon.com>
* Added documentation links for gems, changed markup for urls in summaries and requirements so they are clickable
Signed-off-by: nggieber <nggieber@amazon.com>
* Fixed a couple of the documentation links
Signed-off-by: nggieber <nggieber@amazon.com>
* Added documentation url to edit gem properties script and updated unit tests
Signed-off-by: nggieber <nggieber@amazon.com>
* Fixed the enable-gem command unit test
The enable-gem unit test would fail if there wasn't an
o3de_manifest.json file in the users $HOME/.o3de directory
The change now is to patch the call to load the o3de manifest
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Adjustments to the enable-gem command unit test to pass on Linux
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* The enable_gems command now registers the gem with the project if only registered with o3de_manifest.json
Updated the `enable_gems` command to register the gem with the project if the gem is not registered with either the project or the engine being used.
This allows the gem to be added to the build system if it wasn't registered before.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Adding quoting around the invocation of the OpenProjectManager command
The --project-path parameter now is able to pass in a path with spaces
to the invocation of the Project Manager.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated print_registration functions to fix "register-show" command
Added unit test to validate the argparse options to the register show
command.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated the register.py script to once again register an engine list
Previosly each engine were registered into a dictionary with multiple
keys, but once the engine.json started to self describe the registered
content that came with it, it was reduced to a single 'path' key.
Therefore it has been changed to a list to be consistent with other o3de
object paths
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated the SettingsRegistryMergeUtitls Code which parses the attempts to locate the engine path associated associated with the project.json engine key to check the 'engines_path' object within the o3de_manifest.json
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Updated print registration unit test to patch the get_project_path
This is to make sure that the existence of the placeholder project path
isn't validated when running the test
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Typo and formatting fixes for the print_registration script
Also corrected indentation in unit_test_print_registration script
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
The new commands are edit-engine-properties and edit-gem-properties
They can modify specific fields within these manifest files, that should
affect build system.
More importantly, this commands can be used to modify the "engine_name"
field in the engine.json and the "gem_name" field in the gem.json
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
* Some var cleanup so it shows better-organized in cmake-gui. Some vars were also not following the namign convention we are using
Removed some unnecessary messaging
Fixed a TIF bug where it would report the wrong test in a message, fixed a message that was being triggered
Changed TIF to be enabled just by the binary so running the ci_build scripts locally doesnt trigger TIF messaging
Removed `LY_ENABLE_MULTIPLAYER_COMPRESSION`, it was not being used
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* handling case where a parameter can be empty
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* needs to be var name, not contents
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
* Add script for license scanner
This script will scan the source tree for license files and generate a file with the contents of all the licenses.
Signed-off-by: brianherrera <briher@amazon.com>
Mike Balfour
lumberyard-employee-dm
Esteban Papp
Brian Herrera
Shirang Jia
Mike Chang
AMZN-Phil
Danilo Aimini
nggieber
AMZN-Phil
Alex Peterson
evanchia
AMZN-nggieber
Junbo Liang
Chris Galvan
jonawals
dialweb6
Mike Chang
scspaldi
Chris Burel
jromnoa
bosnichd
Sean Sweeney
hultonha
Scott Romero
amzn-sean