225d9d3b3c
Fixes to unit tests after merge
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-30 10:33:32 -07:00
d3bc7d8f12
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzToolsFramework/Tests/FocusMode/EditorFocusModeTests.cpp
# Code/Framework/AzToolsFramework/Tests/Prefab/PrefabFocus/PrefabFocusTests.cpp
2021-09-30 10:32:03 -07:00
8d67f184c8
LYN-7008 | Focus Mode - Selection unit tests ( #4357 )
...
* Refactor existing tests and fixtures, split them up in more granular tests, and add more comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Refactor test fixture for FocusMode to make it more reusable
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Fixture rename, draft of selection test
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Split SetFocus and ClearFocus tests for Editor Focus Mode
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Move BoundsTestComponent to its own file so that it can be reused in Focus Mode Selection tests
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Making progress on selection test. Test compiles now, but selection doesn't seem to be working.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Removed commented out code from previous iteration.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Move BoundsTestComponent under the UnitTest namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Viewport selection tests + minor fixes.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Minor fixes
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-30 18:05:50 +01:00
ffbc3f1c80
Fix a bug in recursion of prefab links when checking for dirty prefabs ( #4392 )
...
* Fix a bug in recursion of prefab links when checking for dirty prefabs
Signed-off-by: srikappa-amzn <srikappa@amazon.com >
* Added a missing EntityId header
Signed-off-by: srikappa-amzn <srikappa@amazon.com >
2021-09-30 10:26:11 -05:00
7b1d98535d
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
2021-09-30 08:16:11 -07:00
fa47b35580
Call sites for activating/deactivating viewport editor modes. ( #4265 )
...
* Provisional impl and testing of central state tracker.
Signed-off-by: John <jonawals@amazon.com >
* Add missing namespace comment.
Signed-off-by: John <jonawals@amazon.com >
* ViewportEditorModeState -> ViewportEditorModes
Signed-off-by: John <jonawals@amazon.com >
* ViewportEditorModesTracker -> ViewportEditorModeTracker
Signed-off-by: John <jonawals@amazon.com >
* GetEditorModeState ->GetViewportEditorModes
Signed-off-by: John <jonawals@amazon.com >
* GetNumTrackedViewports -> GetTrackedViewportCount
Signed-off-by: John <jonawals@amazon.com >
* IsViewportStateBeingTracked -> IsViewportModeTracked
Signed-off-by: John <jonawals@amazon.com >
* Fix API comments.
Signed-off-by: John <jonawals@amazon.com >
* Delete hangover file.
Signed-off-by: John <jonawals@amazon.com >
* Delete more hangover files.
Signed-off-by: John <jonawals@amazon.com >
* Minor member name refactor.
Signed-off-by: John <jonawals@amazon.com >
* Refactor nonclemanture.
Signed-off-by: John <jonawals@amazon.com >
* Rename Enter/ExitMode to Register/UnregisterMode.
Signed-off-by: John <jonawals@amazon.com >
* Error and warning msgs now return AZ::Outcomes.
Signed-off-by: John <jonawals@amazon.com >
* Change all nomenclature to Activate/Deactivate for consistency.
Signed-off-by: John <jonawals@amazon.com >
* Change tense of notification bus methods.
Signed-off-by: John <jonawals@amazon.com >
* Fix malformed string format.
Signed-off-by: John <jonawals@amazon.com >
* Fix malformed string format (again).
Signed-off-by: John <jonawals@amazon.com >
* Fix Linux warning.
Signed-off-by: John <jonawals@amazon.com >
* Call sites for editor mode activate/deactivate.
Signed-off-by: John <jonawals@amazon.com >
* Move Component editor mode logic to ComponentModeCollection.
Signed-off-by: John <jonawals@amazon.com >
* Delete non-source data.
Signed-off-by: John <jonawals@amazon.com >
* Remove line breaks and forward declare class.
Signed-off-by: John <jonawals@amazon.com >
* Remove constructors without ViewportEditorModeTrackerInterface ptr.
Signed-off-by: John <jonawals@amazon.com >
* Add integration tests for viewport editor modes.
Signed-off-by: John <jonawals@amazon.com >
* Address PR comments.
Signed-off-by: John <jonawals@amazon.com >
2021-09-30 15:36:42 +01:00
43748c37fd
update joints to use cluster viewport ui. ( #4352 )
...
also some joints Component mode cleanup.
Signed-off-by: amzn-sean <75276488+amzn-sean@users.noreply.github.com >
2021-09-30 13:39:22 +01:00
9eb9a13d99
Flipped CVar to activate the AssetBrowser Search View ( #4370 )
...
Signed-off-by: igarri <igarri@amazon.com >
2021-09-30 09:38:45 +01:00
742a84f587
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
2021-09-29 22:02:05 -07:00
27c7e2dcb0
Add correct include in FocusModeInterface to fix non-Unity builds.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-29 19:13:30 -07:00
ea3435a9bb
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
2021-09-29 19:03:57 -07:00
19bd934a43
Fix missing include for AZStd::unordered_set in AssetEditorBus.h
...
Signed-off-by: Steve Pham <spham@amazon.com >
2021-09-29 17:56:06 -07:00
090aa8f053
Removed ununeeded includes from EBus EBus.h and Policies.h ( #4256 )
...
* Removed ununeeded includes from EBus EBus.h and Policies.h
Updated the locations which needed those includes
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Adding missing include for <memory> to AWsClientAuthBus.h
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Remove the while true loop in the EBusQueuePolicy Execute() function
The while true loop in Execute was for allowing additional functions to be queued in the middle of execution of current list of functions.
That functionality was dangerous, because if a queued function added itself during execution unconditionally, then it would result in an infinite loop
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Updated the AssetManager::DispatchEvents function to pump the AssetBus event queue until empty
Queued Events on the AssetBus is able to queue additional events on that Bus during execution of those events.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Changed the AssetManager::DispatchEvents function to only execute the
AssetBus queued events once
Changed the AssetJobsFloodTest.AssetWithNoLoadReference_LoadDependencies_BehaviorObeyed test to dispatch events until the OnAssetContainerReady callback is signaled.
This happens after every asset load to make sure that the
expiring AssetContainer instances are removed from `AssetManager::m_ownedAssetContainer` container before retrying to load the same asset.
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Added a MaxTimeoutSeconds constant for the maximum amount of the time to run a single DispatchEvents loop
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-09-29 18:13:37 -05:00
816a623c97
Added missing EntityId.h include to FocusModeInterface.h ( #4396 )
...
* Added missing EntityId.h include to FocusModeInterface.h
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Non-unity build fix
Adding missing BehaviorContext.h includes to Multiplayer Gem
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Added missing BehaviorContext.h include to NetworkCharacterComponent
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-09-29 17:49:02 -05:00
a7f6bfbb50
Fix tests to work with new interface APIs using EditorEntityContextId
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-29 14:21:19 -07:00
3b9c3f832a
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
# Conflicts:
# Code/Editor/ViewportTitleDlg.cpp
2021-09-29 09:56:45 -07:00
f44169f7fa
Cleanup SerializeContext.h pt.1 ( #4264 )
...
* Remove AssetSerializer inclusion from SerializeContext header
Moved a few Reflect methods to new cpp files.
In addition, some preparations for further header dependency reductions.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Fix smoke test lua failures.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Windows build fixes.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Missing license headers
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Fix white-space issues.
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Code review fix for AzToolsFramework/AssetEditor/AssetEditorBus.h
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
* Fix inheritance list wrapping broken by older clang-format
Signed-off-by: nemerle <96597+nemerle@users.noreply.github.com >
Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-09-29 11:31:01 -05:00
b28f871b20
Fix casing of BreadCrumbs include in PrefabViewportFocusPathHandler.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 23:32:15 -07:00
9a325c657d
Add EntityContextId argument to focus interface functions that don't deal with entityIds.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 18:41:46 -07:00
c204aa1abe
Change notification buses to be addressed on EntityContextId, and connect the handlers to the default id. Request interfaces should not need that id as they can retrieve it from the entityId.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 18:16:02 -07:00
ce334f9443
Correctly set focused entity in case the root prefab instance is focused.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 17:48:36 -07:00
1f32076ca5
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
2021-09-28 15:55:39 -07:00
a692ae1567
Restore event listening behavior in EntityOutlinerListModel ( #4254 )
...
Disables a problematic child reparenting code path in EditorEntityModel that led to the series of remove -> add -> remove notifications for reparented entities that led to unnecessary updates and a sporadic QSortFilterProxyModel crash
Signed-off-by: nvsickle <nvsickle@amazon.com >
2021-09-28 14:57:09 -07:00
6f8afd69d4
Merge pull request #4372 from aws-lumberyard-dev/daimini/4364/restore-layout-fix
...
Editor crashes after changing the layout when the Prefab system is enabled
2021-09-28 14:20:37 -05:00
e958b0e09c
No longer can instantiate prefabs in an empty level ( #4277 )
...
* No longer can instantiate prefabs in an empty level
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* PR feedback from Ram
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* removing tab
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* PR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Implement Project Manager 'build' button for Mac and Linux(#4248 )
Signed-off-by: Steve Pham <spham@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove the PrefabEditManager. Introduce the FocusMode system on the Editor side, and a PrefabFocusHandler on the Prefab side to handle focus.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Changed FocusOnOwningPrefab to return Outcome. Added comments and error checking.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove assert for edge case that can actually happen in normal circumstances, simply return false in those cases.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove nested FocusModeFramework namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Minor fixes to variable names and comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* ClearFocusRoot implementation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove pragma once from cpp file
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix header formatting to pass validation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Do not assert if m_focusModeInterface can't be initialized
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Initialization changes to pass unit tests. Some interfaces are now retrieved on demand and there's clearer failure paths that don't involve asserts to better handle test/headless initializations.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS (#4268 )
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS
The issue was because the compression of ETC formats took too long.
Replaced all ETC and PVRTC formats with ASTC formats.
Update all pixel operation for formats with single R channel to align the change with R8.
Signed-off-by: Qing Tao <qingtao@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Use resize_no_construct when creating a buffer asset, since the initial data is going to be memcopy'd anyways. (#4249 )
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix a minor spelling mistake (#4247 )
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* 1. Update iOS deployment target to 14 (#4266 )
2. Set MacOS default deployment target to 11.
Signed-off-by: amzn-sj <srikkant@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Debug build clang fixes
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix failed 'server' platform assets on Linux related to Shaders (#4275 )
* Add missing 'server' platform identifier for the ShaderBuilder
* Use the current host platform as the fallback platform identifier (and not 'pc')
Signed-off-by: Steve Pham <spham@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* [development] Atom CPU profiler include cleanup (#4272 )
- Removed all unnecessary includes to Atom CpuProfiler.h
- Added includes to AzCore Profiler.h where necessary
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Add guard against edge case.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Expose Transform::CreateLookAt to behavior context to use with hydra tests
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Cached BLAS objects at the sub-mesh level
Signed-off-by: dmcdiar <dmcdiar@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* EMotion FX: Asset Processor generates an Actor for every FBX (#4284 )
Fixing the actor behavior to ignore actor asset generation for files that only contain nodes/bones. We're only checking for blend shapes and skins now. In case neither is present in an FBX, we don't export the actor asset.
This makes a plain skeleton a special case where users manually need to add the actor group for the fbx. The most common use case for these are animation files anyway, where we don't want to export actor assets.
Also increased the version number of the actor group so that they are all getting reprocessed and the unneeded actor assets get removed.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* EMotion FX: Crash in the actor builder when fbx meta data contains node groups (#4283 )
Fixing a crash related to the small array conversion that made multiple assets crash the actor builder.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Project Manager Gem Dependencies (#4132 )
* Fix engine API change and add gem dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Add GemCatalog dependency test
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Clarify display name and fix missing const
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Moving a couple helper functions into private scope
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Update gem count when unselecting a gem #4074
This addresses the following issue https://github.com/o3de/o3de/issues/4074
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Active/Inactive filter and dependency tooltips
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Accessors for previously added and dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Cart displays gem dependency changes
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Shorten titles to fit in summary popup
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove QString::number
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove extra space
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Consolidate source model accesor helpers
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Addressing minor feedback
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove unused local variable
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix AutoGen of RPCs with no params
Signed-off-by: puvvadar <puvvadar@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Adds Inspector to Gem Repo Screen (#4242 )
* Adds the gem repo screen with the UI built but with mocked data and not connected to the o3de scripts
Signed-off-by: nggieber <nggieber@amazon.com >
* Changed name of added to enabled, disabled define, removed unused functions
Signed-off-by: nggieber <nggieber@amazon.com >
* Added Repo Screen Inspector UI
Signed-off-by: nggieber <nggieber@amazon.com >
* Addressed minor PR feedback
Signed-off-by: nggieber <nggieber@amazon.com >
* Add some more minor PR changes
Signed-off-by: nggieber <nggieber@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Updated NetworkSpawnableHolderComponent to use TransformBus instead of FindComponent. Added dependency on TransformService
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fixed Entity::GetTransform to work for the components of an activating entity. Made the cached transform lazy evaluated.
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Changed NetworkSpawnableHolderComponent to use Entity::GetTransform instead of an ebus call
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Moved local variable to a smaller scope
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Signed-off-by: LesaelR <LesaelR@amazon.com > (#4278 )
* Signed-off-by: LesaelR <LesaelR@amazon.com >
* Removing the un-needed sandbox marks.
Signed-off-by: LesaelR <LesaelR@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Small fix for color node tooltip to ask for values 0-1 instead of 0-255
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Exposing NetworkCharacterComponent::TryMoveWithVelocity to script. Updating Multiplayer AutoComponent baseclass behavior context to Reflect itself instead of its derived (human made) component. This is so the derived class can also create behaviorcontext classes of its own if needed. Misc copyright header edit.
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Make sure Multiplayer AutoComponents dont generate property OnChange script events if GenerateEventBindings is disabled
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Adding parameter names to NetworkCharacterComponent script events so people know what the parameters are used for in scriptcanvas
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Small fix to use AZ_CRC_CE
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Disabling some tests when prefab mode is enabled
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "Disabling some tests when prefab mode is enabled"
This reverts commit 3fe9358d42ec9d7fa5ffaee458e4c6ca3ecbed6e.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "PR feedback"
This reverts commit a5b86d1954974b950b7719d1bc7dd56bc2a2a21b.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "removing tab"
This reverts commit ff6ef4bfb514d82a1b668baa95901ad363e648d0.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "PR feedback from Ram"
This reverts commit cba7f9c2a114d3bb51c9b64f38a7e1fef7bb8fe8.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Renaming level->rootInstance
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
Co-authored-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Co-authored-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com >
Co-authored-by: Tommy Walton <82672795+amzn-tommy@users.noreply.github.com >
Co-authored-by: SJ <srikkant@amazon.com >
Co-authored-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com >
Co-authored-by: Scott Romero <24445312+AMZN-ScottR@users.noreply.github.com >
Co-authored-by: amzn-tommy <waltont@amazon.com >
Co-authored-by: dmcdiar <dmcdiar@amazon.com >
Co-authored-by: Benjamin Jillich <43751992+amzn-jillich@users.noreply.github.com >
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
Co-authored-by: puvvadar <puvvadar@amazon.com >
Co-authored-by: AMZN-nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
Co-authored-by: pereslav <pereslav@amazon.com >
Co-authored-by: LesaelR <89800757+LesaelR@users.noreply.github.com >
Co-authored-by: Gene Walters <genewalt@amazon.com >
2021-09-28 12:07:56 -07:00
a641586df2
Move FocusModeInterface retrieval to EntityOutlinerListModel constructor to prevent crash on widget refresh. Also force expansion of root on construction for the same reason.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 10:02:47 -07:00
1f6dfd0194
Asset Browser Search View Column Resizing ( #4087 )
...
* Added resizing
Signed-off-by: igarri <igarri@amazon.com >
* Added Signals and Slots for resizing columns
Signed-off-by: igarri <igarri@amazon.com >
* Cleaned up code
Signed-off-by: igarri <igarri@amazon.com >
* Fixed Column Resize when docking
Signed-off-by: igarri <igarri@amazon.com >
* Added constants
Signed-off-by: igarri <igarri@amazon.com >
* Applied Code review feedback
Signed-off-by: igarri <igarri@amazon.com >
* aplied more feedback
Signed-off-by: igarri <igarri@amazon.com >
* Addressed Code Review Comments
Signed-off-by: igarri <igarri@amazon.com >
* Fixing bad merge
Signed-off-by: igarri <igarri@amazon.com >
* Added fix in initialization
Signed-off-by: igarri <igarri@amazon.com >
* Changed header setup sequence
Signed-off-by: igarri <igarri@amazon.com >
2021-09-28 12:47:21 +01:00
7da866e81a
Update to how entity space is treated in the viewport ( #4263 )
...
* first pass fixes for how entity space is handled in the viewport interaction model
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small updates to simplify space handling
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix for influence group with one entity selected
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some tidy-up and fix for scale manipulator snapping
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* couple of small fixes for scale manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small comment update
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fixes for integration test failures
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add test for rotation manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add test coverage for rotation manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add tests for translation manipulators and some other tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add tests for translating a group of entities
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add some tests for scale manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some updates and formatting changes (clang-format) to ViewportScreen
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* simplify usage of lround code
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update missed name updates
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update usage of WorldToScreenNdc
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some more small tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* move static variables to be marked inline
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small formatting fixes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-28 09:26:20 +01:00
8caf181db4
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzToolsFramework/AzToolsFramework/UI/Outliner/EntityOutlinerTreeView.cpp
2021-09-27 21:23:38 -07:00
527508ce66
Merge pull request #4270 from aws-lumberyard-dev/daimini/FocusMode/selection
...
LYN-5297 | Focus Mode - When a Prefab is selected other entities outside the Prefab hierarchy should not be selectable
2021-09-27 13:02:34 -05:00
8e92ed14df
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/selection
2021-09-27 09:29:49 -07:00
b9bd17f2ae
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/setup_tests
2021-09-27 08:39:36 -07:00
c75f3690da
Product/Source differentiation AssetBrowser Search View. ( #4144 )
...
* Added whole row highlight
Signed-off-by: igarri <igarri@amazon.com >
* Applied code review changes
Signed-off-by: igarri <igarri@amazon.com >
* Addressed code review comments
Signed-off-by: igarri <igarri@amazon.com >
* fixed QPointers
Signed-off-by: igarri <igarri@amazon.com >
* Added indentation to child items
Signed-off-by: igarri <igarri@amazon.com >
* Added Branch Icons
Signed-off-by: igarri <igarri@amazon.com >
* Loading icons and keeping a reference.
Signed-off-by: igarri <igarri@amazon.com >
* Fixed typos
Signed-off-by: igarri <igarri@amazon.com >
* Fixed TableView Header
Signed-off-by: igarri <igarri@amazon.com >
* Cleaned up Delegate Paint
Signed-off-by: igarri <igarri@amazon.com >
* Fixed view style
Signed-off-by: igarri <igarri@amazon.com >
* small tweaks
Signed-off-by: igarri <igarri@amazon.com >
* Added Assert
Signed-off-by: igarri <igarri@amazon.com >
* Small tweak in Table Model
Signed-off-by: igarri <igarri@amazon.com >
* Code Review Feedback
Signed-off-by: igarri <igarri@amazon.com >
* Code review Comments
Signed-off-by: igarri <igarri@amazon.com >
* Removed Comment
Signed-off-by: igarri <igarri@amazon.com >
2021-09-27 10:43:08 +01:00
f012407506
Addressed multiple minor CR comments.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 18:49:17 -07:00
ebb996d7f1
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs
2021-09-24 17:10:00 -07:00
f7e964c91d
Better replacement for EntityId checks
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 16:35:48 -07:00
80e6a6903a
Remove unused CreateEditorEntity function
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:55:02 -07:00
72110e40cf
Add Unit tests for EditorFocusMode and PrefabFocus. Minor change to PrefabFocusHandler to avoid instantiating a new AZ::EntityId() for checks.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:05:34 -07:00
03372d2ea9
Made IsInFocusSubTree const, and other minor refactorings.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-23 12:50:49 -07:00
23357b4c93
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/selection
2021-09-23 12:28:31 -07:00
d10cf1e495
Add guard against edge case.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-23 10:47:21 -07:00
3fdf1f052a
Minor comments and whitespace fixes.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 16:46:21 -07:00
be88be4bb8
Minor fixes to pass AR
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 16:12:11 -07:00
55e2684471
Refactor Prefab Focus function to move reused code to helper.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 15:02:58 -07:00
7a0be4ff65
Refresh delegate painting in the Outliner even if the widget is not in focus.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 15:01:49 -07:00
e2c4dbe277
Fix warning for numeric cast.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 15:01:47 -07:00
59d7cd6058
Enable back button and introduce behavior
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 15:01:45 -07:00
8ab409e4d2
Implemented the PrefabViewportFocusPathHandler class, added a breadcrumb widget to the viewport toolbar to display the currently focused prefab path.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 15:01:39 -07:00
1dd58511c1
Remove FocusModeFramework nested namespace
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 14:18:19 -07:00
368c325613
Disable selection of "out of focus" entities in both Outliner and Viewport. Refactor hover/selection rect painting for branches in the Outliner to fix disabled hover state.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 14:18:16 -07:00
Danilo Aimini
srikappa-amzn
jonawals
amzn-sean
AMZN-Igarri
Steve Pham
lumberyard-employee-dm
Artur K
Nicholas Van Sickle
Chris Galvan
Mikhail Naumov
hultonha