birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed unit tests from bool, int and double Json Serialization

Browse Source 
A future commit will include a generic test conformity test suite to replace these.
This commit is contained in:
AMZN-koppersr
2021-06-14 10:00:01 -07:00
parent 08abc497f3
commit fcd989c295
3 changed files with 1 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Framework/AzCore/Tests/Serialization/Json/BoolSerializerTests.cpp
-20
View File
@@ -260,24 +260,4 @@ namespace JsonSerializationTests
Load(m_jsonValue.SetDouble(-1.0f), true, AZ::JsonSerializationResult::Outcomes::Success);
Load(m_jsonValue.SetDouble(2.0), true, AZ::JsonSerializationResult::Outcomes::Success);
}
TEST_F(JsonBoolSerializerTests, Load_LoadDefaultToPointer_ValueIsIsInitialized)
{
using namespace AZ::JsonSerializationResult;
BoolPointerWrapper instance;
this->m_jsonDocument->Parse(R"({ "Value": {}})");
ASSERT_FALSE(this->m_jsonDocument->HasParseError());
AZ::JsonDeserializerSettings settings;
settings.m_serializeContext = this->m_jsonDeserializationContext->GetSerializeContext();
settings.m_registrationContext = this->m_jsonDeserializationContext->GetRegistrationContext();
ResultCode result = AZ::JsonSerialization::Load(instance, *this->m_jsonDocument, settings);
EXPECT_EQ(Outcomes::DefaultsUsed, result.GetOutcome());
EXPECT_EQ(Processing::Completed, result.GetProcessing());
ASSERT_NE(nullptr, instance.m_value);
EXPECT_FALSE(*instance.m_value);
}
} // namespace JsonSerializationTests
Code/Framework/AzCore/Tests/Serialization/Json/DoubleSerializerTests.cpp
+1 -29
View File
@@ -32,7 +32,7 @@ namespace JsonSerializationTests
AZStd::shared_ptr<FloatingPointType> CreateDefaultInstance() override
{
return AZStd::make_shared<FloatingPointType>(-2.0f);
return AZStd::make_shared<FloatingPointType>(0.0f);
}
AZStd::shared_ptr<FloatingPointType> CreateFullySetInstance() override
@@ -296,32 +296,4 @@ namespace JsonSerializationTests
EXPECT_EQ(Outcomes::Unsupported, result.GetOutcome());
EXPECT_EQ(42.0f, value);
}
// Pointers
TEST_F(JsonDoubleSerializerTests, Load_LoadDefaultToPointer_ValuesArIsInitialized)
{
using namespace AZ::JsonSerializationResult;
DoublePointerWrapper instance;
this->m_jsonDocument->Parse(R"(
{
"Double": {},
"Float": {}
})");
ASSERT_FALSE(this->m_jsonDocument->HasParseError());
AZ::JsonDeserializerSettings settings;
settings.m_serializeContext = this->m_jsonDeserializationContext->GetSerializeContext();
settings.m_registrationContext = this->m_jsonDeserializationContext->GetRegistrationContext();
ResultCode result = AZ::JsonSerialization::Load(instance, *this->m_jsonDocument, settings);
EXPECT_EQ(Outcomes::DefaultsUsed, result.GetOutcome());
EXPECT_EQ(Processing::Completed, result.GetProcessing());
ASSERT_NE(nullptr, instance.m_double);
ASSERT_NE(nullptr, instance.m_float);
EXPECT_DOUBLE_EQ(0.0, *instance.m_double);
EXPECT_FLOAT_EQ(0.0f, *instance.m_float);
}
} // namespace JsonSerializationTests
Code/Framework/AzCore/Tests/Serialization/Json/IntSerializerTests.cpp
-20
View File
@@ -505,26 +505,6 @@ namespace JsonSerializationTests
EXPECT_EQ(typename SerializerInfo<TypeParam>::DataType(), convertedValue);
}
TYPED_TEST(TypedJsonIntSerializerTests, Load_LoadDefaultToPointer_ValueIsIsInitialized)
{
using namespace AZ::JsonSerializationResult;
IntegerPointerWrapper instance;
this->m_jsonDocument->Parse(R"({ "Value": {}})");
ASSERT_FALSE(this->m_jsonDocument->HasParseError());
AZ::JsonDeserializerSettings settings;
settings.m_serializeContext = this->m_jsonDeserializationContext->GetSerializeContext();
settings.m_registrationContext = this->m_jsonDeserializationContext->GetRegistrationContext();
ResultCode result = AZ::JsonSerialization::Load(instance, *this->m_jsonDocument, settings);
EXPECT_EQ(Outcomes::DefaultsUsed, result.GetOutcome());
EXPECT_EQ(Processing::Completed, result.GetProcessing());
ASSERT_NE(nullptr, instance.m_value);
EXPECT_EQ(0, *instance.m_value);
}
TYPED_TEST(TypedJsonIntSerializerTests, Load_MaxInt8Value_ConvertIfFitsOrUnsupported) { this->template TestMaxValue<int8_t>(); }
TYPED_TEST(TypedJsonIntSerializerTests, Load_MaxShortValue_ConvertIfFitsOrUnsupported) { this->template TestMaxValue<short>(); }
TYPED_TEST(TypedJsonIntSerializerTests, Load_MaxIntValue_ConvertIfFitsOrUnsupported) { this->template TestMaxValue<int>(); }