birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor class definition updates for AWSGem (#7056)

Browse Source 
* Move the queued-events constructors for AWSApiClientJob and ServiceRequestJob from public to protected, and add short description for them

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
This commit is contained in:
Steve Pham
2022-01-21 09:19:54 -08:00
committed by GitHub
parent 807464c58d
commit edbebb5f47
2 changed files with 30 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/AWSCore/Code/Include/Framework/AWSApiRequestJob.h
+15 -22
View File
@@ -188,28 +188,6 @@ namespace AWSCore
{
}
AwsApiRequestJob(bool queueOnSuccess,
OnSuccessFunction onSuccess,
bool queueOnFailure,
OnFailureFunction onFailure,
bool queueDelete,
IConfig* config = GetDefaultConfig()
) : AwsApiClientJobType(false, config)
, m_queueOnSuccess{ queueOnSuccess }
, m_onSuccess{ onSuccess }
, m_queueOnFailure{ queueOnFailure }
, m_onFailure{ onFailure }
, m_queueDelete{ queueDelete }
{
}
AwsApiRequestJob(OnSuccessFunction onSuccess,
OnFailureFunction onFailure,
IConfig* config = GetDefaultConfig()
) : AwsApiRequestJob(true, onSuccess, true, onFailure, true, config)
{
}
RequestType request;
ResultType result;
ErrorType error;
@@ -232,6 +210,21 @@ namespace AWSCore
}
protected:
/// Constructor for creating AwsApiRequestJob Jobs that can handle queued responses
/// for OnSuccess, OnFailure, and DoCleanup
AwsApiRequestJob(OnSuccessFunction onSuccess,
OnFailureFunction onFailure,
IConfig* config = GetDefaultConfig()
) : AwsApiClientJobType(false, config)
, m_queueOnSuccess{ true }
, m_onSuccess{ onSuccess }
, m_queueOnFailure{ true }
, m_onFailure{ onFailure }
, m_queueDelete{ true }
{
}
bool m_wasSuccess{ false };
// Flag and optional function call to queue for onSuccess events
Gems/AWSCore/Code/Include/Framework/ServiceRequestJob.h
+15 -23
View File
@@ -178,29 +178,6 @@ namespace AWSCore
}
}
ServiceRequestJob(bool queueOnSuccess,
OnSuccessFunction onSuccess,
bool queueOnFailure,
OnFailureFunction onFailure,
bool queueDelete,
IConfig* config = GetDefaultConfig()
) : ServiceClientJobType{ false, config }
, m_requestUrl{ config->GetRequestUrl() }
, m_queueOnSuccess{ queueOnSuccess }
, m_onSuccess{ onSuccess }
, m_queueOnFailure{ queueOnFailure }
, m_onFailure{ onFailure }
, m_queueDelete{ queueDelete }
{
}
ServiceRequestJob(OnSuccessFunction onSuccess,
OnFailureFunction onFailure,
IConfig* config = GetDefaultConfig()
) : ServiceRequestJob(true, onSuccess, true, onFailure, true, config)
{
}
bool HasCredentials(IConfig* config)
{
if (config == nullptr)
@@ -241,6 +218,21 @@ namespace AWSCore
/// for replacing these parts of the url.
const Aws::String& m_requestUrl;
/// Constructor for creating ServiceRequestJob Jobs that can handle queued responses
/// for OnSuccess, OnFailure, and DoCleanup
ServiceRequestJob(OnSuccessFunction onSuccess,
OnFailureFunction onFailure,
IConfig* config = GetDefaultConfig()
) : ServiceClientJobType{ false, config }
, m_requestUrl{ config->GetRequestUrl() }
, m_queueOnSuccess{ true }
, m_onSuccess{ onSuccess }
, m_queueOnFailure{ true }
, m_onFailure{ onFailure }
, m_queueDelete{ true }
{
}
// Flag and optional function call to queue for onSuccess events
bool m_queueOnSuccess{ false };
OnSuccessFunction m_onSuccess{};