Addressing PR feedback

main
Benjamin Jillich 5 years ago
parent e6a8bf4689
commit e7e85f91d6

@ -92,7 +92,6 @@ namespace O3DE::ProjectManager
void CreateProjectCtrl::HandleNextButton() void CreateProjectCtrl::HandleNextButton()
{ {
ScreenWidget* currentScreen = reinterpret_cast<ScreenWidget*>(m_stack->currentWidget()); ScreenWidget* currentScreen = reinterpret_cast<ScreenWidget*>(m_stack->currentWidget());
const int currentScreenIndex = m_stack->currentIndex();
ProjectManagerScreen screenEnum = currentScreen->GetScreenEnum(); ProjectManagerScreen screenEnum = currentScreen->GetScreenEnum();
if (screenEnum == ProjectManagerScreen::NewProjectSettings) if (screenEnum == ProjectManagerScreen::NewProjectSettings)

@ -89,7 +89,7 @@ namespace O3DE::ProjectManager
}); });
} }
void GemCatalogScreen::FillModel(const QString& projectPath, [[maybe_unused]] bool isNewProject) void GemCatalogScreen::FillModel(const QString& projectPath, bool isNewProject)
{ {
AZ::Outcome<QVector<GemInfo>, AZStd::string> allGemInfosResult; AZ::Outcome<QVector<GemInfo>, AZStd::string> allGemInfosResult;
if (isNewProject) if (isNewProject)
@ -133,12 +133,12 @@ namespace O3DE::ProjectManager
} }
else else
{ {
QMessageBox::critical(nullptr, "Operation failed", QString("Cannot retrieve enabled gems for project %1.\n\nError:\n%2").arg(projectPath, enabledGemNamesResult.GetError().c_str())); QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve enabled gems for project %1.\n\nError:\n%2").arg(projectPath, enabledGemNamesResult.GetError().c_str()));
} }
} }
else else
{ {
QMessageBox::critical(nullptr, "Operation failed", QString("Cannot retrieve gems for %1.\n\nError:\n%2").arg(projectPath, allGemInfosResult.GetError().c_str())); QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve gems for %1.\n\nError:\n%2").arg(projectPath, allGemInfosResult.GetError().c_str()));
} }
} }

@ -321,13 +321,14 @@ namespace O3DE::ProjectManager
try try
{ {
executionCallback(); executionCallback();
return AZ::Success();
} }
catch ([[maybe_unused]] const std::exception& e) catch ([[maybe_unused]] const std::exception& e)
{ {
AZ_Warning("PythonBindings", false, "Python exception %s", e.what()); AZ_Warning("PythonBindings", false, "Python exception %s", e.what());
return AZ::Failure<AZStd::string>(e.what()); return AZ::Failure<AZStd::string>(e.what());
} }
return AZ::Success();
} }
bool PythonBindings::ExecuteWithLock(AZStd::function<void()> executionCallback) bool PythonBindings::ExecuteWithLock(AZStd::function<void()> executionCallback)

Loading…
Cancel
Save