birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Moves Culling.cpp::ProcessWorklist debug variables under preprocessing (#7043)

Browse Source 
Function Culling.cpp::ProcessWorklist has couple variable which are unsused when compiling profile causing
a -Werror compile error. Fixes is to move variables and code increment them under debugging ifdef.

Signed-off-by: Jackerty <contact.jackerty@gmail.com>
This commit is contained in:
Jackerty
2022-01-28 18:13:24 +02:00
committed by GitHub
parent ff79931d1d
commit e03d9eefd9
1 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/Atom/RPI/Code/Source/RPI.Public/Culling.cpp
+23 -6
View File
@@ -312,8 +312,11 @@ namespace AZ
const View::UsageFlags viewFlags = worklistData->m_view->GetUsageFlags();
const RHI::DrawListMask drawListMask = worklistData->m_view->GetDrawListMask();
[[maybe_unused]] uint32_t numDrawPackets = 0;
uint32_t numVisibleCullables = 0;
#ifdef AZ_CULL_DEBUG_ENABLED
// These variable are only used for the gathering of debug information.
uint32_t numDrawPackets = 0;
uint32_t numVisibleCullables = 0;
#endif
AZ_Assert(worklist.size() > 0, "Received empty worklist in ProcessWorklist");
@@ -351,8 +354,15 @@ namespace AZ
if (TestOcclusionCulling(worklistData, visibleEntry) == MaskedOcclusionCulling::CullingResult::VISIBLE)
#endif
{
numDrawPackets += AddLodDataToView(c->m_cullData.m_boundingSphere.GetCenter(), c->m_lodData, *worklistData->m_view);
++numVisibleCullables;
// There are ways to write this without [[maybe_unused]], but they are brittle.
// For example, using #else could cause a bug where the function's parameter
// is changed in #ifdef but not in #else.
[[maybe_unused]] const uint32_t drawPacketCount=AddLodDataToView(c->m_cullData.m_boundingSphere.GetCenter(), c->m_lodData, *worklistData->m_view);
#ifdef AZ_CULL_DEBUG_ENABLED
++numVisibleCullables;
numDrawPackets += drawPacketCount;
#endif
c->m_isVisible = true;
}
}
@@ -387,8 +397,15 @@ namespace AZ
if (TestOcclusionCulling(worklistData, visibleEntry) == MaskedOcclusionCulling::CullingResult::VISIBLE)
#endif
{
numDrawPackets += AddLodDataToView(c->m_cullData.m_boundingSphere.GetCenter(), c->m_lodData, *worklistData->m_view);
++numVisibleCullables;
// There are ways to write this without [[maybe_unused]], but they are brittle.
// For example, using #else could cause a bug where the function's parameter
// is changed in #ifdef but not in #else.
[[maybe_unused]] const uint32_t drawPacketCount=AddLodDataToView(c->m_cullData.m_boundingSphere.GetCenter(), c->m_lodData, *worklistData->m_view);
#ifdef AZ_CULL_DEBUG_ENABLED
++numVisibleCullables;
numDrawPackets += drawPacketCount;
#endif
c->m_isVisible = true;
}
}