Various bug fixes to get entity replication working

Gems/Multiplayer/Code/Source/ReplicationWindows/NullReplicationWindow.cpp

@@ -0,0 +1,47 @@
+/*
+* All or portions of this file Copyright (c) Amazon.com, Inc. or its affiliates or
+* its licensors.
+*
+* For complete copyright and license terms please see the LICENSE at the root of this
+* distribution (the "License"). All use of this software is governed by the License,
+* or, if provided, by the license below or the license accompanying this file. Do not
+* remove or modify any license notices. This file is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+*
+*/
+
+#include "NullReplicationWindow.h"
+
+namespace Multiplayer
+{
+    bool NullReplicationWindow::ReplicationSetUpdateReady()
+    {
+        return true;
+    }
+
+    const ReplicationSet& NullReplicationWindow::GetReplicationSet() const
+    {
+        return m_emptySet;
+    }
+
+    uint32_t NullReplicationWindow::GetMaxEntityReplicatorSendCount() const
+    {
+        return 0;
+    }
+
+    bool NullReplicationWindow::IsInWindow([[maybe_unused]] const ConstNetworkEntityHandle& entityHandle, NetEntityRole& outNetworkRole) const
+    {
+        outNetworkRole = NetEntityRole::InvalidRole;
+        return false;
+    }
+
+    void NullReplicationWindow::UpdateWindow()
+    {
+        ;
+    }
+
+    void NullReplicationWindow::DebugDraw() const
+    {
+        // Nothing to draw
+    }
+}

Gems/Multiplayer/Code/Source/ReplicationWindows/NullReplicationWindow.h

@@ -0,0 +1,38 @@
+/*
+* All or portions of this file Copyright (c) Amazon.com, Inc. or its affiliates or
+* its licensors.
+*
+* For complete copyright and license terms please see the LICENSE at the root of this
+* distribution (the "License"). All use of this software is governed by the License,
+* or, if provided, by the license below or the license accompanying this file. Do not
+* remove or modify any license notices. This file is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+*
+*/
+
+#pragma once
+
+#include <Source/ReplicationWindows/IReplicationWindow.h>
+
+namespace Multiplayer
+{
+    class NullReplicationWindow
+        : public IReplicationWindow
+    {
+    public:
+        NullReplicationWindow() = default;
+
+        //! IReplicationWindow interface
+        //! @{
+        bool ReplicationSetUpdateReady() override;
+        const ReplicationSet& GetReplicationSet() const override;
+        uint32_t GetMaxEntityReplicatorSendCount() const override;
+        bool IsInWindow(const ConstNetworkEntityHandle& entityPtr, NetEntityRole& outNetworkRole) const override;
+        void UpdateWindow() override;
+        void DebugDraw() const override;
+        //! @}
+
+    private:
+        ReplicationSet m_emptySet;
+    };
+}

Gems/Multiplayer/Code/Source/ReplicationWindows/ServerToClientReplicationWindow.cpp

@@ -202,8 +202,7 @@ namespace Multiplayer
 
     void ServerToClientReplicationWindow::OnEntityActivated(const AZ::EntityId& entityId)
     {
-        AZ::Entity* entity = nullptr;
-        EBUS_EVENT_RESULT(entity, AZ::ComponentApplicationBus, FindEntity, entityId);
+        AZ::Entity* entity = AZ::Interface<AZ::ComponentApplicationRequests>::Get()->FindEntity(entityId);
 
         ConstNetworkEntityHandle entityHandle(entity, GetNetworkEntityTracker());
         NetBindComponent* netBindComponent = entityHandle.GetNetBindComponent();
@@ -234,8 +233,7 @@ namespace Multiplayer
 
     void ServerToClientReplicationWindow::OnEntityDeactivated(const AZ::EntityId& entityId)
     {
-        AZ::Entity* entity = nullptr;
-        EBUS_EVENT_RESULT(entity, AZ::ComponentApplicationBus, FindEntity, entityId);
+        AZ::Entity* entity = AZ::Interface<AZ::ComponentApplicationRequests>::Get()->FindEntity(entityId);
 
         ConstNetworkEntityHandle entityHandle(entity, GetNetworkEntityTracker());
         NetBindComponent* netBindComponent = entityHandle.GetNetBindComponent();