Minor changes and comments after PR feedback

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
monroegm-disable-blank-issue-2
Guthrie Adams 4 years ago
parent 66be8543cd
commit ca0006f570

@ -165,6 +165,8 @@ namespace MaterialEditor
{ {
if (!AtomToolsDocument::Save()) if (!AtomToolsDocument::Save())
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }
@ -198,6 +200,8 @@ namespace MaterialEditor
{ {
if (!AtomToolsDocument::SaveAsCopy(savePath)) if (!AtomToolsDocument::SaveAsCopy(savePath))
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }
@ -228,6 +232,8 @@ namespace MaterialEditor
{ {
if (!AtomToolsDocument::SaveAsChild(savePath)) if (!AtomToolsDocument::SaveAsChild(savePath))
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }
@ -363,11 +369,18 @@ namespace MaterialEditor
return true; return true;
}); });
if (!addPropertiesResult || !AZ::RPI::JsonUtils::SaveObjectToFile(m_savePathNormalized, sourceData)) if (!addPropertiesResult)
{
AZ_Error("MaterialDocument", false, "Document properties could not be saved: '%s'.", m_savePathNormalized.c_str());
return false;
}
if (!AZ::RPI::JsonUtils::SaveObjectToFile(m_savePathNormalized, sourceData))
{ {
AZ_Error("MaterialDocument", false, "Document could not be saved: '%s'.", m_savePathNormalized.c_str()); AZ_Error("MaterialDocument", false, "Document could not be saved: '%s'.", m_savePathNormalized.c_str());
return false; return false;
} }
return true; return true;
} }

@ -107,6 +107,8 @@ namespace ShaderManagementConsole
{ {
if (!AtomToolsDocument::Save()) if (!AtomToolsDocument::Save())
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }
@ -117,6 +119,8 @@ namespace ShaderManagementConsole
{ {
if (!AtomToolsDocument::SaveAsCopy(savePath)) if (!AtomToolsDocument::SaveAsCopy(savePath))
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }
@ -127,6 +131,8 @@ namespace ShaderManagementConsole
{ {
if (!AtomToolsDocument::SaveAsChild(savePath)) if (!AtomToolsDocument::SaveAsChild(savePath))
{ {
// SaveFailed has already been called so just forward the result without additional notifications.
// TODO Replace bool return value with enum for open and save states.
return false; return false;
} }

Loading…
Cancel
Save