Avoid a somewhat costly call to ThumbnailerRequestsBus::IsLoading when the information is already manifest

This commit is contained in:
Yuriy Toporovskyy
2021-06-25 09:49:13 -04:00
parent 9216fc88c6
commit ad2ee47ea3
@@ -126,9 +126,9 @@ namespace AzToolsFramework
{
return 0;
}
bool thumbnailLoading;
ThumbnailerRequestsBus::BroadcastResult(thumbnailLoading, &ThumbnailerRequests::IsLoading, thumbnailKey, m_thumbnailContext.c_str());
if (thumbnailLoading)
const Thumbnail::State thumbnailState = thumbnail->GetState();
if (thumbnailState == Thumbnail::State::Loading)
{
AzQtComponents::StyledBusyLabel* busyLabel;
AssetBrowserComponentRequestBus::BroadcastResult(busyLabel , &AssetBrowserComponentRequests::GetStyledBusyLabel);
@@ -137,7 +137,7 @@ namespace AzToolsFramework
busyLabel->DrawTo(painter, QRectF(point.x(), point.y(), size.width(), size.height()));
}
}
else
else if (thumbnailState == Thumbnail::State::Ready)
{
// Scaling and centering pixmap within bounds to preserve aspect ratio
const QPixmap pixmap = thumbnail->GetPixmap().scaled(size, Qt::KeepAspectRatio, Qt::SmoothTransformation);
@@ -145,6 +145,10 @@ namespace AzToolsFramework
const QPoint pointDelta = QPoint(sizeDelta.width() / 2, sizeDelta.height() / 2);
painter->drawPixmap(point + pointDelta, pixmap);
}
else
{
AZ_Assert(false, "Thumbnail state %d unexpected here", int(thumbnailState));
}
return m_iconSize;
}