PR comments

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
Esteban Papp
2021-09-14 10:29:20 -07:00
parent ee2e728760
commit 988a6b7443
@@ -215,6 +215,7 @@ namespace AZStd
struct ErrorSink
{
virtual ~ErrorSink() = default;
virtual void RegexError(regex_constants::error_type code) = 0;
};
}
@@ -1079,7 +1080,7 @@ namespace AZStd
NodeBase* m_next;
NodeBase* m_previous;
virtual ~NodeBase() { }
virtual ~NodeBase() = default;
};
inline void DestroyNode(NodeBase* node, NodeBase* end = nullptr)
@@ -1758,7 +1759,7 @@ namespace AZStd
return (*this);
}
virtual ~basic_regex()
~basic_regex() override
{ // destroy the object
Clear();
}
@@ -2916,7 +2917,7 @@ namespace AZStd
}
template<class ForwardIterator, class Element, class RegExTraits>
inline NodeBase* Builder<ForwardIterator, Element, RegExTraits>::BeginGroup(void)
inline NodeBase* Builder<ForwardIterator, Element, RegExTraits>::BeginGroup()
{ // add group node
return (NewNode(NT_group));
}
@@ -3026,7 +3027,7 @@ namespace AZStd
}
template<class ForwardIterator, class Element, class RegExTraits>
inline RootNode* Builder<ForwardIterator, Element, RegExTraits>::EndPattern(void)
inline RootNode* Builder<ForwardIterator, Element, RegExTraits>::EndPattern()
{ // wrap up
NewNode(NT_end);
return m_root;