better organization of the warning

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
monroegm-disable-blank-issue-2
Esteban Papp 4 years ago
parent 9f6d4125b8
commit 8554cea0ad

@ -16,7 +16,13 @@ ly_append_configurations_options(
-Wall -Wall
-Werror -Werror
# Disabled warnings (please do not disable any others without first consulting ly-warnings) ###################
# Disabled warnings (please do not disable any others without first consulting sig-build)
###################
# -Wno-inconsistent-missing-override # unfortunately there is no warning in MSVC to detect missing overrides,
# MSVC's static analyzer can, but that is a different run that most developers are not ware of. A pass was
# done to fix all hits. Leaving this disabled until there is a matching warning in MSVC.
-Wrange-loop-analysis -Wrange-loop-analysis
-Wno-unknown-warning-option # used as a way to mark warnings that are MSVC only -Wno-unknown-warning-option # used as a way to mark warnings that are MSVC only
-Wno-parentheses -Wno-parentheses
@ -24,6 +30,10 @@ ly_append_configurations_options(
-Wno-switch -Wno-switch
-Wno-undefined-var-template -Wno-undefined-var-template
###################
# Enabled warnings (that are disabled by default)
###################
COMPILATION_DEBUG COMPILATION_DEBUG
-O0 # No optimization -O0 # No optimization
-g # debug symbols -g # debug symbols

@ -35,10 +35,14 @@ ly_append_configurations_options(
/WX # Warnings as errors /WX # Warnings as errors
/permissive- # Conformance with standard /permissive- # Conformance with standard
# Disabling some warnings ###################
# Disabled warnings (please do not disable any others without first consulting sig-build)
###################
/wd4201 # nonstandard extension used: nameless struct/union. This actually became part of the C++11 std, MS has an open issue: https://developercommunity.visualstudio.com/t/warning-level-4-generates-a-bogus-warning-c4201-no/103064 /wd4201 # nonstandard extension used: nameless struct/union. This actually became part of the C++11 std, MS has an open issue: https://developercommunity.visualstudio.com/t/warning-level-4-generates-a-bogus-warning-c4201-no/103064
# Enabling warnings that are disabled by default from /W4 ###################
# Enabled warnings (that are disabled by default from /W4)
###################
# https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=vs-2019 # https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=vs-2019
/we4263 # 'function': member function does not override any base class virtual member function /we4263 # 'function': member function does not override any base class virtual member function
/we4264 # 'virtual_function': no override available for virtual member function from base 'class'; function is hidden /we4264 # 'virtual_function': no override available for virtual member function from base 'class'; function is hidden
@ -54,7 +58,6 @@ ly_append_configurations_options(
/we5032 # detected #pragma warning(push) with no corresponding #pragma warning(pop) /we5032 # detected #pragma warning(push) with no corresponding #pragma warning(pop)
/we5233 # explicit lambda capture 'identifier' is not used /we5233 # explicit lambda capture 'identifier' is not used
/Zc:forScope # Force Conformance in for Loop Scope /Zc:forScope # Force Conformance in for Loop Scope
/diagnostics:caret # Compiler diagnostic options: includes the column where the issue was found and places a caret (^) under the location in the line of code where the issue was detected. /diagnostics:caret # Compiler diagnostic options: includes the column where the issue was found and places a caret (^) under the location in the line of code where the issue was detected.
/Zc:__cplusplus /Zc:__cplusplus

Loading…
Cancel
Save