birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename tests that reference issue numbers to have descriptive names (#913)

Browse Source 
This also enables one such test that was named after an issue tracker
id, that was disabled because of an already resolved issue.
This commit is contained in:
Chris Burel
2021-06-01 17:51:06 +00:00
committed by GitHub
parent 895bbafa9e
commit 71013c3835
7 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gems/EMotionFX/Code/Tests/AnimGraphParameterConditionTests.cpp
+8 -17
View File
@@ -10,6 +10,7 @@
*
*/
#include "EMotionFX/CommandSystem/Source/AnimGraphParameterCommands.h"
#include <AzCore/RTTI/TypeInfo.h>
#include <EMotionFX/CommandSystem/Source/CommandManager.h>
#include <EMotionFX/Source/AnimGraphBindPoseNode.h>
@@ -87,26 +88,16 @@ namespace EMotionFX
const AnimGraphParameterCondition* condition = GetAnimGraph()->GetParameterCondition();
EXPECT_EQ(condition->GetParameterType(), azrtti_typeid<EMotionFX::FloatSliderParameter>());
{
AZStd::string result;
EXPECT_TRUE(manager.ExecuteCommand("AnimGraphRemoveParameter -animGraphID 0 -name P0", result)) << result.c_str();
}
EXPECT_TRUE(CommandSystem::BuildRemoveParametersCommandGroup(GetAnimGraph(), {"P0"}));
EXPECT_EQ(condition->GetParameterType(), azrtti_typeid<EMotionFX::FloatSliderParameter>());
{
AZStd::string result;
EXPECT_TRUE(manager.ExecuteCommand("AnimGraphRemoveParameter -animGraphID 0 -name P1", result)) << result.c_str();
}
EXPECT_TRUE(CommandSystem::BuildRemoveParametersCommandGroup(GetAnimGraph(), {"P1"}));
EXPECT_EQ(condition->GetParameterType(), AZ::TypeId::CreateNull());
// Will be fixed by LY-109269
//{
// AZStd::string result;
// EXPECT_TRUE(manager.Undo(result)) << result.c_str();
//}
//EXPECT_EQ(condition->GetParameterType(), azrtti_typeid<EMotionFX::FloatSliderParameter>());
{
AZStd::string result;
EXPECT_TRUE(manager.Undo(result)) << result.c_str();
}
EXPECT_EQ(condition->GetParameterType(), azrtti_typeid<EMotionFX::FloatSliderParameter>());
}
} // namespace EMotionFX