address PR feedback

Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2022-02-01 16:08:10 -08:00
parent 42a812bb04
commit 5b9bc3b479
3 changed files with 8 additions and 5 deletions
@@ -180,7 +180,6 @@ PbrLightingOutput ForwardPassPS_Common(VSOutput IN, bool isFrontFace)
 }


-[earlydepthstencil]
 ForwardPassOutput BasePbr_ForwardPassPS_EDS(VSOutput IN, bool isFrontFace : SV_IsFrontFace)
 {
    ForwardPassOutput OUT;
@@ -8,6 +8,14 @@

 #pragma once

+// --- Note: About this file ---
+// This file uses #defines to completely strip out certain lighting features from shaders
+// This enables us to avoid code duplication and write an uber-esque shader code and then
+// be able to adjust the code for different use cases (for example basic materials can strip
+// away transimission related code used for foliage). These are different from shader options
+// in that shader options allow more user flexibility to adjust materials at runtime, whereas
+// these #define options are for customizing and optimizing material types (like BasePBR)
+
 // --- Light Defines ---

 #ifndef ENABLE_AREA_LIGHT_VALIDATION
@@ -20,10 +20,6 @@ class Surface
    ClearCoatSurfaceData clearCoat;
 #endif

-#if ENABLE_TRANSMISSION
-    TransmissionSurfaceData transmission; // This is not actually used for Standard PBR, but must be present for common lighting code to compile
-#endif
-
    // ------- BasePbrSurfaceData -------
    
    precise float3 position;    //!< Position in world-space