PR comments

Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com>
This commit is contained in:
Esteban Papp
2021-09-13 17:38:58 -07:00
parent 880e3c99be
commit 4db353eb22
4 changed files with 5 additions and 6 deletions
@@ -49,7 +49,6 @@ namespace AZ::Render
void SetShadowmapMaxResolution(ShadowId id, ShadowmapSize size) override;
void SetShadowBias(ShadowId id, float bias) override;
void SetPcfMethod(ShadowId id, PcfMethod method) override;
void SetEsmExponent(ShadowId id, float exponent);
void SetShadowFilterMethod(ShadowId id, ShadowFilterMethod method) override;
void SetSofteningBoundaryWidthAngle(ShadowId id, float boundaryWidthRadians) override;
void SetPredictionSampleCount(ShadowId id, uint16_t count) override;
@@ -57,6 +56,8 @@ namespace AZ::Render
void SetShadowProperties(ShadowId id, const ProjectedShadowDescriptor& descriptor) override;
const ProjectedShadowDescriptor& GetShadowProperties(ShadowId id) override;
void SetEsmExponent(ShadowId id, float exponent);
private:
// GPU data stored in m_projectedShadows.
@@ -53,7 +53,7 @@ namespace AZ
: public UnitTest::AssetTester<ImageMipChainAsset>
{
public:
ImageMipChainAssetTester() {}
ImageMipChainAssetTester() = default;
~ImageMipChainAssetTester() override = default;
void SetAssetReady(Data::Asset<ImageMipChainAsset>& asset) override
@@ -118,7 +118,7 @@ public:
IUiAnimStringTable* GetTrackEventStringTable() override { return m_pEventStrings.get(); }
//! Call to trigger a track event
void TriggerTrackEvent(const char* event, const char* param = NULL) override;
void TriggerTrackEvent(const char* event, const char* param = nullptr) override;
//! Track event listener
void AddTrackEventListener(IUiTrackEventListener* pListener) override;
@@ -130,7 +130,7 @@ private:
void ComputeTimeRange();
void CopyNodeChildren(XmlNodeRef& xmlNode, IUiAnimNode* pAnimNode);
void NotifyTrackEvent(IUiTrackEventListener::ETrackEventReason reason,
const char* event, const char* param = NULL);
const char* event, const char* param = nullptr);
// Create a new animation node.
IUiAnimNode* CreateNodeInternal(EUiAnimNodeType nodeType, uint32 nNodeId = -1);
@@ -183,7 +183,6 @@ namespace PhysX::Benchmarks
class PhysXJointBenchmarkFixture
: public PhysXBaseBenchmarkFixture
{
public:
void internalSetUp()
{
PhysXBaseBenchmarkFixture::SetUpInternal();
@@ -194,7 +193,6 @@ namespace PhysX::Benchmarks
PhysXBaseBenchmarkFixture::TearDownInternal();
}
protected:
public:
void SetUp(const benchmark::State&) override
{