Correct use of the `typename` keyword

Signed-off-by: Chris Burel <burelc@amazon.com>
monroegm-disable-blank-issue-2
Chris Burel 4 years ago
parent 24339e36ab
commit 20e268930c

@ -52,11 +52,11 @@ namespace TestImpact
// Wrappers around the AZ::IO::Path concatenation operator // Wrappers around the AZ::IO::Path concatenation operator
friend RepoPath operator/(const RepoPath& lhs, const AZ::IO::PathView& rhs); friend RepoPath operator/(const RepoPath& lhs, const AZ::IO::PathView& rhs);
friend RepoPath operator/(const RepoPath& lhs, AZStd::string_view rhs); friend RepoPath operator/(const RepoPath& lhs, AZStd::string_view rhs);
friend RepoPath operator/(const RepoPath& lhs, const typename value_type* rhs); friend RepoPath operator/(const RepoPath& lhs, const value_type* rhs);
friend RepoPath operator/(const RepoPath& lhs, const RepoPath& rhs); friend RepoPath operator/(const RepoPath& lhs, const RepoPath& rhs);
RepoPath& operator/=(const AZ::IO::PathView& rhs); RepoPath& operator/=(const AZ::IO::PathView& rhs);
RepoPath& operator/=(AZStd::string_view rhs); RepoPath& operator/=(AZStd::string_view rhs);
RepoPath& operator/=(const typename value_type* rhs); RepoPath& operator/=(const value_type* rhs);
RepoPath& operator/=(const RepoPath& rhs); RepoPath& operator/=(const RepoPath& rhs);
friend bool operator==(const RepoPath& lhs, const RepoPath& rhs) noexcept; friend bool operator==(const RepoPath& lhs, const RepoPath& rhs) noexcept;

@ -58,14 +58,14 @@ namespace TestImpact
//! @param payloadMapProducer The client callback to be called when all jobs have finished to transform the work produced by each job into the desired output. //! @param payloadMapProducer The client callback to be called when all jobs have finished to transform the work produced by each job into the desired output.
//! @param jobCallback The client callback to be called when each job changes state. //! @param jobCallback The client callback to be called when each job changes state.
//! @return The result of the run sequence and the jobs with their associated payloads. //! @return The result of the run sequence and the jobs with their associated payloads.
AZStd::pair<ProcessSchedulerResult, AZStd::vector<typename JobT>> Execute( AZStd::pair<ProcessSchedulerResult, AZStd::vector<JobT>> Execute(
const AZStd::vector<typename JobT::Info>& jobs, const AZStd::vector<typename JobT::Info>& jobs,
PayloadMapProducer<JobT> payloadMapProducer, PayloadMapProducer<JobT> payloadMapProducer,
StdOutputRouting stdOutRouting, StdOutputRouting stdOutRouting,
StdErrorRouting stdErrRouting, StdErrorRouting stdErrRouting,
AZStd::optional<AZStd::chrono::milliseconds> jobTimeout, AZStd::optional<AZStd::chrono::milliseconds> jobTimeout,
AZStd::optional<AZStd::chrono::milliseconds> runnerTimeout, AZStd::optional<AZStd::chrono::milliseconds> runnerTimeout,
JobCallback<typename JobT> jobCallback); JobCallback<JobT> jobCallback);
private: private:
ProcessScheduler m_processScheduler; ProcessScheduler m_processScheduler;
@ -82,17 +82,17 @@ namespace TestImpact
} }
template<typename JobT> template<typename JobT>
AZStd::pair<ProcessSchedulerResult, AZStd::vector<typename JobT>> JobRunner<JobT>::Execute( AZStd::pair<ProcessSchedulerResult, AZStd::vector<JobT>> JobRunner<JobT>::Execute(
const AZStd::vector<typename JobT::Info>& jobInfos, const AZStd::vector<typename JobT::Info>& jobInfos,
PayloadMapProducer<JobT> payloadMapProducer, PayloadMapProducer<JobT> payloadMapProducer,
StdOutputRouting stdOutRouting, StdOutputRouting stdOutRouting,
StdErrorRouting stdErrRouting, StdErrorRouting stdErrRouting,
AZStd::optional<AZStd::chrono::milliseconds> jobTimeout, AZStd::optional<AZStd::chrono::milliseconds> jobTimeout,
AZStd::optional<AZStd::chrono::milliseconds> runnerTimeout, AZStd::optional<AZStd::chrono::milliseconds> runnerTimeout,
JobCallback<typename JobT> jobCallback) JobCallback<JobT> jobCallback)
{ {
AZStd::vector<ProcessInfo> processes; AZStd::vector<ProcessInfo> processes;
AZStd::unordered_map<JobT::Info::IdType, AZStd::pair<JobMeta, const typename JobT::Info*>> metas; AZStd::unordered_map<typename JobT::Info::IdType, AZStd::pair<JobMeta, const typename JobT::Info*>> metas;
AZStd::vector<JobT> jobs; AZStd::vector<JobT> jobs;
jobs.reserve(jobInfos.size()); jobs.reserve(jobInfos.size());
processes.reserve(jobInfos.size()); processes.reserve(jobInfos.size());

@ -162,7 +162,7 @@ namespace TestImpact
{ {
} }
[[nodiscard]] ProcessCallbackResult operator()(const typename JobInfo& jobInfo, const TestImpact::JobMeta& meta) [[nodiscard]] ProcessCallbackResult operator()(const JobInfo& jobInfo, const TestImpact::JobMeta& meta)
{ {
const auto id = jobInfo.GetId().m_value; const auto id = jobInfo.GetId().m_value;
const auto& args = jobInfo.GetCommand().m_args; const auto& args = jobInfo.GetCommand().m_args;
@ -189,7 +189,7 @@ namespace TestImpact
private: private:
const AZStd::vector<const TestTarget*>& m_testTargets; const AZStd::vector<const TestTarget*>& m_testTargets;
TestEngineJobMap<typename IdType>* m_engineJobs; TestEngineJobMap<IdType>* m_engineJobs;
Policy::ExecutionFailure m_executionFailurePolicy; Policy::ExecutionFailure m_executionFailurePolicy;
Policy::TestFailure m_testFailurePolicy; Policy::TestFailure m_testFailurePolicy;
AZStd::optional<TestEngineJobCompleteCallback>* m_callback; AZStd::optional<TestEngineJobCompleteCallback>* m_callback;

@ -775,7 +775,7 @@ namespace TestImpact
serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::MaxConcurrency]].GetUint64(), serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::MaxConcurrency]].GetUint64(),
testTargetTimeout ? AZStd::optional<AZStd::chrono::milliseconds>{ testTargetTimeout } : AZStd::nullopt, testTargetTimeout ? AZStd::optional<AZStd::chrono::milliseconds>{ testTargetTimeout } : AZStd::nullopt,
globalTimeout ? AZStd::optional<AZStd::chrono::milliseconds>{ globalTimeout } : AZStd::nullopt, globalTimeout ? AZStd::optional<AZStd::chrono::milliseconds>{ globalTimeout } : AZStd::nullopt,
DeserializePolicyStateType<SequenceReportBaseType::PolicyState>(serialSequenceReportBase), DeserializePolicyStateType<typename SequenceReportBaseType::PolicyState>(serialSequenceReportBase),
SuiteTypeFromString(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::Suite]].GetString()), SuiteTypeFromString(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::Suite]].GetString()),
DeserializeTestSelection(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::SelectedTestRuns]]), DeserializeTestSelection(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::SelectedTestRuns]]),
DeserializeTestRunReport(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::SelectedTestRunReport]])); DeserializeTestRunReport(serialSequenceReportBase[SequenceReportFields::Keys[SequenceReportFields::SelectedTestRunReport]]));

Loading…
Cancel
Save