Undownloaded remote gems are shown in Gem Catalog and searchable by repo name

Signed-off-by: nggieber <nggieber@amazon.com>

Code/Tools/ProjectManager/Source/GemCatalog/GemCatalogScreen.cpp

@@ -106,6 +106,20 @@ namespace O3DE::ProjectManager
                 m_gemModel->AddGem(gemInfo);
             }
 
+            AZ::Outcome<QVector<GemInfo>, AZStd::string> allRepoGemInfosResult = PythonBindingsInterface::Get()->GetAllGemRepoGemsInfos();
+            if (allRepoGemInfosResult.IsSuccess())
+            {
+                const QVector<GemInfo> allRepoGemInfos = allRepoGemInfosResult.GetValue();
+                for (const GemInfo& gemInfo : allRepoGemInfos)
+                {
+                    m_gemModel->AddGem(gemInfo);
+                }
+            }
+            else
+            {
+                QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve gems from repos.<br><br>Error:<br>%1").arg(allRepoGemInfosResult.GetError().c_str()));
+            }
+
             m_gemModel->UpdateGemDependencies();
 
             // Gather enabled gems for the given project.
@@ -131,12 +145,12 @@ namespace O3DE::ProjectManager
             }
             else
             {
-                QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve enabled gems for project %1.\n\nError:\n%2").arg(projectPath, enabledGemNamesResult.GetError().c_str()));
+                QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve enabled gems for project %1.<br><br>Error:<br>%2").arg(projectPath, enabledGemNamesResult.GetError().c_str()));
             }
         }
         else
         {
-            QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve gems for %1.\n\nError:\n%2").arg(projectPath, allGemInfosResult.GetError().c_str()));
+            QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve gems for %1.<br><br>Error:<br>%2").arg(projectPath, allGemInfosResult.GetError().c_str()));
         }
     }
 

Code/Tools/ProjectManager/Source/PythonBindings.cpp

@@ -302,6 +302,7 @@ namespace O3DE::ProjectManager
             m_disableGemProject = pybind11::module::import("o3de.disable_gem");
             m_editProjectProperties = pybind11::module::import("o3de.project_properties");
             m_download = pybind11::module::import("o3de.download");
+            m_repo = pybind11::module::import("o3de.repo");
             m_pathlib = pybind11::module::import("pathlib");
 
             // make sure the engine is registered
@@ -645,13 +646,13 @@ namespace O3DE::ProjectManager
         }
     }
 
-    GemInfo PythonBindings::GemInfoFromPath(pybind11::handle path, pybind11::handle pyProjectPath)
+    GemInfo PythonBindings::GemInfoFromPath(pybind11::handle path, pybind11::handle pyProjectPath, bool fullPathGiven)
     {
         GemInfo gemInfo;
         gemInfo.m_path = Py_To_String(path);
         gemInfo.m_directoryLink = gemInfo.m_path;
 
-        auto data = m_manifest.attr("get_gem_json_data")(pybind11::none(), path, pyProjectPath);
+        auto data = m_manifest.attr("get_gem_json_data")(pybind11::none(), path, pyProjectPath, fullPathGiven);
         if (pybind11::isinstance<pybind11::dict>(data))
         {
             try
@@ -685,6 +686,10 @@ namespace O3DE::ProjectManager
                 {
                     gemInfo.m_downloadStatus = GemInfo::DownloadStatus::Downloaded;
                 }
+                if (fullPathGiven)
+                {
+                    gemInfo.m_downloadStatus = GemInfo::DownloadStatus::NotDownloaded;
+                }
 
                 if (data.contains("user_tags"))
                 {
@@ -1102,4 +1107,29 @@ namespace O3DE::ProjectManager
 
         return AZ::Success();
     }
+
+    AZ::Outcome<QVector<GemInfo>, AZStd::string> PythonBindings::GetAllGemRepoGemsInfos()
+    {
+        QVector<GemInfo> gemInfos;
+        AZ::Outcome<void, AZStd::string> result = ExecuteWithLockErrorHandling(
+            [&]
+            {
+                auto gemPaths = m_repo.attr("get_gem_json_paths_from_all_cached_repos")();
+
+                if (pybind11::isinstance<pybind11::set>(gemPaths))
+                {
+                    for (auto path : gemPaths)
+                    {
+                        gemInfos.push_back(GemInfoFromPath(path, pybind11::none(), true));
+                    }
+                }
+            });
+
+        if (!result.IsSuccess())
+        {
+            return AZ::Failure(result.GetError());
+        }
+
+        return AZ::Success(AZStd::move(gemInfos));
+    }
 }

Code/Tools/ProjectManager/Source/PythonBindings.h

@@ -62,13 +62,14 @@ namespace O3DE::ProjectManager
         bool RemoveGemRepo(const QString& repoUri) override;
         AZ::Outcome<QVector<GemRepoInfo>, AZStd::string> GetAllGemRepoInfos() override;
         AZ::Outcome<void, AZStd::string> DownloadGem(const QString& gemName, std::function<void(int)> gemProgressCallback) override;
+        AZ::Outcome<QVector<GemInfo>, AZStd::string> GetAllGemRepoGemsInfos() override;
 
     private:
         AZ_DISABLE_COPY_MOVE(PythonBindings);
 
         AZ::Outcome<void, AZStd::string> ExecuteWithLockErrorHandling(AZStd::function<void()> executionCallback);
         bool ExecuteWithLock(AZStd::function<void()> executionCallback);
-        GemInfo GemInfoFromPath(pybind11::handle path, pybind11::handle pyProjectPath);
+        GemInfo GemInfoFromPath(pybind11::handle path, pybind11::handle pyProjectPath, bool fullPathGiven = false);
         GemRepoInfo GetGemRepoInfo(pybind11::handle repoUri);
         ProjectInfo ProjectInfoFromPath(pybind11::handle path);
         ProjectTemplateInfo ProjectTemplateInfoFromPath(pybind11::handle path, pybind11::handle pyProjectPath);
@@ -89,6 +90,7 @@ namespace O3DE::ProjectManager
         pybind11::handle m_disableGemProject;
         pybind11::handle m_editProjectProperties;
         pybind11::handle m_download;
+        pybind11::handle m_repo;
         pybind11::handle m_pathlib;
     };
 }

Code/Tools/ProjectManager/Source/PythonBindingsInterface.h

@@ -189,6 +189,12 @@ namespace O3DE::ProjectManager
         virtual AZ::Outcome<QVector<GemRepoInfo>, AZStd::string> GetAllGemRepoInfos() = 0;
 
         virtual AZ::Outcome<void, AZStd::string> DownloadGem(const QString& gemName, std::function<void(int)> gemProgressCallback) = 0;
+
+        /**
+         * Gathers all gem infos for all gems registered from repos.
+         * @return A list of gem infos.
+         */
+        virtual AZ::Outcome<QVector<GemInfo>, AZStd::string> GetAllGemRepoGemsInfos() = 0;
     };
 
     using PythonBindingsInterface = AZ::Interface<IPythonBindings>;