birkeh/o3de
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address PR comments

Browse Source
This commit is contained in:
jonawals
2021-05-25 12:55:11 +01:00
parent bdbbedda71
commit 0ef519d11d
4 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Code/Tools/TestImpactFramework/Runtime/Code/Source/TestEngine/TestImpactTestEngine.h
+3 -3
View File
@@ -67,7 +67,7 @@ namespace TestImpact
//! @param globalTimeout The maximum duration the enumeration sequence may run before being forcefully terminated (infinite if empty).
//! @param callback The client callback function to handle completed test target enumerations.
//! @ returns The sequence result and the enumerations for the target that were enumerated.
AZStd::pair < TestSequenceResult, AZStd::vector<TestEngineEnumeration>> UpdateEnumerationCache(
AZStd::pair<TestSequenceResult, AZStd::vector<TestEngineEnumeration>> UpdateEnumerationCache(
const AZStd::vector<const TestTarget*>& testTargets,
Policy::ExecutionFailure executionFailurePolicy,
AZStd::optional<AZStd::chrono::milliseconds> testTargetTimeout,
@@ -84,7 +84,7 @@ namespace TestImpact
//! @param globalTimeout The maximum duration the enumeration sequence may run before being forcefully terminated (infinite if empty).
//! @param callback The client callback function to handle completed test target runs.
//! @ returns The sequence result and the test run results for the test targets that were run.
[[nodiscard]]AZStd::pair<TestSequenceResult, AZStd::vector<TestEngineRegularRun>> RegularRun(
[[nodiscard]] AZStd::pair<TestSequenceResult, AZStd::vector<TestEngineRegularRun>> RegularRun(
const AZStd::vector<const TestTarget*>& testTargets,
Policy::TestSharding testShardingPolicy,
Policy::ExecutionFailure executionFailurePolicy,
@@ -105,7 +105,7 @@ namespace TestImpact
//! @param globalTimeout The maximum duration the enumeration sequence may run before being forcefully terminated (infinite if empty).
//! @param callback The client callback function to handle completed test target runs.
//! @ returns The sequence result and the test run results and test coverages for the test targets that were run.
[[nodiscard]]AZStd::pair<TestSequenceResult, AZStd::vector<TestEngineInstrumentedRun>> InstrumentedRun(
[[nodiscard]] AZStd::pair<TestSequenceResult, AZStd::vector<TestEngineInstrumentedRun>> InstrumentedRun(
const AZStd::vector<const TestTarget*>& testTargets,
Policy::TestSharding testShardingPolicy,
Policy::ExecutionFailure executionFailurePolicy,
Code/Tools/TestImpactFramework/Runtime/Code/Source/TestEngine/TestImpactTestEngineInstrumentedRun.cpp
+4 -4
View File
@@ -18,7 +18,7 @@ namespace TestImpact
{
namespace
{
AZStd::optional<TestRun> ReleaseTestRun(AZStd::optional<AZStd::pair<TestRun, TestCoverage>>&& testRunAndCoverage)
AZStd::optional<TestRun> ReleaseTestRun(AZStd::optional<AZStd::pair<TestRun, TestCoverage>>& testRunAndCoverage)
{
if (testRunAndCoverage.has_value())
{
@@ -28,7 +28,7 @@ namespace TestImpact
return AZStd::nullopt;
}
AZStd::optional<TestCoverage> ReleaseTestCoverage(AZStd::optional<AZStd::pair<TestRun, TestCoverage>>&& testRunAndCoverage)
AZStd::optional<TestCoverage> ReleaseTestCoverage(AZStd::optional<AZStd::pair<TestRun, TestCoverage>>& testRunAndCoverage)
{
if (testRunAndCoverage.has_value())
{
@@ -40,8 +40,8 @@ namespace TestImpact
}
TestEngineInstrumentedRun::TestEngineInstrumentedRun(TestEngineJob&& testJob, AZStd::optional<AZStd::pair<TestRun, TestCoverage>>&& testRunAndCoverage)
: TestEngineRegularRun(AZStd::move(testJob), ReleaseTestRun(AZStd::move(testRunAndCoverage)))
, m_testCoverage(ReleaseTestCoverage(AZStd::move(testRunAndCoverage)))
: TestEngineRegularRun(AZStd::move(testJob), ReleaseTestRun(testRunAndCoverage))
, m_testCoverage(ReleaseTestCoverage(testRunAndCoverage))
{
}
Code/Tools/TestImpactFramework/Runtime/Code/Source/TestEngine/TestImpactTestEngineInstrumentedRun.h
+1
View File
@@ -26,6 +26,7 @@ namespace TestImpact
//! Returns the test coverage payload for this job (if any).
const AZStd::optional<TestCoverage>& GetTestCoverge() const;
private:
AZStd::optional<TestCoverage> m_testCoverage;
};
Code/Tools/TestImpactFramework/Runtime/Code/Source/TestEngine/TestImpactTestEngineJob.h
+1
View File
@@ -33,6 +33,7 @@ namespace TestImpact
//! Returns the command string that was used to execute this job.
const AZStd::string& GetCommandString() const;
private:
const TestTarget* m_testTarget;
AZStd::string m_commandString;