[atom_cpu_profiler_gem_promotion] more quick small changes based on PR feedback

Signed-off-by: AMZN-ScottR <24445312+AMZN-ScottR@users.noreply.github.com>

Gems/Profiler/Code/Include/Profiler/ProfilerImGuiBus.h

@@ -23,15 +23,5 @@ namespace Profiler
         virtual void ShowCpuProfilerWindow(bool& keepDrawing) = 0;
     };
 
-    class ProfilerImGuiBusTraits
-        : public AZ::EBusTraits
-    {
-    public:
-        // EBusTraits overrides
-        static constexpr AZ::EBusHandlerPolicy HandlerPolicy = AZ::EBusHandlerPolicy::Single;
-        static constexpr AZ::EBusAddressPolicy AddressPolicy = AZ::EBusAddressPolicy::Single;
-    };
-
     using ProfilerImGuiInterface = AZ::Interface<ProfilerImGuiRequests>;
-    using ProfilerImGuiRequestBus = AZ::EBus<ProfilerImGuiRequests, ProfilerImGuiBusTraits>;
 } // namespace Profiler

Gems/Profiler/Code/Source/ProfilerImGuiSystemComponent.cpp

@@ -76,7 +76,6 @@ namespace Profiler
     void ProfilerImGuiSystemComponent::Activate()
     {
 #if defined(IMGUI_ENABLED)
-        ProfilerImGuiRequestBus::Handler::BusConnect();
         ImGui::ImGuiUpdateListenerBus::Handler::BusConnect();
 #endif // defined(IMGUI_ENABLED)
     }
@@ -84,7 +83,6 @@ namespace Profiler
     void ProfilerImGuiSystemComponent::Deactivate()
     {
 #if defined(IMGUI_ENABLED)
-        ProfilerImGuiRequestBus::Handler::BusDisconnect();
         ImGui::ImGuiUpdateListenerBus::Handler::BusDisconnect();
 #endif // defined(IMGUI_ENABLED)
     }

Gems/Profiler/Code/Source/ProfilerImGuiSystemComponent.h

@@ -24,7 +24,7 @@ namespace Profiler
     class ProfilerImGuiSystemComponent
         : public AZ::Component
 #if defined(IMGUI_ENABLED)
-        , public ProfilerImGuiRequestBus::Handler
+        , public ProfilerImGuiRequests
         , public ImGui::ImGuiUpdateListenerBus::Handler
 #endif // defined(IMGUI_ENABLED)
     {
@@ -47,7 +47,7 @@ namespace Profiler
         void Deactivate() override;
 
 #if defined(IMGUI_ENABLED)
-        // ProfilerImGuiRequestBus interface implementation
+        // ProfilerImGuiRequests interface implementation
         void ShowCpuProfilerWindow(bool& keepDrawing) override;
 
         // ImGuiUpdateListenerBus overrides

Gems/Profiler/Code/Source/ProfilerSystemComponent.cpp

@@ -271,7 +271,6 @@ namespace Profiler
 
         // If the thread object already exists (ex. we have already serialized data), join. This will not block since
         // m_cpuDataSerializationInProgress was false, meaning the IO thread has already completed execution.
-        // TODO Use a reusable thread implementation over repeated creation + destruction of threads [ATOM-16214]
         if (m_cpuDataSerializationThread.joinable())
         {
             m_cpuDataSerializationThread.join();