Fix some sonar issues

master
Omertron 14 years ago
parent d8c81f9350
commit f69915b003

@ -33,8 +33,8 @@ import org.codehaus.jackson.map.ObjectMapper;
*/ */
public class TheMovieDB { public class TheMovieDB {
private static final Logger logger = Logger.getLogger(TheMovieDB.class); private static final Logger LOGGER = Logger.getLogger(TheMovieDB.class);
private static String API_KEY; private static String apiKey;
private static TmdbConfiguration tmdbConfig; private static TmdbConfiguration tmdbConfig;
/* /*
* TheMovieDB API URLs * TheMovieDB API URLs
@ -66,7 +66,7 @@ public class TheMovieDB {
private static ObjectMapper mapper = new ObjectMapper(); private static ObjectMapper mapper = new ObjectMapper();
public TheMovieDB(String apiKey) throws IOException { public TheMovieDB(String apiKey) throws IOException {
TheMovieDB.API_KEY = apiKey; TheMovieDB.apiKey = apiKey;
URL configUrl = TMDB_CONFIG_URL.getQueryUrl(""); URL configUrl = TMDB_CONFIG_URL.getQueryUrl("");
mapper.configure(DeserializationConfig.Feature.UNWRAP_ROOT_VALUE, true); mapper.configure(DeserializationConfig.Feature.UNWRAP_ROOT_VALUE, true);
tmdbConfig = mapper.readValue(configUrl, TmdbConfiguration.class); tmdbConfig = mapper.readValue(configUrl, TmdbConfiguration.class);
@ -75,7 +75,7 @@ public class TheMovieDB {
} }
public static String getApiKey() { public static String getApiKey() {
return API_KEY; return apiKey;
} }
public static String getApiBase() { public static String getApiBase() {
@ -94,7 +94,7 @@ public class TheMovieDB {
WrapperResultList resultList = mapper.readValue(url, WrapperResultList.class); WrapperResultList resultList = mapper.readValue(url, WrapperResultList.class);
return resultList.getResults(); return resultList.getResults();
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to find movie: " + ex.getMessage()); LOGGER.warn("Failed to find movie: " + ex.getMessage());
return new ArrayList<MovieDB>(); return new ArrayList<MovieDB>();
} }
} }
@ -109,10 +109,9 @@ public class TheMovieDB {
public MovieDB getMovieInfo(int movieId, String language) { public MovieDB getMovieInfo(int movieId, String language) {
try { try {
URL url = TMDB_MOVIE_INFO.getIdUrl(movieId, language); URL url = TMDB_MOVIE_INFO.getIdUrl(movieId, language);
MovieDB movieDb = mapper.readValue(url, MovieDB.class); return mapper.readValue(url, MovieDB.class);
return movieDb;
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie info: " + ex.getMessage()); LOGGER.warn("Failed to get movie info: " + ex.getMessage());
} }
return new MovieDB(); return new MovieDB();
} }
@ -129,7 +128,7 @@ public class TheMovieDB {
WrapperAlternativeTitles at = mapper.readValue(url, WrapperAlternativeTitles.class); WrapperAlternativeTitles at = mapper.readValue(url, WrapperAlternativeTitles.class);
return at.getTitles(); return at.getTitles();
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie alternative titles: " + ex.getMessage()); LOGGER.warn("Failed to get movie alternative titles: " + ex.getMessage());
} }
return new ArrayList<AlternativeTitle>(); return new ArrayList<AlternativeTitle>();
} }
@ -162,7 +161,7 @@ public class TheMovieDB {
return people; return people;
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie casts: " + ex.getMessage()); LOGGER.warn("Failed to get movie casts: " + ex.getMessage());
} }
return people; return people;
} }
@ -193,7 +192,7 @@ public class TheMovieDB {
return artwork; return artwork;
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie images: " + ex.getMessage()); LOGGER.warn("Failed to get movie images: " + ex.getMessage());
} }
return artwork; return artwork;
} }
@ -210,7 +209,7 @@ public class TheMovieDB {
WrapperMovieKeywords mk = mapper.readValue(url, WrapperMovieKeywords.class); WrapperMovieKeywords mk = mapper.readValue(url, WrapperMovieKeywords.class);
return mk.getKeywords(); return mk.getKeywords();
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie keywords: " + ex.getMessage()); LOGGER.warn("Failed to get movie keywords: " + ex.getMessage());
} }
return new ArrayList<Keyword>(); return new ArrayList<Keyword>();
} }
@ -227,7 +226,7 @@ public class TheMovieDB {
WrapperReleaseInfo ri = mapper.readValue(url, WrapperReleaseInfo.class); WrapperReleaseInfo ri = mapper.readValue(url, WrapperReleaseInfo.class);
return ri.getCountries(); return ri.getCountries();
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie release information: " + ex.getMessage()); LOGGER.warn("Failed to get movie release information: " + ex.getMessage());
} }
return new ArrayList<ReleaseInfo>(); return new ArrayList<ReleaseInfo>();
} }
@ -258,7 +257,7 @@ public class TheMovieDB {
} }
return trailers; return trailers;
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie trailers: " + ex.getMessage()); LOGGER.warn("Failed to get movie trailers: " + ex.getMessage());
} }
return trailers; return trailers;
} }
@ -274,7 +273,7 @@ public class TheMovieDB {
WrapperTranslations wt = mapper.readValue(url, WrapperTranslations.class); WrapperTranslations wt = mapper.readValue(url, WrapperTranslations.class);
return wt.getTranslations(); return wt.getTranslations();
} catch (IOException ex) { } catch (IOException ex) {
logger.warn("Failed to get movie tranlations: " + ex.getMessage()); LOGGER.warn("Failed to get movie tranlations: " + ex.getMessage());
} }
return new ArrayList<Translation>(); return new ArrayList<Translation>();
} }
@ -289,8 +288,7 @@ public class TheMovieDB {
public CollectionInfo getCollectionInfo(int movieId, String language) { public CollectionInfo getCollectionInfo(int movieId, String language) {
try { try {
URL url = TMDB_COLLECTION_INFO.getIdUrl(movieId); URL url = TMDB_COLLECTION_INFO.getIdUrl(movieId);
CollectionInfo col = mapper.readValue(url, CollectionInfo.class); return mapper.readValue(url, CollectionInfo.class);
return col;
} catch (IOException ex) { } catch (IOException ex) {
return new CollectionInfo(); return new CollectionInfo();
} }
@ -317,7 +315,7 @@ public class TheMovieDB {
if (!tmdbConfig.isValidSize(requiredSize)) { if (!tmdbConfig.isValidSize(requiredSize)) {
sb = new StringBuilder(); sb = new StringBuilder();
sb.append(" - Invalid size requested: ").append(requiredSize); sb.append(" - Invalid size requested: ").append(requiredSize);
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
return returnUrl; return returnUrl;
} }
@ -327,7 +325,7 @@ public class TheMovieDB {
sb.append(imagePath); sb.append(imagePath);
returnUrl = new URL(sb.toString()); returnUrl = new URL(sb.toString());
} catch (MalformedURLException ex) { } catch (MalformedURLException ex) {
logger.warn("Failed to create image URL: " + ex.getMessage()); LOGGER.warn("Failed to create image URL: " + ex.getMessage());
} }
return returnUrl; return returnUrl;

@ -25,7 +25,7 @@ public class AlternativeTitle {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(AlternativeTitle.class); private static final Logger LOGGER = Logger.getLogger(AlternativeTitle.class);
/* /*
* Properties * Properties
*/ */
@ -64,7 +64,7 @@ public class AlternativeTitle {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,7 +25,7 @@ public class Artwork {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Artwork.class); private static final Logger LOGGER = Logger.getLogger(Artwork.class);
/* /*
* Properties * Properties
*/ */
@ -123,7 +123,7 @@ public class Artwork {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -28,7 +28,7 @@ public class Collection {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Collection.class); private static final Logger LOGGER = Logger.getLogger(Collection.class);
/* /*
* Properties * Properties
*/ */
@ -113,7 +113,7 @@ public class Collection {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class CollectionInfo {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(CollectionInfo.class); private static final Logger LOGGER = Logger.getLogger(CollectionInfo.class);
/* /*
* Properties * Properties
*/ */
@ -96,7 +96,7 @@ public class CollectionInfo {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class Genre {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Genre.class); private static final Logger LOGGER = Logger.getLogger(Genre.class);
/* /*
* Properties * Properties
*/ */
@ -66,7 +66,7 @@ public class Genre {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class Keyword {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Keyword.class); private static final Logger LOGGER = Logger.getLogger(Keyword.class);
/* /*
* Properties * Properties
*/ */
@ -66,7 +66,7 @@ public class Keyword {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class Language {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Language.class); private static final Logger LOGGER = Logger.getLogger(Language.class);
/* /*
* Properties * Properties
*/ */
@ -66,7 +66,7 @@ public class Language {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -26,7 +26,7 @@ public class MovieDB {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(MovieDB.class); private static final Logger LOGGER = Logger.getLogger(MovieDB.class);
/* /*
* Properties * Properties
*/ */
@ -265,7 +265,7 @@ public class MovieDB {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
//<editor-fold defaultstate="collapsed" desc="Equals and HashCode"> //<editor-fold defaultstate="collapsed" desc="Equals and HashCode">

@ -24,7 +24,7 @@ public class Person {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Person.class); private static final Logger LOGGER = Logger.getLogger(Person.class);
/* /*
* Static fields for default cast information * Static fields for default cast information
@ -164,7 +164,7 @@ public class Person {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,7 +25,7 @@ public class PersonCast {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(PersonCast.class); private static final Logger LOGGER = Logger.getLogger(PersonCast.class);
/* /*
* Properties * Properties
*/ */
@ -94,7 +94,7 @@ public class PersonCast {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,7 +25,7 @@ public class PersonCrew {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(PersonCrew.class); private static final Logger LOGGER = Logger.getLogger(PersonCrew.class);
/* /*
* Properties * Properties
*/ */
@ -94,7 +94,7 @@ public class PersonCrew {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class ProductionCompany {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(ProductionCompany.class); private static final Logger LOGGER = Logger.getLogger(ProductionCompany.class);
/* /*
* Properties * Properties
*/ */
@ -66,7 +66,7 @@ public class ProductionCompany {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class ProductionCountry {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(ProductionCountry.class); private static final Logger LOGGER = Logger.getLogger(ProductionCountry.class);
/* /*
* Properties * Properties
*/ */
@ -66,7 +66,7 @@ public class ProductionCountry {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,7 +25,7 @@ public class ReleaseInfo {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(ReleaseInfo.class); private static final Logger LOGGER = Logger.getLogger(ReleaseInfo.class);
/* /*
* Properties * Properties
*/ */
@ -74,7 +74,7 @@ public class ReleaseInfo {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,14 +25,14 @@ public class StatusCode {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(StatusCode.class); private static final Logger LOGGER = Logger.getLogger(StatusCode.class);
/* /*
* Properties * Properties
*/ */
@JsonProperty("status_code") @JsonProperty("status_code")
int statusCode; private int statusCode;
@JsonProperty("status_message") @JsonProperty("status_message")
String statusMessage; private String statusMessage;
//<editor-fold defaultstate="collapsed" desc="Getter methods"> //<editor-fold defaultstate="collapsed" desc="Getter methods">
public int getStatusCode() { public int getStatusCode() {
@ -64,7 +64,7 @@ public class StatusCode {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -28,7 +28,7 @@ public class TmdbConfiguration {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(TmdbConfiguration.class); private static final Logger LOGGER = Logger.getLogger(TmdbConfiguration.class);
/* /*
* Properties * Properties
*/ */
@ -134,7 +134,7 @@ public class TmdbConfiguration {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -24,7 +24,7 @@ public class Trailer {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Trailer.class); private static final Logger LOGGER = Logger.getLogger(Trailer.class);
/* /*
* Website sources * Website sources
*/ */
@ -84,7 +84,7 @@ public class Trailer {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -25,7 +25,7 @@ public class Translation {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(Translation.class); private static final Logger LOGGER = Logger.getLogger(Translation.class);
/* /*
* Properties * Properties
*/ */
@ -74,7 +74,7 @@ public class Translation {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -30,7 +30,7 @@ public class ApiUrl {
/* /*
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(ApiUrl.class); private static final Logger LOGGER = Logger.getLogger(ApiUrl.class);
/* /*
* Parameter configuration * Parameter configuration
*/ */
@ -131,10 +131,10 @@ public class ApiUrl {
} }
try { try {
logger.trace("URL: " + urlString.toString()); LOGGER.trace("URL: " + urlString.toString());
return new URL(urlString.toString()); return new URL(urlString.toString());
} catch (MalformedURLException ex) { } catch (MalformedURLException ex) {
logger.warn("Failed to create URL " + urlString.toString()); LOGGER.warn("Failed to create URL " + urlString.toString());
return null; return null;
} }
} }

@ -24,10 +24,10 @@ import org.apache.log4j.spi.LoggingEvent;
* *
*/ */
public class FilteringLayout extends PatternLayout { public class FilteringLayout extends PatternLayout {
private static Pattern API_KEYS = Pattern.compile("DO_NOT_MATCH"); private static Pattern apiKeys = Pattern.compile("DO_NOT_MATCH");
public static void addApiKey(String apiKey) { public static void addApiKey(String apiKey) {
API_KEYS = Pattern.compile(apiKey); apiKeys = Pattern.compile(apiKey);
} }
/** /**
@ -40,7 +40,7 @@ public class FilteringLayout extends PatternLayout {
if (event.getMessage() instanceof String) { if (event.getMessage() instanceof String) {
String message = event.getRenderedMessage(); String message = event.getRenderedMessage();
Matcher matcher = API_KEYS.matcher(message); Matcher matcher = apiKeys.matcher(message);
if (matcher.find()) { if (matcher.find()) {
String maskedMessage = matcher.replaceAll("[APIKEY]"); String maskedMessage = matcher.replaceAll("[APIKEY]");

@ -27,7 +27,7 @@ public class WrapperAlternativeTitles {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperAlternativeTitles.class); private static final Logger LOGGER = Logger.getLogger(WrapperAlternativeTitles.class);
/* /*
* Properties * Properties
*/ */
@ -62,6 +62,6 @@ public class WrapperAlternativeTitles {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -28,7 +28,7 @@ public class WrapperMovieCasts {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperMovieCasts.class); private static final Logger LOGGER = Logger.getLogger(WrapperMovieCasts.class);
/* /*
* Properties * Properties
*/ */
@ -77,6 +77,6 @@ public class WrapperMovieCasts {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -27,7 +27,7 @@ public class WrapperMovieImages {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperMovieImages.class); private static final Logger LOGGER = Logger.getLogger(WrapperMovieImages.class);
/* /*
* Properties * Properties
*/ */
@ -76,6 +76,6 @@ public class WrapperMovieImages {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -27,7 +27,7 @@ public class WrapperMovieKeywords {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperMovieKeywords.class); private static final Logger LOGGER = Logger.getLogger(WrapperMovieKeywords.class);
/* /*
* Properties * Properties
*/ */
@ -66,6 +66,6 @@ public class WrapperMovieKeywords {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -27,7 +27,7 @@ public class WrapperReleaseInfo {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperReleaseInfo.class); private static final Logger LOGGER = Logger.getLogger(WrapperReleaseInfo.class);
/* /*
* Properties * Properties
*/ */
@ -66,6 +66,6 @@ public class WrapperReleaseInfo {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -27,18 +27,18 @@ public class WrapperResultList {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperResultList.class); private static final Logger LOGGER = Logger.getLogger(WrapperResultList.class);
/* /*
* Properties * Properties
*/ */
@JsonProperty("page") @JsonProperty("page")
int page; private int page;
@JsonProperty("results") @JsonProperty("results")
List<MovieDB> results; private List<MovieDB> results;
@JsonProperty("total_pages") @JsonProperty("total_pages")
int totalPages; private int totalPages;
@JsonProperty("total_results") @JsonProperty("total_results")
int totalResults; private int totalResults;
//<editor-fold defaultstate="collapsed" desc="Getter methods"> //<editor-fold defaultstate="collapsed" desc="Getter methods">
public int getPage() { public int getPage() {
@ -75,6 +75,7 @@ public class WrapperResultList {
this.totalResults = totalResults; this.totalResults = totalResults;
} }
//</editor-fold> //</editor-fold>
/** /**
* Handle unknown properties and print a message * Handle unknown properties and print a message
* @param key * @param key
@ -85,7 +86,7 @@ public class WrapperResultList {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
@Override @Override

@ -27,7 +27,7 @@ public class WrapperTrailers {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperTrailers.class); private static final Logger LOGGER = Logger.getLogger(WrapperTrailers.class);
/* /*
* Properties * Properties
*/ */
@ -76,6 +76,6 @@ public class WrapperTrailers {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -26,7 +26,7 @@ public class WrapperTranslations {
* Logger * Logger
*/ */
private static final Logger logger = Logger.getLogger(WrapperTranslations.class); private static final Logger LOGGER = Logger.getLogger(WrapperTranslations.class);
/* /*
* Properties * Properties
*/ */
@ -63,6 +63,6 @@ public class WrapperTranslations {
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
sb.append("Unknown property: '").append(key); sb.append("Unknown property: '").append(key);
sb.append("' value: '").append(value).append("'"); sb.append("' value: '").append(value).append("'");
logger.warn(sb.toString()); LOGGER.warn(sb.toString());
} }
} }

@ -28,7 +28,7 @@ import org.junit.*;
*/ */
public class TheMovieDBTest { public class TheMovieDBTest {
private static final Logger logger = Logger.getLogger(TheMovieDBTest.class); private static final Logger LOGGER = Logger.getLogger(TheMovieDBTest.class);
private static final String API_KEY = "5a1a77e2eba8984804586122754f969f"; private static final String API_KEY = "5a1a77e2eba8984804586122754f969f";
private static TheMovieDB tmdb; private static TheMovieDB tmdb;
/* /*
@ -62,7 +62,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testConfiguration() throws IOException { public void testConfiguration() throws IOException {
logger.info("Test Configuration"); LOGGER.info("Test Configuration");
TmdbConfiguration tmdbConfig = tmdb.getConfiguration(); TmdbConfiguration tmdbConfig = tmdb.getConfiguration();
assertNotNull("Configuration failed", tmdbConfig); assertNotNull("Configuration failed", tmdbConfig);
@ -70,7 +70,7 @@ public class TheMovieDBTest {
assertTrue("No backdrop sizes", tmdbConfig.getBackdropSizes().size() > 0); assertTrue("No backdrop sizes", tmdbConfig.getBackdropSizes().size() > 0);
assertTrue("No poster sizes", tmdbConfig.getPosterSizes().size() > 0); assertTrue("No poster sizes", tmdbConfig.getPosterSizes().size() > 0);
assertTrue("No profile sizes", tmdbConfig.getProfileSizes().size() > 0); assertTrue("No profile sizes", tmdbConfig.getProfileSizes().size() > 0);
logger.info(tmdbConfig.toString()); LOGGER.info(tmdbConfig.toString());
} }
/** /**
@ -78,7 +78,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testSearchMovie() throws UnsupportedEncodingException { public void testSearchMovie() throws UnsupportedEncodingException {
logger.info("searchMovie"); LOGGER.info("searchMovie");
// Try a movie with less than 1 page of results // Try a movie with less than 1 page of results
List<MovieDB> movieList = tmdb.searchMovie("Blade Runner", "", true); List<MovieDB> movieList = tmdb.searchMovie("Blade Runner", "", true);
@ -98,7 +98,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieInfo() { public void testGetMovieInfo() {
logger.info("getMovieInfo"); LOGGER.info("getMovieInfo");
String language = "en"; String language = "en";
MovieDB result = tmdb.getMovieInfo(ID_BLADE_RUNNER, language); MovieDB result = tmdb.getMovieInfo(ID_BLADE_RUNNER, language);
assertEquals("Incorrect movie information", "Blade Runner", result.getOriginalTitle()); assertEquals("Incorrect movie information", "Blade Runner", result.getOriginalTitle());
@ -109,7 +109,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieAlternativeTitles() { public void testGetMovieAlternativeTitles() {
logger.info("getMovieAlternativeTitles"); LOGGER.info("getMovieAlternativeTitles");
String country = ""; String country = "";
List<AlternativeTitle> results = tmdb.getMovieAlternativeTitles(ID_BLADE_RUNNER, country); List<AlternativeTitle> results = tmdb.getMovieAlternativeTitles(ID_BLADE_RUNNER, country);
assertTrue("No alternative titles found", results.size() > 0); assertTrue("No alternative titles found", results.size() > 0);
@ -125,7 +125,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieCasts() { public void testGetMovieCasts() {
logger.info("getMovieCasts"); LOGGER.info("getMovieCasts");
List<Person> people = tmdb.getMovieCasts(ID_BLADE_RUNNER); List<Person> people = tmdb.getMovieCasts(ID_BLADE_RUNNER);
assertTrue("No cast information", people.size() > 0); assertTrue("No cast information", people.size() > 0);
@ -153,7 +153,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieImages() { public void testGetMovieImages() {
logger.info("getMovieImages"); LOGGER.info("getMovieImages");
String language = ""; String language = "";
List<Artwork> result = tmdb.getMovieImages(ID_BLADE_RUNNER, language); List<Artwork> result = tmdb.getMovieImages(ID_BLADE_RUNNER, language);
assertFalse("No artwork found", result.isEmpty()); assertFalse("No artwork found", result.isEmpty());
@ -164,7 +164,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieKeywords() { public void testGetMovieKeywords() {
logger.info("getMovieKeywords"); LOGGER.info("getMovieKeywords");
List<Keyword> result = tmdb.getMovieKeywords(ID_BLADE_RUNNER); List<Keyword> result = tmdb.getMovieKeywords(ID_BLADE_RUNNER);
assertFalse("No keywords found", result.isEmpty()); assertFalse("No keywords found", result.isEmpty());
} }
@ -174,7 +174,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieReleaseInfo() { public void testGetMovieReleaseInfo() {
logger.info("getMovieReleaseInfo"); LOGGER.info("getMovieReleaseInfo");
List<ReleaseInfo> result = tmdb.getMovieReleaseInfo(ID_BLADE_RUNNER, ""); List<ReleaseInfo> result = tmdb.getMovieReleaseInfo(ID_BLADE_RUNNER, "");
assertFalse("Release information missing", result.isEmpty()); assertFalse("Release information missing", result.isEmpty());
} }
@ -184,7 +184,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieTrailers() { public void testGetMovieTrailers() {
logger.info("getMovieTrailers"); LOGGER.info("getMovieTrailers");
List<Trailer> result = tmdb.getMovieTrailers(ID_BLADE_RUNNER, ""); List<Trailer> result = tmdb.getMovieTrailers(ID_BLADE_RUNNER, "");
assertFalse("Movie trailers missing", result.isEmpty()); assertFalse("Movie trailers missing", result.isEmpty());
} }
@ -194,7 +194,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetMovieTranslations() { public void testGetMovieTranslations() {
logger.info("getMovieTranslations"); LOGGER.info("getMovieTranslations");
List<Translation> result = tmdb.getMovieTranslations(ID_BLADE_RUNNER); List<Translation> result = tmdb.getMovieTranslations(ID_BLADE_RUNNER);
assertFalse("No translations found", result.isEmpty()); assertFalse("No translations found", result.isEmpty());
} }
@ -204,7 +204,7 @@ public class TheMovieDBTest {
*/ */
@Test @Test
public void testGetCollectionInfo() { public void testGetCollectionInfo() {
logger.info("getCollectionInfo"); LOGGER.info("getCollectionInfo");
String language = ""; String language = "";
CollectionInfo result = tmdb.getCollectionInfo(ID_STAR_WARS_COLLECTION, language); CollectionInfo result = tmdb.getCollectionInfo(ID_STAR_WARS_COLLECTION, language);
assertFalse("No collection information", result.getParts().isEmpty()); assertFalse("No collection information", result.getParts().isEmpty());
@ -212,7 +212,7 @@ public class TheMovieDBTest {
@Test @Test
public void testCreateImageUrl() { public void testCreateImageUrl() {
logger.info("createImageUrl"); LOGGER.info("createImageUrl");
MovieDB movie = tmdb.getMovieInfo(ID_BLADE_RUNNER, ""); MovieDB movie = tmdb.getMovieInfo(ID_BLADE_RUNNER, "");
String result = tmdb.createImageUrl(movie.getPosterPath(), "original").toString(); String result = tmdb.createImageUrl(movie.getPosterPath(), "original").toString();
assertTrue("Error compiling image URL", !result.isEmpty()); assertTrue("Error compiling image URL", !result.isEmpty());

Loading…
Cancel
Save