birkeh/api-themoviedb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce complexity of test

Browse Source
This commit is contained in:
Stuart Boston
2016-02-25 15:11:10 +00:00
parent 302e47b496
commit 42ff59d4ba
1 changed files with 53 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/com/omertron/themoviedbapi/methods/TmdbPeopleTest.java
+53 -37
View File
@@ -178,49 +178,65 @@ public class TmdbPeopleTest extends AbstractTests {
TestSuite.test(result.getCast(), "Cast");
TestSuite.test(result.getCrew(), "Crew");
boolean checkedMovie = false;
boolean checkedTV = false;
testCastCredits(result.getCast());
testCrewCredits(result.getCrew());
for (CreditBasic p : result.getCast()) {
if (!checkedMovie && p.getMediaType() == MediaType.MOVIE) {
CreditMovieBasic c = (CreditMovieBasic) p;
assertTrue("No Movie title", StringUtils.isNotBlank(c.getTitle()));
checkedMovie = true;
}
}
}
if (!checkedTV && p.getMediaType() == MediaType.TV) {
CreditTVBasic c = (CreditTVBasic) p;
assertTrue("No TV name", StringUtils.isNotBlank(c.getName()));
checkedTV = true;
}
if (checkedMovie && checkedTV) {
break;
}
/**
* Run tests on cast
*
* @param result
*/
private void testCastCredits(List<CreditBasic> result) {
boolean checkedMovie = false;
boolean checkedTV = false;
for (CreditBasic p : result) {
if (!checkedMovie && p.getMediaType() == MediaType.MOVIE) {
CreditMovieBasic c = (CreditMovieBasic) p;
assertTrue(NO_TITLE, StringUtils.isNotBlank(c.getTitle()));
checkedMovie = true;
}
checkedMovie = false;
checkedTV = false;
for (CreditBasic p : result.getCrew()) {
if (!checkedMovie && p.getMediaType() == MediaType.MOVIE) {
CreditMovieBasic c = (CreditMovieBasic) p;
assertTrue(NO_TITLE, StringUtils.isNotBlank(c.getTitle()));
assertTrue("No department", StringUtils.isNotBlank(c.getDepartment()));
checkedMovie = true;
}
if (!checkedTV && p.getMediaType() == MediaType.TV) {
CreditTVBasic c = (CreditTVBasic) p;
assertTrue("No name", StringUtils.isNotBlank(c.getName()));
assertTrue("No department", StringUtils.isNotBlank(c.getDepartment()));
checkedTV = true;
}
if (checkedMovie && checkedTV) {
break;
}
if (!checkedTV && p.getMediaType() == MediaType.TV) {
CreditTVBasic c = (CreditTVBasic) p;
assertTrue("No TV name", StringUtils.isNotBlank(c.getName()));
checkedTV = true;
}
if (checkedMovie && checkedTV) {
break;
}
}
}
/**
* Run test on crew
*
* @param result
*/
private void testCrewCredits(List<CreditBasic> result) {
boolean checkedMovie = false;
boolean checkedTV = false;
for (CreditBasic p : result) {
if (!checkedMovie && p.getMediaType() == MediaType.MOVIE) {
CreditMovieBasic c = (CreditMovieBasic) p;
assertTrue(NO_TITLE, StringUtils.isNotBlank(c.getTitle()));
assertTrue("No department", StringUtils.isNotBlank(c.getDepartment()));
checkedMovie = true;
}
if (!checkedTV && p.getMediaType() == MediaType.TV) {
CreditTVBasic c = (CreditTVBasic) p;
assertTrue("No name", StringUtils.isNotBlank(c.getName()));
assertTrue("No department", StringUtils.isNotBlank(c.getDepartment()));
checkedTV = true;
}
if (checkedMovie && checkedTV) {
break;
}
}
}