birkeh/api-themoviedb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor sonar fixes

Browse Source
This commit is contained in:
Stuart Boston
2015-03-04 15:30:33 +00:00
parent 591ccdc0f1
commit 2c9f671345
3 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/omertron/themoviedbapi/methods/TmdbKeywords.java
-13
View File
@@ -93,19 +93,6 @@ public class TmdbKeywords extends AbstractMethod {
TmdbResultsList<MovieBasic> results = new TmdbResultsList<MovieBasic>(wrapper.getResults());
results.copyWrapper(wrapper);
return results;
// String webpage = httpTools.getRequest(url);
//
// try {
// WrapperKeywordMovies wrapper = MAPPER.readValue(webpage, WrapperKeywordMovies.class);
// TmdbResultsList<KeywordMovie> results = new TmdbResultsList<KeywordMovie>(wrapper.getResults());
// results.copyWrapper(wrapper);
// return results;
// } catch (IOException ex) {
// throw new MovieDbException(ApiExceptionType.MAPPING_FAILED, "Failed to get keyword movies", url, ex);
// }
}
}
src/main/java/com/omertron/themoviedbapi/methods/TmdbPeople.java
+6 -4
View File
@@ -106,7 +106,8 @@ public class TmdbPeople extends AbstractMethod {
String webpage = httpTools.getRequest(url);
try {
TypeReference tr = new TypeReference<PersonCredits<CreditMovieBasic>>(){};
TypeReference tr = new TypeReference<PersonCredits<CreditMovieBasic>>() {
};
return MAPPER.readValue(webpage, tr);
} catch (IOException ex) {
throw new MovieDbException(ApiExceptionType.MAPPING_FAILED, "Failed to get person movie credits", url, ex);
@@ -138,7 +139,8 @@ public class TmdbPeople extends AbstractMethod {
String webpage = httpTools.getRequest(url);
try {
TypeReference tr = new TypeReference<PersonCredits<CreditTVBasic>>(){};
TypeReference tr = new TypeReference<PersonCredits<CreditTVBasic>>() {
};
return MAPPER.readValue(webpage, tr);
} catch (IOException ex) {
throw new MovieDbException(ApiExceptionType.MAPPING_FAILED, "Failed to get person TV credits", url, ex);
@@ -172,8 +174,8 @@ public class TmdbPeople extends AbstractMethod {
try {
ObjectMapper mapper = new ObjectMapper();
mapper.addMixIn(PersonCredits.class, PersonCreditsMixIn.class);
TypeReference tr = new TypeReference<PersonCredits<CreditBasic>>(){};
// return mapper.readValue(webpage, PersonCredits.class);
TypeReference tr = new TypeReference<PersonCredits<CreditBasic>>() {
};
return mapper.readValue(webpage, tr);
} catch (IOException ex) {
throw new MovieDbException(ApiExceptionType.MAPPING_FAILED, "Failed to get person combined credits", url, ex);
src/main/java/com/omertron/themoviedbapi/model/person/PersonCreditsMixIn.java
+6 -2
View File
@@ -42,7 +42,9 @@ public class PersonCreditsMixIn {
@JsonSubTypes.Type(value = CreditTVBasic.class, name = "tv")
})
@JsonSetter("cast")
public void setCast(List<CreditBasic> cast){}
public void setCast(List<CreditBasic> cast) {
// Mixin empty class
}
@JsonTypeInfo(
use = JsonTypeInfo.Id.NAME,
@@ -55,6 +57,8 @@ public class PersonCreditsMixIn {
@JsonSubTypes.Type(value = CreditTVBasic.class, name = "tv")
})
@JsonSetter("crew")
public void setCrew(List<CreditBasic> crew){}
public void setCrew(List<CreditBasic> crew) {
// Mixin empty class
}
}