Files
o3de/Gems/LmbrCentral/Code/Tests/Builders/MaterialBuilderTests.cpp
T
lumberyard-employee-dm f648cb1fd8 Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-05 15:12:53 -05:00

262 lines
11 KiB
C++

/*
* Copyright (c) Contributors to the Open 3D Engine Project.
* For complete copyright and license terms please see the LICENSE at the root of this distribution.
*
* SPDX-License-Identifier: Apache-2.0 OR MIT
*
*/
#include <AzTest/AzTest.h>
#include <Builders/MaterialBuilder/MaterialBuilderComponent.h>
#include <AzTest/Utils.h>
#include <AzCore/UnitTest/TestTypes.h>
#include <AzCore/IO/FileIO.h>
#include <AzFramework/StringFunc/StringFunc.h>
#include <AzToolsFramework/Application/ToolsApplication.h>
#include <AssetBuilderSDK/AssetBuilderSDK.h>
#include <AzCore/UserSettings/UserSettingsComponent.h>
#include <AzCore/IO/Path/Path.h>
#include <AzCore/Utils/Utils.h>
namespace UnitTest
{
using namespace MaterialBuilder;
using namespace AZ;
class MaterialBuilderTests
: public UnitTest::AllocatorsTestFixture
, public UnitTest::TraceBusRedirector
{
protected:
void SetUp() override
{
UnitTest::AllocatorsTestFixture::SetUp();
m_app.reset(aznew AzToolsFramework::ToolsApplication);
m_app->Start(AZ::ComponentApplication::Descriptor());
// Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is
// shared across the whole engine, if multiple tests are run in parallel, the saving could cause a crash
// in the unit tests.
AZ::UserSettingsComponentRequestBus::Broadcast(&AZ::UserSettingsComponentRequests::DisableSaveOnFinalize);
AZ::Debug::TraceMessageBus::Handler::BusConnect();
const AZStd::string engineRoot = AZ::Test::GetEngineRootPath();
AZ::IO::FileIOBase::GetInstance()->SetAlias("@engroot@", engineRoot.c_str());
AZ::IO::Path assetRoot(AZ::Utils::GetProjectPath());
assetRoot /= "Cache";
AZ::IO::FileIOBase::GetInstance()->SetAlias("@products@", assetRoot.c_str());
}
void TearDown() override
{
AZ::Debug::TraceMessageBus::Handler::BusDisconnect();
m_app->Stop();
m_app.reset();
UnitTest::AllocatorsTestFixture::TearDown();
}
AZStd::string GetTestFileAliasedPath(AZStd::string_view fileName)
{
constexpr char testFileFolder[] = "@engroot@/Gems/LmbrCentral/Code/Tests/Materials/";
return AZStd::string::format("%s%.*s", testFileFolder, aznumeric_cast<int>(fileName.size()), fileName.data());
}
AZStd::string GetTestFileFullPath(AZStd::string_view fileName)
{
AZStd::string aliasedPath = GetTestFileAliasedPath(fileName);
char resolvedPath[AZ_MAX_PATH_LEN];
AZ::IO::FileIOBase::GetInstance()->ResolvePath(aliasedPath.c_str(), resolvedPath, AZ_MAX_PATH_LEN);
return AZStd::string(resolvedPath);
}
void TestFailureCase(AZStd::string_view fileName, [[maybe_unused]] int expectedErrorCount)
{
MaterialBuilderWorker worker;
AZStd::vector<AZStd::string> resolvedPaths;
AZStd::string absoluteMatPath = GetTestFileFullPath(fileName);
AZ_TEST_START_ASSERTTEST;
ASSERT_FALSE(worker.GetResolvedTexturePathsFromMaterial(absoluteMatPath, resolvedPaths));
AZ_TEST_STOP_ASSERTTEST(expectedErrorCount * 2); // The assert tests double count AZ errors, so just multiply expected count by 2
ASSERT_EQ(resolvedPaths.size(), 0);
}
void TestSuccessCase(AZStd::string_view fileName, AZStd::vector<const char*>& expectedTextures)
{
MaterialBuilderWorker worker;
AZStd::vector<AZStd::string> resolvedPaths;
size_t texturesInMaterialFile = expectedTextures.size();
AZStd::string absoluteMatPath = GetTestFileFullPath(fileName);
ASSERT_TRUE(worker.GetResolvedTexturePathsFromMaterial(absoluteMatPath, resolvedPaths));
ASSERT_EQ(resolvedPaths.size(), texturesInMaterialFile);
if (texturesInMaterialFile > 0)
{
ASSERT_THAT(resolvedPaths, testing::ElementsAreArray(expectedTextures));
AssetBuilderSDK::ProductPathDependencySet dependencies;
ASSERT_TRUE(worker.PopulateProductDependencyList(resolvedPaths, dependencies));
ASSERT_EQ(dependencies.size(), texturesInMaterialFile);
}
}
void TestSuccessCase(AZStd::string_view fileName, const char* expectedTexture)
{
AZStd::vector<const char*> expectedTextures;
expectedTextures.push_back(expectedTexture);
TestSuccessCase(fileName, expectedTextures);
}
void TestSuccessCaseNoDependencies(AZStd::string_view fileName)
{
AZStd::vector<const char*> expectedTextures;
TestSuccessCase(fileName, expectedTextures);
}
AZStd::unique_ptr<AzToolsFramework::ToolsApplication> m_app;
};
TEST_F(MaterialBuilderTests, MaterialBuilder_EmptyFile_ExpectFailure)
{
// Should fail in MaterialBuilderWorker::GetResolvedTexturePathsFromMaterial, when checking for the size of the file.
TestFailureCase("test_mat1.mtl", 1);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_NoChildren_ExpectFailure)
{
// Should fail in MaterialBuilderWorker::GetResolvedTexturePathsFromMaterial after calling
// Internal::GetTexturePathsFromMaterial, which should return an AZ::Failure when both a Textures node and a
// SubMaterials node are not found. No other AZ_Errors should be generated.
TestFailureCase("test_mat2.mtl", 1);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_EmptyTexturesNode_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat3.mtl");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_EmptySubMaterialNode_ExpectFailure)
{
// Should fail in MaterialBuilderWorker::GetResolvedTexturePathsFromMaterial after calling
// Internal::GetTexturePathsFromMaterial, which should return an AZ::Failure when a SubMaterials node is present,
// but has no children Material node. No other AZ_Errors should be generated.
TestFailureCase("test_mat4.mtl", 1);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_EmptyTextureNode_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat5.mtl");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_EmptyMaterialInSubMaterial_ExpectFailure)
{
// Should fail in MaterialBuilderWorker::GetResolvedTexturePathsFromMaterial after calling
// Internal::GetTexturePathsFromMaterial, which should return an AZ::Failure when a SubMaterials node is present,
// but a child Material node has no child Textures node and no child SubMaterials node. No other AZ_Errors should
// be generated.
TestFailureCase("test_mat6.mtl", 1);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_EmptyTextureNodeInSubMaterial_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat7.mtl");
}
#if AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS // The following test file 'test_mat8.mtl' has a windows-specific absolute path, so this test is only valid on windows
TEST_F(MaterialBuilderTests, MaterialBuilder_TextureAbsolutePath_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat8.mtl");
}
#endif
TEST_F(MaterialBuilderTests, MaterialBuilder_TextureRuntimeAlias_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat9.mtl");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_TextureRuntimeTexture_NoDependencies)
{
TestSuccessCaseNoDependencies("test_mat10.mtl");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SingleMaterialSingleTexture_ValidSourceFormat)
{
// texture referenced is textures/natural/terrain/am_floor_tile_ddn.png
const char* expectedPath = "textures/natural/terrain/am_floor_tile_ddn.dds";
TestSuccessCase("test_mat11.mtl", expectedPath);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SingleMaterialSingleTexture_ValidProductFormat)
{
// texture referenced is textures/natural/terrain/am_floor_tile_ddn.dds
const char* expectedPath = "textures/natural/terrain/am_floor_tile_ddn.dds";
TestSuccessCase("test_mat12.mtl", expectedPath);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SingleMaterialSingleTexture_InvalidSourceFormat_NoDependenices)
{
// texture referenced is textures/natural/terrain/am_floor_tile_ddn.txt
TestSuccessCaseNoDependencies("test_mat13.mtl");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_TextureAnimSequence)
{
AZStd::vector<const char*> expectedPaths = {
"path/to/my/textures/test_anim_sequence_01_texture000.dds",
"path/to/my/textures/test_anim_sequence_01_texture001.dds",
"path/to/my/textures/test_anim_sequence_01_texture002.dds",
"path/to/my/textures/test_anim_sequence_01_texture003.dds",
"path/to/my/textures/test_anim_sequence_01_texture004.dds",
"path/to/my/textures/test_anim_sequence_01_texture005.dds"
};
TestSuccessCase("test_mat14.mtl", expectedPaths);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SingleMaterialMultipleTexture)
{
AZStd::vector<const char*> expectedPaths = {
"engineassets/textures/hex.dds",
"engineassets/textures/hex_ddn.dds"
};
TestSuccessCase("test_mat15.mtl", expectedPaths);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_MalformedMaterial_MultipleTextures_OneEmptyTexture)
{
TestSuccessCase("test_mat16.mtl", "engineassets/textures/hex_ddn.dds");
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SingleMaterialMultipleTexture_ResolveLeadingSeparatorsAndAliases)
{
AZStd::vector<const char*> expectedPaths = {
"engineassets/textures/hex.dds", // resolved from "/engineassets/textures/hex.dds"
"engineassets/textures/hex_ddn.dds", // resolved from "./engineassets/textures/hex_ddn.dds"
"engineassets/textures/hex_spec.dds" // resolved from "@products@/engineassets/textures/hex_spec.dds"
};
TestSuccessCase("test_mat17.mtl", expectedPaths);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SubMaterialSingleTexture)
{
AZStd::vector<const char*> expectedPaths = {
"engineassets/textures/scratch.dds",
"engineassets/textures/perlinnoise2d.dds"
};
TestSuccessCase("test_mat18.mtl", expectedPaths);
}
TEST_F(MaterialBuilderTests, MaterialBuilder_SubMaterialMultipleTexture)
{
AZStd::vector<const char*> expectedPaths = {
"engineassets/textures/scratch.dds",
"engineassets/textures/scratch_ddn.dds",
"engineassets/textures/perlinnoise2d.dds",
"engineassets/textures/perlinnoisenormal_ddn.dds"
};
TestSuccessCase("test_mat19.mtl", expectedPaths);
}
}