You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Tools/AssetProcessor/native/ui
Dennis Brakhane 7f75dc6dee
Fix "index out of range" error in AssetProcessor (#4324)
* Fix "index out of range" error

When the parent is the tree root element, beginInsertRows must be
called with an invalid (but legal) index. A QModelIndex with a row
index of zero when the parent has no children is an illegal index
and will result in "undefined behavior", like the "index out of
range" one.

Therefore, if our parent is the tree root element, we use QModelIndex()
instead.

Fixes #2343

Signed-off-by: Dennis Brakhane <brakhane@gmail.com>

* Use QModelIndex() instead of createIndex(-1, -1)

Both do the same, but the former is Qt best practise.

Signed-off-by: Dennis Brakhane <brakhane@gmail.com>

* add some sanity checks in debug mode

Using illegal ModelIndices can result in hard to debug problems later
on, so add a few checks to help spotting them sooner.

Signed-off-by: Dennis Brakhane <brakhane@gmail.com>
4 years ago
..
style Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetDetailsPanel.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetDetailsPanel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetTreeFilterModel.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetTreeFilterModel.h Minimal TypeInfo header/reduce std interdependencies. (#2688) 4 years ago
AssetTreeItem.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetTreeItem.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetTreeModel.cpp Fix "index out of range" error in AssetProcessor (#4324) 4 years ago
AssetTreeModel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ConnectionEditDialog.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ConnectionEditDialog.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GoToButton.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GoToButton.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
GoToButton.ui Initial commit 5 years ago
JobTreeViewItemDelegate.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
JobTreeViewItemDelegate.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
MainWindow.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
MainWindow.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
MainWindow.ui Changed AP window title and popup messages 5 years ago
ProductAssetDetailsPanel.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ProductAssetDetailsPanel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ProductAssetDetailsPanel.ui Initial commit 5 years ago
ProductAssetTreeItemData.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ProductAssetTreeItemData.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ProductAssetTreeModel.cpp Fix "index out of range" error in AssetProcessor (#4324) 4 years ago
ProductAssetTreeModel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SourceAssetDetailsPanel.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SourceAssetDetailsPanel.h Minimal TypeInfo header/reduce std interdependencies. (#2688) 4 years ago
SourceAssetDetailsPanel.ui Initial commit 5 years ago
SourceAssetTreeItemData.cpp Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SourceAssetTreeItemData.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SourceAssetTreeModel.cpp Fix "index out of range" error in AssetProcessor (#4324) 4 years ago
SourceAssetTreeModel.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago