Files
o3de/Gems/LyShine/Code/Tests/LyShineEditorTest.cpp
T
lumberyard-employee-dm f648cb1fd8 Update the FileIO Aliases (#4186)
* Update the FileIOAlias naming to make the cache, project root and engine
root paths more clear

The alias of `@root@`, `@assets@`, and `@projectplatformcache@` has been
collapsed to `@projectproductassets@`

The alias of `@devroot@` and `@engroot@` has been collapsed to
`@engroot@`

The alias of `@devassets@` and `@projectroot@` has been collapsed to
`@projectroot@`

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated use of devassets and devroot properties in python

Those properties now use projectroot and engroot

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updating the alias @engroot@ alias path comment in each platform specific LocalFileIO_*.cpp file

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed hardcoded size of 9 for the product asset alias.

The ResolvePath function now just appends the @projectproductassets@
alias with the input path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove duplicate @projectproductassets@ check in ProcessFileTreeRequest

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix for typos in Hydra python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated LocalFileIO::Copy call on Windows to use the Unicode aware CopyFileW API

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the AWSMetreicsGemAllocatorFixture to properly suppress asset
cache write errors for Test file creation.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unneeded call to set the @projectproductasstes@ alias at the bottom of the AssetSeedManagerTest SetUp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added a deprecated alias map to the FileIO System

When a deprecated alias is accessed, the FileIO System logs an AZ_Error and indicates the alias that should be used

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated python test scripts to use the projectroot binding

Retrieving the AutomatedTesting project path based on "<devroot>/AutomatedTesting" has been removed.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to devroot and devgame within the codebase

The GetAbsoluteDevGameFolderPath functions has been replaced with direct call to AZ::Utils::GetProjectPath
The GetAbsoluteDevRootFolderPath functions has been replaced with direct calls to AZ::Utils::GetEnginePath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated <engroot>/AutomatedTesting references to projectroot


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced references that assumes the project path is <engroot>/AutomatedTesting with <projectroot> in the AutomatedTesting python test

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Correct casing in emfxworkspace file


Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed newly added AppendPathParts function
Removed the Path constructors which accepts a PathIterable instance

The PathIterable isn't safe to return to a user of the Path class as it might be referencing temporary paths supplied via PathView arguments

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed unused parameter warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Undid change to the LexicallyProximate function to set the path result to the base path.

It needs to return the *this path if the pathResult is empty

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the LocalFileIO ConvertToAbsolutePath implementations to AZ::Utils

Fixed the ConvertToAbsolutePath implementation for Unix platforms to use a buffer that is size PATH_MAX(4096 on all our supported Unix platforms).
Because the buffer before was AZ::IO::MaxPathLength which as a size of 1024, this was resulting in the Unix `realpath` function smashing the stack when it converts a path to an absolute path that is longer than 1024 characters

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the EditorCore.Tests to attach the AZ Environment to the EditorCore shared library that is statically loaded on launch.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed for DeprecatedAlaisesKeyVisitor Visit function causing the non string_view overloads being hidden causing a hidden base class function warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Changed the AWSMetricsGemMock to use a temporary for writing test assets

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the LocalFileIO::ResolvePath function to use HasRootPath to determine if a path starts with a root path such as "D:", "D:/" or "/"

IsAbsolute was not the corect check as the path of "D:" is a relative
path.
To be absolute according to the Windows the path must have a root
directory. i.e "D:/" or "D:\"

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed absolute path comment from LocalFile_UnixLike.cpp and LocalFile_Android.cpp FindFiles implementations
Updated the ConvertToAlias to supply an AZ::IO::FixedMaxPath

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced usage of the @projectproductassets@ alias with @engroot@ when referring to the LmbrCentral source folder in the CopyDependencyBuilderTest and the SeedBuilderTests

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the ScriptCanvas Upgrade Tool to output backed up files to the
Project User Path instead of the engine root

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed whitespacing issues in Application.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Remove unnecessary creation of a FixedMaxPath in the UpgradeTool.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Modified testSeedFolder variable in the SeedBuilderTests to use the
@engroot@ alias instead of @projectproductassets@/.. alias when
referring to the LmbrCentral Gem source path

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated references to the Project Asset Cache in the PythonTests.

Those tests no longer use the logic `azlmbr.paths.projectroot / "Cache" / "pc"` to retrieve a path to the cache root but instead the `azlmbr.paths.projectproductassets` constant

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fixed the FileIO Deprecated Alias test on Windows

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing @projectsourceassets@ alias, as it is only used once.

Updated the PhysX EditorSystemComponent.cpp to query the ProjectPath
form the SettingsRegistry.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Replaced @projectproductassets@ alias with @products@

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Rollback changes to the PhysX EditorSystemComponent.cpp

The changes to use the ProjectPath from the SettingsRegistry has been implemented in PR #4497

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-10-05 15:12:53 -05:00

276 lines
14 KiB
C++

/*
* Copyright (c) Contributors to the Open 3D Engine Project.
* For complete copyright and license terms please see the LICENSE at the root of this distribution.
*
* SPDX-License-Identifier: Apache-2.0 OR MIT
*
*/
#include <AzTest/AzTest.h>
#include <AzTest/Utils.h>
#include <CryCommon/Mocks/ISystemMock.h>
#include <LyShineBuilder/UiCanvasBuilderWorker.h>
#include <AzCore/IO/Path/Path.h>
#include <AzCore/Settings/SettingsRegistryMergeUtils.h>
#include <AzCore/UserSettings/UserSettingsComponent.h>
#include <AzCore/Utils/Utils.h>
#include <AzToolsFramework/Application/ToolsApplication.h>
#include <LyShineSystemComponent.h>
#include <AzCore/Component/ComponentApplicationBus.h>
#include <World/UiCanvasAssetRefComponent.h>
#include <World/UiCanvasProxyRefComponent.h>
#include <World/UiCanvasOnMeshComponent.h>
#include <UiCanvasComponent.h>
#include <UiElementComponent.h>
#include <UiTransform2dComponent.h>
#include <UiImageComponent.h>
#include <UiTextComponent.h>
#include <UiButtonComponent.h>
#include <UiCheckboxComponent.h>
#include <UiDraggableComponent.h>
#include <UiDropTargetComponent.h>
#include <UiDropdownOptionComponent.h>
#include <UiTextInputComponent.h>
#include <UiImageSequenceComponent.h>
#include <UiMarkupButtonComponent.h>
#include <UiScrollBoxComponent.h>
#include <UiDropdownComponent.h>
#include <UiSliderComponent.h>
#include <UiScrollBarComponent.h>
#include <UiFaderComponent.h>
#include <UiFlipbookAnimationComponent.h>
#include <UiLayoutFitterComponent.h>
#include <UiMaskComponent.h>
#include <UiLayoutCellComponent.h>
#include <UiLayoutRowComponent.h>
#include <UiLayoutGridComponent.h>
#include <UiTooltipComponent.h>
#include <UiTooltipDisplayComponent.h>
#include <UiDynamicLayoutComponent.h>
#include <UiDynamicScrollBoxComponent.h>
#include <UiSpawnerComponent.h>
#include <UiRadioButtonComponent.h>
#include <UiLayoutColumnComponent.h>
#include <UiRadioButtonGroupComponent.h>
#include <UiParticleEmitterComponent.h>
#include <UiCanvasManager.h>
AZ_UNIT_TEST_HOOK(DEFAULT_UNIT_TEST_ENV);
using namespace AZ;
using ::testing::NiceMock;
class LyShineSystemTestComponent
: public LyShine::LyShineSystemComponent
{
friend class LyShineEditorTest;
};
class LyShineEditorTest
: public ::testing::Test
{
protected:
void SetUp() override
{
using namespace LyShine;
m_priorEnv = gEnv;
m_data = AZStd::make_unique<DataMembers>();
memset(&m_data->m_stubEnv, 0, sizeof(SSystemGlobalEnvironment));
m_data->m_stubEnv.pSystem = &m_data->m_mockSystem;
gEnv = &m_data->m_stubEnv;
AZ::SettingsRegistryInterface* registry = AZ::SettingsRegistry::Get();
auto projectPathKey =
AZ::SettingsRegistryInterface::FixedValueString(AZ::SettingsRegistryMergeUtils::BootstrapSettingsRootKey) + "/project_path";
registry->Set(projectPathKey, "AutomatedTesting");
AZ::SettingsRegistryMergeUtils::MergeSettingsToRegistry_AddRuntimeFilePaths(*registry);
m_app.Start(m_descriptor);
// Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is
// shared across the whole engine, if multiple tests are run in parallel, the saving could cause a crash
// in the unit tests.
AZ::UserSettingsComponentRequestBus::Broadcast(&AZ::UserSettingsComponentRequests::DisableSaveOnFinalize);
const AZStd::string engineRoot = AZ::Test::GetEngineRootPath();
AZ::IO::FileIOBase::GetInstance()->SetAlias("@engroot@", engineRoot.c_str());
AZ::IO::Path assetRoot(AZ::Utils::GetProjectPath());
assetRoot /= "Cache";
AZ::IO::FileIOBase::GetInstance()->SetAlias("@products@", assetRoot.c_str());
AZ::SerializeContext* context = nullptr;
ComponentApplicationBus::BroadcastResult(context, &ComponentApplicationBus::Events::GetSerializeContext);
ASSERT_NE(context, nullptr);
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(LyShineSystemComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiCanvasAssetRefComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiCanvasProxyRefComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiCanvasOnMeshComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiCanvasComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiElementComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiTransform2dComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiImageComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiImageSequenceComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiTextComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiButtonComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiMarkupButtonComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiCheckboxComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDraggableComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDropTargetComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDropdownComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDropdownOptionComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiSliderComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiTextInputComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiScrollBoxComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiScrollBarComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiFaderComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiFlipbookAnimationComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiLayoutFitterComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiMaskComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiLayoutCellComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiLayoutColumnComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiLayoutRowComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiLayoutGridComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiTooltipComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiTooltipDisplayComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDynamicLayoutComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiDynamicScrollBoxComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiSpawnerComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiRadioButtonComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiRadioButtonGroupComponent::CreateDescriptor()));
m_componentDescriptors.push_back(AZStd::unique_ptr<AZ::ComponentDescriptor>(UiParticleEmitterComponent::CreateDescriptor()));
context->ClassDeprecate("SimpleAssetReference_MaterialAsset", "{B7B8ECC7-FF89-4A76-A50E-4C6CA2B6E6B4}",
[](AZ::SerializeContext& context, AZ::SerializeContext::DataElementNode& rootElement)
{
AZStd::vector<AZ::SerializeContext::DataElementNode> childNodeElements;
for (int index = 0; index < rootElement.GetNumSubElements(); ++index)
{
childNodeElements.push_back(rootElement.GetSubElement(index));
}
// Convert the rootElement now, the existing child DataElmentNodes are now removed
rootElement.Convert<AzFramework::SimpleAssetReference<LmbrCentral::MaterialAsset>>(context);
for (AZ::SerializeContext::DataElementNode& childNodeElement : childNodeElements)
{
rootElement.AddElement(AZStd::move(childNodeElement));
}
return true;
});
context->ClassDeprecate("SimpleAssetReference_TextureAsset", "{68E92460-5C0C-4031-9620-6F1A08763243}",
[](AZ::SerializeContext& context, AZ::SerializeContext::DataElementNode& rootElement)
{
AZStd::vector<AZ::SerializeContext::DataElementNode> childNodeElements;
for (int index = 0; index < rootElement.GetNumSubElements(); ++index)
{
childNodeElements.push_back(rootElement.GetSubElement(index));
}
// Convert the rootElement now, the existing child DataElmentNodes are now removed
rootElement.Convert<AzFramework::SimpleAssetReference<LmbrCentral::TextureAsset>>(context);
for (AZ::SerializeContext::DataElementNode& childNodeElement : childNodeElements)
{
rootElement.AddElement(AZStd::move(childNodeElement));
}
return true;
});
AzFramework::SimpleAssetReference<LmbrCentral::MaterialAsset>::Register(*context);
AzFramework::SimpleAssetReference<LmbrCentral::TextureAsset>::Register(*context);
for(const auto& descriptor : m_componentDescriptors)
{
descriptor->Reflect(context);
}
m_sysComponent = AZStd::make_unique<LyShineSystemTestComponent>();
m_sysComponent->Activate();
}
void TearDown() override
{
m_componentDescriptors = {};
m_sysComponent->Deactivate();
m_sysComponent = nullptr;
m_app.Stop();
m_data.reset();
gEnv = m_priorEnv;
}
AZStd::unique_ptr<LyShineSystemTestComponent> m_sysComponent;
AzToolsFramework::ToolsApplication m_app;
AZ::ComponentApplication::Descriptor m_descriptor;
AZStd::vector<AZStd::unique_ptr<AZ::ComponentDescriptor>> m_componentDescriptors;
struct DataMembers
{
SSystemGlobalEnvironment m_stubEnv;
NiceMock<SystemMock> m_mockSystem;
};
AZStd::unique_ptr<DataMembers> m_data;
SSystemGlobalEnvironment* m_priorEnv = nullptr;
};
AZStd::string GetTestFileAliasedPath(AZStd::string_view fileName)
{
constexpr char testFileFolder[] = "@engroot@/Gems/LyShine/Code/Tests/";
return AZStd::string::format("%s%.*s", testFileFolder, aznumeric_cast<int>(fileName.size()), fileName.data());
}
AZStd::string GetTestFileFullPath(AZStd::string_view fileName)
{
AZStd::string aliasedPath = GetTestFileAliasedPath(fileName);
char resolvedPath[AZ_MAX_PATH_LEN];
AZ::IO::FileIOBase::GetInstance()->ResolvePath(aliasedPath.c_str(), resolvedPath, AZ_MAX_PATH_LEN);
return AZStd::string(resolvedPath);
}
bool OpenTestFile(AZStd::string_view fileName, AZ::IO::FileIOStream& fileStream)
{
AZStd::string aliasedPath = GetTestFileAliasedPath(fileName);
return fileStream.Open(aliasedPath.c_str(), AZ::IO::OpenMode::ModeRead | AZ::IO::OpenMode::ModeBinary);
}
TEST_F(LyShineEditorTest, ProcessUiCanvas_ReturnsDependencyOnSpriteAndTexture)
{
using namespace LyShine;
using namespace AssetBuilderSDK;
UiCanvasBuilderWorker worker;
AZStd::vector<ProductDependency> productDependencies;
ProductPathDependencySet productPathDependencySet;
UiSystemToolsInterface::CanvasAssetHandle* canvasAsset = nullptr;
AZ::Entity* sourceCanvasEntity = nullptr;
AZ::Entity exportCanvasEntity;
AZ::IO::FileIOStream stream;
ASSERT_TRUE(OpenTestFile("1ImageReference.uicanvas", stream));
ASSERT_TRUE(worker.ProcessUiCanvasAndGetDependencies(stream, productDependencies, productPathDependencySet, canvasAsset, sourceCanvasEntity, exportCanvasEntity));
ASSERT_EQ(productDependencies.size(), 0);
ASSERT_THAT(productPathDependencySet, testing::UnorderedElementsAre(
ProductPathDependency{ "textures/defaults/grey.dds", ProductPathDependencyType::ProductFile },
ProductPathDependency{ "textures/defaults/grey.sprite", ProductPathDependencyType::ProductFile }
));
}
TEST_F(LyShineEditorTest, FindLoadedCanvasByPathName_FT)
{
UiCanvasManager canvasManager;
//find loaded canvas, should return invalid id
AZ::EntityId entityId = canvasManager.FindLoadedCanvasByPathName("@engroot@/Gems/LyShine/Code/Tests/TestAssets/Canvases/empty.uicanvas", false);
EXPECT_FALSE(entityId.IsValid());
//load a new canvas
entityId = canvasManager.FindLoadedCanvasByPathName("@engroot@/Gems/LyShine/Code/Tests/TestAssets/Canvases/empty.uicanvas", true);
EXPECT_TRUE(entityId.IsValid());
}