You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
o3de/Code/Framework/AzToolsFramework/AzToolsFramework
amzn-phist fec77632ef
Archive Component - Rewrite and additional work on Archive and Asset Bundler (#4332)
* Fix issues with seedlist for AutomatedTesting

Fixes error reporting so it will show the file hint in the tool.
Removes any missing assets from the .seed file.
Remove an unnecessary dependency from AutomatedTesting dependencies
file.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Make ArchiveComponent use AZ::IO::IArchive

Initial changes that will get the sychronous calls in ArchiveComponent
to use IArchive interface rather than external zip/7z tools.

Some of the asynchronous api are still in place, anything that wasn't
being used has been removed for now.  This may change later if we move
towards all the api being asynchronous.  Until then, we can't remove the
reliance upon the external archive tools completely.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Updates AZStd::thread constructors

Adds a variadic constructor which forwards args to the functor.
Because of our thread_desc extension, there was confusion on the
arugments, so the args were reordered to take the thread_desc first,
before the functor and args.
Also the thread_desc is taken as reference rather than by pointer.
Update callsites to account for this change.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Async operation of ArchiveComponent api

This sets up the ArchiveComponent to operate asynchronously.  It uses
promise/future to transfer results to caller.

This is still broken, there's a few things that need to get fixed up,
but this is a good checkpoint for the work as it solidifies the api,
cleans up a bunch of unused code, and compiles.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the platform-specific ArchiveComponen

These are no longer needed, as they control the direct interaction with
host OS tools like 7za.exe or /bin/zip.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the platform-specific files from cmake

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Removes the 7za.exe (and legal notice)

This tool is no longer needed in the repo.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fixes usage of IArchive::GetFullPath()

This changed to return a PathView, updated to reflect that.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix promises and threads

Make sure promises are only set exactly once.  This meant reworking some
of the initial error checking.
Detach threads when created.  Adds [[nodiscard]] to the functions that
return a future.  Since threads are detached, the future is the main way
to get communication from the thread.
Clean up interface, add comments.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* More edits to thread creation

Changes to thread construction to account for parameter change.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix some remaining issues with ArchiveComponent

Put created threads inside a container, then join them at Deactivate.
Fix asset bundler case when injecting a file with no working directory.
Fix thread constructor that applies args to a function.
Fix lambdas to take string args by value rather than reference.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fixes some remaining bugs in ArchiveComponent

Open archive as read-only during extract & list operations.
Fixes paths issues.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix initialize of opaque thread handle in thread_UnixLike.h

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed unused variable in AssetBundleComponent.cpp to fix compiler warning

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix some issues with archives

File paths in the CDR and the local headers need to match, but there
were issues with path separators and case that made it possible to get
invalid headers errors in some archives.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Adds some new ArchiveComponent unit tests

Adds new tests for extraction of archive and adding files from a file
list to an archive.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Fix file data offset issues when opening archives

When opening an INestedArchive it would run through the CDR headers to
create file entries in the zip cache.  The offsets to the compressed
data were being calculated incorrectly because they were using the CDR
headers rather than jumping to the local file headers and getting
offsets from those sizes.

Removed and refactored some archive validation flow and zip cache
factory init methods to either init default or init w/ additional
validation checks.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Addresses PR feedback

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address more points of feedback in PR

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address additional PR feedback

 Fixes up some error checks and uses of strings vs paths.
 Enable archive component tests on Linux so we can see if they will
 pass.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address PR feedback

Change the INestedArchive interface to list files as AZ::IO::Path.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Disabling the ArchiveComponent tests on Linux

They failed so we will revisit them to attempt a fix.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Rename a member variable to be more accurate

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Address feedback on PR

Bump version of Archive Components for serialize context.
Improve error messages during archive open and validation.

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Revert recent changes

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
4 years ago
..
API Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
Application Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
Archive Archive Component - Rewrite and additional work on Archive and Asset Bundler (#4332) 4 years ago
Asset Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
AssetBrowser set ed_useNewAssetBrowserTableView to false by default 4 years ago
AssetBundle Archive Component - Rewrite and additional work on Archive and Asset Bundler (#4332) 4 years ago
AssetCatalog Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
AssetDatabase Added new index on SourceDependency Table (#3648) 4 years ago
AssetEditor Fix missing include for AZStd::unordered_set in AssetEditorBus.h 4 years ago
Commands Fixes AzToolsFramework 4 years ago
Component more fixes for Code 4 years ago
ComponentMode Call sites for activating/deactivating viewport editor modes. (#4265) 4 years ago
ComponentModes Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Debug Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Editor Merge branch 'develop' into LYN-4700 5 years ago
Entity Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
Fingerprinting Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
FocusMode Merge pull request #4413 from aws-lumberyard-dev/LYN-5265_state_tracker_impl 4 years ago
Input Fix mouse capture behavior for Editor Viewport (#3417) 4 years ago
Logger added functions to remove and clear trace logger filters 4 years ago
Manipulators Removed ununeeded includes from EBus EBus.h and Policies.h (#4256) 4 years ago
Maths Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Picking Add a new implementation for cone/ray intersect to simplify code and fix issue with current implementation (#3902) 4 years ago
Prefab Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
PropertyTreeEditor Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
PythonTerminal fixing hidden variable warning 4 years ago
Render Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
SQLite Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
Slice some more fixes 4 years ago
SourceControl Removed ununeeded includes from EBus EBus.h and Policies.h (#4256) 4 years ago
Thumbnails more fixes for Code 4 years ago
ToolsComponents Cleanup SerializeContext.h pt.1 (#4264) 4 years ago
ToolsFileUtils Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
ToolsMessaging Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
UI Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
Undo Add AZ_BUDGET_DEFINE/AZ_BUDGET_DECLARE and remove driller 4 years ago
UnitTest Call sites for activating/deactivating viewport editor modes. (#4265) 4 years ago
Viewport Additional test support for Manipulator Ditto commands (#4191) 4 years ago
ViewportSelection Call sites for activating/deactivating viewport editor modes. (#4265) 4 years ago
ViewportUi update joints to use cluster viewport ui. (#4352) 4 years ago
AzToolsFrameworkModule.cpp Remove nested FocusModeFramework namespace 4 years ago
AzToolsFrameworkModule.h Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframework_files.cmake Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/breadcrumbs 4 years ago
aztoolsframework_linux_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframework_linux_tests_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframework_mac_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframework_win_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframework_windows_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
aztoolsframeworktestcommon_files.cmake Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago
newoverride.inl Shorten copyright headers by splitting into 2 lines (#2213) 5 years ago