Files
o3de/Gems/SceneProcessing/Code/Tests/SceneBuilder/SceneBuilderTests.cpp
T
lumberyard-employee-dm 627012840d Update how Project Filepaths are calculated when not supplied via command line (#5194)
* Fixed the return value of the ConvertToAbsolutePath function

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added the generated cmake_dependencies.*.setreg files to engine.pak (#5073)

* Copied the generated cmake_dependencies.*.setreg file to the Cache
directory

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removed the platform name from the bootstrap.game.*.setreg

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Update how the project related file paths are determined when not
supplied.

The project-path determination now goes back to only detecting a "project.json" file.
It no longer attempts to detect a "Cache" directory

The project-cache-path determination now in addition to checking the
project_cache_path key searches for a "Cache" directory.

The project-path defaults to executable folder if it cannot be detected.

The copying of generated executable folder Registry directory contents
to the product cache is now removed after the archive step.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated the invocation of the AssetProcessor in Jenkins to supply an
absolute path to the project.

The project-path is no longer treated as relative to the engine root,
but instead relative to the current working directory at application
startup.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Added constant for the storing the name of Cache directory

Fixed typos and grammatical errors in the SettingsRegistryMergeUtils.cpp

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Updated UnitTest prepend the EngineRoot path to "AutomatedTesting" when
setting the project path.

This is needed now that the project-path isn't treated relative to the
EngineRoot if it is not absolute.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Fix AssetSeedManagerTest and PlatformAddressedAssetCatalogManagerTest

Instead of trying to used the AutomatedTesting directory as the project root, the temp directory created during the test is used as the project root.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Moved the setting of the project cache root folder and project
asset platform root folder into the `if (!projectCachePath.empty())`
block

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>

* Removing the scan up logic for the "Cache" directory.

This is no longer needed to locate the project cache path in a Project Game Release Layout.

Because the project path defaults to the executable directory if, it is not found, the Cache directory will be set to the "Cache" directory within the executable directory.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-11-04 11:02:18 -05:00

377 lines
15 KiB
C++

/*
* Copyright (c) Contributors to the Open 3D Engine Project.
* For complete copyright and license terms please see the LICENSE at the root of this distribution.
*
* SPDX-License-Identifier: Apache-2.0 OR MIT
*
*/
#include <AzTest/AzTest.h>
#include <AssetBuilderSDK/AssetBuilderSDK.h>
#include <AzCore/IO/FileIO.h>
#include <AzCore/IO/Path/Path.h>
#include <AzCore/Serialization/Json/JsonSerializationSettings.h>
#include <AzCore/Settings/SettingsRegistryMergeUtils.h>
#include <AzCore/UnitTest/TestTypes.h>
#include <AzCore/UnitTest/Mocks/MockFileIOBase.h>
#include <AzCore/UnitTest/Mocks/MockSettingsRegistry.h>
#include <AzCore/UserSettings/UserSettingsComponent.h>
#include <AzFramework/StringFunc/StringFunc.h>
#include <AzToolsFramework/Application/ToolsApplication.h>
#include <SceneAPI/SceneCore/Events/AssetImportRequest.h>
#include <SceneBuilder/SceneBuilderWorker.h>
#include <SceneAPI/SceneCore/Events/ExportProductList.h>
#include <Tests/FileIOBaseTestTypes.h>
using namespace AZ;
using namespace SceneBuilder;
class SceneBuilderTests
: public UnitTest::AllocatorsFixture
, public UnitTest::TraceBusRedirector
{
protected:
void SetUp() override
{
AZ::SettingsRegistryInterface* registry = AZ::SettingsRegistry::Get();
auto projectPathKey =
AZ::SettingsRegistryInterface::FixedValueString(AZ::SettingsRegistryMergeUtils::BootstrapSettingsRootKey) + "/project_path";
AZ::IO::FixedMaxPath enginePath;
registry->Get(enginePath.Native(), AZ::SettingsRegistryMergeUtils::FilePathKey_EngineRootFolder);
registry->Set(projectPathKey, (enginePath / "AutomatedTesting").Native());
AZ::SettingsRegistryMergeUtils::MergeSettingsToRegistry_AddRuntimeFilePaths(*registry);
m_app.Start(AZ::ComponentApplication::Descriptor());
AZ::Debug::TraceMessageBus::Handler::BusConnect();
// Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is
// shared across the whole engine, if multiple tests are run in parallel, the saving could cause a crash
// in the unit tests.
AZ::UserSettingsComponentRequestBus::Broadcast(&AZ::UserSettingsComponentRequests::DisableSaveOnFinalize);
m_workingDirectory = m_app.GetExecutableFolder();
AZ::IO::FileIOBase::GetInstance()->SetAlias("@products@", m_workingDirectory);
}
void TearDown() override
{
AZ::Debug::TraceMessageBus::Handler::BusDisconnect();
m_app.Stop();
}
void TestSuccessCase(const SceneAPI::Events::ExportProduct& exportProduct,
const AssetBuilderSDK::ProductPathDependencySet& expectedPathDependencies,
const AZStd::vector<AZ::Uuid>& expectedProductDependencies)
{
SceneBuilderWorker worker;
AssetBuilderSDK::JobProduct jobProduct(exportProduct.m_filename, exportProduct.m_assetType, 0);
worker.PopulateProductDependencies(exportProduct, m_workingDirectory, jobProduct);
ASSERT_EQ(expectedPathDependencies.size(), jobProduct.m_pathDependencies.size());
if (expectedPathDependencies.size() > 0)
{
for (const AssetBuilderSDK::ProductPathDependency& dependency : expectedPathDependencies)
{
ASSERT_TRUE(jobProduct.m_pathDependencies.find(dependency) != jobProduct.m_pathDependencies.end());
}
}
ASSERT_EQ(expectedProductDependencies.size(), jobProduct.m_dependencies.size());
if (expectedProductDependencies.size() > 0)
{
for (const AssetBuilderSDK::ProductDependency& dependency : jobProduct.m_dependencies)
{
ASSERT_TRUE(AZStd::find(expectedProductDependencies.begin(), expectedProductDependencies.end(), dependency.m_dependencyId.m_guid) != expectedProductDependencies.end());
}
}
}
void TestSuccessCase(const SceneAPI::Events::ExportProduct& exportProduct,
const AssetBuilderSDK::ProductPathDependency* expectedPathDependency = nullptr,
const AZ::Uuid* expectedProductDependency = nullptr)
{
AssetBuilderSDK::ProductPathDependencySet expectedPathDependencies;
if (expectedPathDependency)
{
expectedPathDependencies.emplace(*expectedPathDependency);
}
AZStd::vector<AZ::Uuid> expectedProductDependencies;
if (expectedProductDependency)
{
expectedProductDependencies.push_back(*expectedProductDependency);
}
TestSuccessCase(exportProduct, expectedPathDependencies, expectedProductDependencies);
}
void TestSuccessCaseNoDependencies(const SceneAPI::Events::ExportProduct& exportProduct)
{
AssetBuilderSDK::ProductPathDependencySet expectedPathDependencies;
AZStd::vector<AZ::Uuid> expectedProductDependencies;
TestSuccessCase(exportProduct, expectedPathDependencies, expectedProductDependencies);
}
AzToolsFramework::ToolsApplication m_app;
const char* m_workingDirectory = nullptr;
};
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_NoDependencies)
{
SceneAPI::Events::ExportProduct exportProduct("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), u8(0), AZStd::nullopt);
TestSuccessCaseNoDependencies(exportProduct);
}
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_PathDependencyOnSourceAsset)
{
#if AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
const char* absolutePathToFile = "C:/some/test/file.mtl";
#else
const char* absolutePathToFile = "/some/test/file.mtl";
#endif // AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
AssetBuilderSDK::ProductPathDependency expectedPathDependency(absolutePathToFile, AssetBuilderSDK::ProductPathDependencyType::SourceFile);
SceneAPI::Events::ExportProduct product("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), u8(0), AZStd::nullopt);
product.m_legacyPathDependencies.push_back(absolutePathToFile);
TestSuccessCase(product, &expectedPathDependency);
}
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_PathDependencyOnProductAsset)
{
const char* relativeDependencyPathToFile = "some/test/file.mtl";
AssetBuilderSDK::ProductPathDependency expectedPathDependency(relativeDependencyPathToFile, AssetBuilderSDK::ProductPathDependencyType::ProductFile);
SceneAPI::Events::ExportProduct product("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), u8(0), AZStd::nullopt);
product.m_legacyPathDependencies.push_back(relativeDependencyPathToFile);
TestSuccessCase(product, &expectedPathDependency);
}
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_PathDependencyOnSourceAndProductAsset)
{
const char* relativeDependencyPathToFile = "some/test/file.mtl";
#if AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
const char* absolutePathToFile = "C:/some/test/file.mtl";
#else
const char* absolutePathToFile = "/some/test/file.mtl";
#endif // AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
SceneAPI::Events::ExportProduct exportProduct("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), u8(0), AZStd::nullopt);
exportProduct.m_legacyPathDependencies.push_back(absolutePathToFile);
exportProduct.m_legacyPathDependencies.push_back(relativeDependencyPathToFile);
AssetBuilderSDK::ProductPathDependencySet expectedPathDependencies = {
{absolutePathToFile, AssetBuilderSDK::ProductPathDependencyType::SourceFile},
{relativeDependencyPathToFile, AssetBuilderSDK::ProductPathDependencyType::ProductFile}
};
TestSuccessCase(exportProduct, expectedPathDependencies, {});
}
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_ProductDependency)
{
AZ::Uuid dependencyId = AZ::Uuid::CreateRandom();
SceneAPI::Events::ExportProduct exportProduct("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), AZ::u8(0), AZStd::nullopt);
exportProduct.m_productDependencies.push_back(SceneAPI::Events::ExportProduct("testDependencyFile", dependencyId, AZ::Data::AssetType::CreateNull(), AZ::u8(0), AZStd::nullopt));
TestSuccessCase(exportProduct, nullptr, &dependencyId);
}
TEST_F(SceneBuilderTests, SceneBuilderWorker_ExportProductDependencies_ProductAndPathDependencies)
{
AZ::Uuid dependencyId = AZ::Uuid::CreateRandom();
SceneAPI::Events::ExportProduct exportProduct("testExportFile", AZ::Uuid::CreateRandom(), AZ::Data::AssetType::CreateNull(), AZ::u8(0), AZStd::nullopt);
exportProduct.m_productDependencies.push_back(SceneAPI::Events::ExportProduct("testDependencyFile", dependencyId, AZ::Data::AssetType::CreateNull(), AZ::u8(0), AZStd::nullopt));
const char* relativeDependencyPathToFile = "some/test/file.mtl";
#if AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
const char* absolutePathToFile = "C:/some/test/file.mtl";
#else
const char* absolutePathToFile = "/some/test/file.mtl";
#endif // AZ_TRAIT_OS_USE_WINDOWS_FILE_PATHS
exportProduct.m_legacyPathDependencies.push_back(absolutePathToFile);
exportProduct.m_legacyPathDependencies.push_back(relativeDependencyPathToFile);
AssetBuilderSDK::ProductPathDependencySet expectedPathDependencies = {
{absolutePathToFile, AssetBuilderSDK::ProductPathDependencyType::SourceFile},
{relativeDependencyPathToFile, AssetBuilderSDK::ProductPathDependencyType::ProductFile}
};
TestSuccessCase(exportProduct, expectedPathDependencies, { dependencyId });
}
struct ImportHandler
: SceneAPI::Events::AssetImportRequestBus::Handler
{
ImportHandler()
{
BusConnect();
}
~ImportHandler() override
{
BusDisconnect();
}
void GetManifestDependencyPaths(AZStd::vector<AZStd::string>& paths) override
{
paths.emplace_back("/scriptFilename");
paths.emplace_back("/layer1/layer2/0/target");
}
void GetManifestExtension(AZStd::string& result) override
{
result = ".test";
}
void GetGeneratedManifestExtension(AZStd::string& result) override
{
result = ".test.gen";
}
};
using SourceDependencyTests = UnitTest::ScopedAllocatorSetupFixture;
namespace SourceDependencyJson
{
constexpr const char* TestJson = R"JSON(
{
"values": [
{
"$type": "Test1",
"scriptFilename": "a/test/path.png"
},
{
"$type": "Test2",
"layer1" : {
"layer2" : [
{
"target": "value.png",
"otherData": "value2.png"
},
{
"target" : "wrong.png"
}
]
}
}
]
}
)JSON";
}
TEST_F(SourceDependencyTests, SourceDependencyTest)
{
ImportHandler handler;
AZStd::vector<AssetBuilderSDK::SourceFileDependency> dependencies;
SceneBuilderWorker::PopulateSourceDependencies(SourceDependencyJson::TestJson, dependencies);
ASSERT_EQ(dependencies.size(), 2);
ASSERT_STREQ(dependencies[0].m_sourceFileDependencyPath.c_str(), "a/test/path.png");
ASSERT_STREQ(dependencies[1].m_sourceFileDependencyPath.c_str(), "value.png");
}
struct SourceDependencyMockedIOTests : UnitTest::ScopedAllocatorSetupFixture
, UnitTest::SetRestoreFileIOBaseRAII
{
SourceDependencyMockedIOTests()
: UnitTest::SetRestoreFileIOBaseRAII(m_ioMock)
{
}
void SetUp() override
{
using namespace ::testing;
ON_CALL(m_ioMock, Open(_, _, _))
.WillByDefault(Invoke(
[](auto, auto, IO::HandleType& handle)
{
handle = 1234;
return AZ::IO::Result(AZ::IO::ResultCode::Success);
}));
ON_CALL(m_ioMock, Size(An<AZ::IO::HandleType>(), _)).WillByDefault(Invoke([](auto, AZ::u64& size)
{
size = strlen(SourceDependencyJson::TestJson);
return AZ::IO::ResultCode::Success;
}));
EXPECT_CALL(m_ioMock, Read(_, _, _, _, _))
.WillRepeatedly(Invoke(
[](auto, void* buffer, auto, auto, AZ::u64* bytesRead)
{
memcpy(buffer, SourceDependencyJson::TestJson, strlen(SourceDependencyJson::TestJson));
*bytesRead = strlen(SourceDependencyJson::TestJson);
return AZ::IO::ResultCode::Success;
}));
EXPECT_CALL(m_ioMock, Close(_)).WillRepeatedly(Return(AZ::IO::ResultCode::Success));
}
IO::NiceFileIOBaseMock m_ioMock;
};
TEST_F(SourceDependencyMockedIOTests, RegularManifestHasPriority)
{
ImportHandler handler;
MockSettingsRegistry settingsRegistry;
SettingsRegistry::Register(&settingsRegistry);
using FixedValueString = AZ::SettingsRegistryInterface::FixedValueString;
auto MockGetFixedStringCall = [](FixedValueString& result, AZStd::string_view) -> bool
{
result = "cache";
return true;
};
ON_CALL(settingsRegistry, Get(::testing::An<FixedValueString&>(), ::testing::_)).WillByDefault(MockGetFixedStringCall);
AssetBuilderSDK::CreateJobsRequest request;
AssetBuilderSDK::CreateJobsResponse response;
request.m_sourceFile = "file.fbx";
using namespace ::testing;
AZStd::string genPath = AZStd::string("cache").append(1, AZ_TRAIT_OS_PATH_SEPARATOR).append("file.fbx.test.gen");
EXPECT_CALL(m_ioMock, Exists(StrEq("file.fbx.test"))).WillRepeatedly(Return(true));
EXPECT_CALL(m_ioMock, Exists(StrEq(genPath.c_str()))).Times(Exactly(0));
ASSERT_TRUE(SceneBuilderWorker::ManifestDependencyCheck(request, response));
ASSERT_EQ(response.m_sourceFileDependencyList.size(), 2);
SettingsRegistry::Unregister(&settingsRegistry);
}
TEST_F(SourceDependencyMockedIOTests, GeneratedManifestTest)
{
ImportHandler handler;
MockSettingsRegistry settingsRegistry;
SettingsRegistry::Register(&settingsRegistry);
using FixedValueString = AZ::SettingsRegistryInterface::FixedValueString;
auto MockGetFixedStringCall = [](FixedValueString& result, AZStd::string_view) -> bool
{
result = "cache";
return true;
};
ON_CALL(settingsRegistry, Get(::testing::An<FixedValueString&>(), ::testing::_)).WillByDefault(MockGetFixedStringCall);
AssetBuilderSDK::CreateJobsRequest request;
AssetBuilderSDK::CreateJobsResponse response;
request.m_sourceFile = "file.fbx";
using namespace ::testing;
AZStd::string genPath = AZStd::string("cache").append(1, AZ_TRAIT_OS_PATH_SEPARATOR).append("file.fbx.test.gen");
EXPECT_CALL(m_ioMock, Exists(StrEq("file.fbx.test"))).WillRepeatedly(Return(false));
EXPECT_CALL(m_ioMock, Exists(StrEq(genPath.c_str()))).WillRepeatedly(Return(true));
ASSERT_TRUE(SceneBuilderWorker::ManifestDependencyCheck(request, response));
ASSERT_EQ(response.m_sourceFileDependencyList.size(), 2);
SettingsRegistry::Unregister(&settingsRegistry);
}