/* * All or portions of this file Copyright (c) Amazon.com, Inc. or its affiliates or * its licensors. * * For complete copyright and license terms please see the LICENSE at the root of this * distribution (the "License"). All use of this software is governed by the License, * or, if provided, by the license below or the license accompanying this file. Do not * remove or modify any license notices. This file is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * */ #include #include #include #include #include #include #include namespace UnitTest { class TestApplication : public AzFramework::Application { public: // ComponentApplication void SetSettingsRegistrySpecializations(AZ::SettingsRegistryInterface::Specializations& specializations) override { Application::SetSettingsRegistrySpecializations(specializations); specializations.Append("test"); specializations.Append("spawnable"); } }; // Test component that has a reference to a different entity for use in validating per-instance entity id fixups. class ComponentWithEntityReference : public AZ::Component { public: AZ_COMPONENT(ComponentWithEntityReference, "{CF5FDE59-86E5-40B6-9272-BBC1C4AFD061}"); void Activate() override { } void Deactivate() override { } static void Reflect(AZ::ReflectContext* reflection) { if (auto* serializeContext = azrtti_cast(reflection)) { serializeContext->Class() ->Field("EntityReference", &ComponentWithEntityReference::m_entityReference) ; } } AZ::EntityId m_entityReference; }; class SpawnableEntitiesManagerTest : public AllocatorsFixture { public: void SetUp() override { AllocatorsFixture::SetUp(); m_application = new TestApplication(); AZ::ComponentApplication::Descriptor descriptor; m_application->Start(descriptor); m_application->RegisterComponentDescriptor(ComponentWithEntityReference::CreateDescriptor()); // Without this, the user settings component would attempt to save on finalize/shutdown. Since the file is // shared across the whole engine, if multiple tests are run in parallel, the saving could cause a crash // in the unit tests. AZ::UserSettingsComponentRequestBus::Broadcast(&AZ::UserSettingsComponentRequests::DisableSaveOnFinalize); m_spawnable = aznew AzFramework::Spawnable( AZ::Data::AssetId::CreateString("{EB2E8A2B-F253-4A90-BBF4-55F2EED786B8}:0"), AZ::Data::AssetData::AssetStatus::Ready); m_spawnableAsset = new AZ::Data::Asset(m_spawnable, AZ::Data::AssetLoadBehavior::Default); m_ticket = new AzFramework::EntitySpawnTicket(*m_spawnableAsset); auto managerInterface = AzFramework::SpawnableEntitiesInterface::Get(); m_manager = azrtti_cast(managerInterface); } void TearDown() override { delete m_ticket; m_ticket = nullptr; // One more tick on the spawnable entities manager in order to delete the ticket fully. while (m_manager->ProcessQueue( AzFramework::SpawnableEntitiesManager::CommandQueuePriority::High | AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular) != AzFramework::SpawnableEntitiesManager::CommandQueueStatus::NoCommandsLeft) ; delete m_spawnableAsset; m_spawnableAsset = nullptr; // This will also delete m_spawnable. delete m_application; m_application = nullptr; AllocatorsFixture::TearDown(); } void FillSpawnable(size_t numElements) { AzFramework::Spawnable::EntityList& entities = m_spawnable->GetEntities(); entities.clear(); entities.reserve(numElements); for (size_t i=0; i()); } } void CreateRecursiveHierarchy() { AzFramework::Spawnable::EntityList& entities = m_spawnable->GetEntities(); size_t numElements = entities.size(); AZ::EntityId parent; for (size_t i=0; i& entity = entities[i]; auto component = entity->CreateComponent(); if (i > 0) { component->SetParent(parent); } parent = entity->GetId(); } } void CreateSingleParent() { AzFramework::Spawnable::EntityList& entities = m_spawnable->GetEntities(); size_t numElements = entities.size(); if (numElements > 0) { AZ::EntityId parent = entities[0]->GetId(); for (size_t i = 0; i < numElements; ++i) { AZStd::unique_ptr& entity = entities[i]; auto component = entity->CreateComponent(); if (i > 0) { component->SetParent(parent); } } } } enum class EntityReferenceScheme { AllReferenceFirst, AllReferenceLast, AllReferenceThemselves, AllReferenceNextCircular, AllReferencePreviousCircular }; void CreateEntityReferences(EntityReferenceScheme refScheme) { AzFramework::Spawnable::EntityList& entities = m_spawnable->GetEntities(); size_t numElements = entities.size(); for (size_t i = 0; i < numElements; ++i) { AZStd::unique_ptr& entity = entities[i]; auto component = entity->CreateComponent(); switch (refScheme) { case EntityReferenceScheme::AllReferenceFirst : component->m_entityReference = entities[0]->GetId(); break; case EntityReferenceScheme::AllReferenceLast: component->m_entityReference = entities[numElements - 1]->GetId(); break; case EntityReferenceScheme::AllReferenceThemselves: component->m_entityReference = entities[i]->GetId(); break; case EntityReferenceScheme::AllReferenceNextCircular: component->m_entityReference = entities[(i + 1) % numElements]->GetId(); break; case EntityReferenceScheme::AllReferencePreviousCircular: component->m_entityReference = entities[(i + numElements - 1) % numElements]->GetId(); break; } } } // Verify that the entity references are pointing to the correct other entities within the same spawn batch. // A "spawn batch" is the set of entities produced for each SpawnAllEntities command. void ValidateEntityReferences( EntityReferenceScheme refScheme, size_t entitiesPerBatch, AzFramework::SpawnableConstEntityContainerView entities) { size_t numElements = entities.size(); for (size_t i = 0; i < numElements; ++i) { // Calculate the element offset that's the start of each batch of entities spawned. size_t curSpawnBatch = i / entitiesPerBatch; size_t curBatchOffset = curSpawnBatch * entitiesPerBatch; size_t curBatchIndex = i - curBatchOffset; const AZ::Entity* const entity = *(entities.begin() + i); auto component = entity->FindComponent(); ASSERT_NE(nullptr, component); AZ::EntityId comparisonId; // Ids should be local to a batch, so each of these will be compared within a batch of entities, not globally across // the entire set. switch (refScheme) { case EntityReferenceScheme::AllReferenceFirst: // Compare against the first entity in each batch comparisonId = (*(entities.begin() + curBatchOffset))->GetId(); break; case EntityReferenceScheme::AllReferenceLast: // Compare against the last entity in each batch comparisonId = (*(entities.begin() + curBatchOffset + (entitiesPerBatch - 1)))->GetId(); break; case EntityReferenceScheme::AllReferenceThemselves: // Compare against itself comparisonId = entity->GetId(); break; case EntityReferenceScheme::AllReferenceNextCircular: // Compare against the next entity in each batch, looping around so that the last entity in the batch should refer // to the first entity in the batch. comparisonId = (*(entities.begin() + curBatchOffset + ((curBatchIndex + 1) % entitiesPerBatch)))->GetId(); break; case EntityReferenceScheme::AllReferencePreviousCircular: // Compare against the previous entity in each batch, looping around so that the first entity in the batch should refer // to the last entity in the batch. comparisonId = (*(entities.begin() + curBatchOffset + ((curBatchIndex + numElements - 1) % entitiesPerBatch)))->GetId(); break; } EXPECT_EQ(comparisonId, component->m_entityReference); } }; protected: AZ::Data::Asset* m_spawnableAsset { nullptr }; AzFramework::SpawnableEntitiesManager* m_manager { nullptr }; AzFramework::EntitySpawnTicket* m_ticket { nullptr }; AzFramework::Spawnable* m_spawnable { nullptr }; TestApplication* m_application { nullptr }; }; // // SpawnAllEntitities // TEST_F(SpawnableEntitiesManagerTest, SpawnAllEntities_Call_AllEntitiesSpawned) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); size_t spawnedEntitiesCount = 0; auto callback = [&spawnedEntitiesCount](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { spawnedEntitiesCount += entities.size(); }; AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_EQ(NumEntities, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, SpawnAllEntities_SetParentOnSpawnedEntities_LineageIsPreserved) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateRecursiveHierarchy(); auto callback = [](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { AZ::EntityId parentId; bool isFirst = true; for (const AZ::Entity* entity : entities) { if (!isFirst) { auto transform = entity->GetTransform(); ASSERT_NE(nullptr, transform); EXPECT_EQ(parentId, transform->GetParentId()); } else { isFirst = false; } parentId = entity->GetId(); } }; AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnAllEntities_AllEntitiesReferenceOtherEntities_EntityIdsAreMappedCorrectly) { // This tests that entity id references get mapped correctly in a SpawnAllEntities call whether they're forward referencing // in the list, backwards referencing, or self-referencing. The circular tests are to ensure the implementation works regardless // of entity ordering. for (EntityReferenceScheme refScheme : { EntityReferenceScheme::AllReferenceFirst, EntityReferenceScheme::AllReferenceLast, EntityReferenceScheme::AllReferenceThemselves, EntityReferenceScheme::AllReferenceNextCircular, EntityReferenceScheme::AllReferencePreviousCircular }) { constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ValidateEntityReferences(refScheme, NumEntities, entities); }; AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } } TEST_F(SpawnableEntitiesManagerTest, SpawnAllEntities_AllEntitiesReferenceOtherEntities_EntityIdsOnlyReferWithinASingleCall) { // This tests that entity id references get mapped correctly with multiple SpawnAllEntities calls. Each call should only map // the entities to other entities within the same call, regardless of forward or backward mapping. // For example, suppose entities 1, 2, and 3 refer to 4. In the first SpawnAllEntities call, entities 1-3 will refer to 4. // In the second SpawnAllEntities call, entities 1-3 will refer to the second 4, not the previously-spawned 4. for (EntityReferenceScheme refScheme : { EntityReferenceScheme::AllReferenceFirst, EntityReferenceScheme::AllReferenceLast, EntityReferenceScheme::AllReferenceThemselves, EntityReferenceScheme::AllReferenceNextCircular, EntityReferenceScheme::AllReferencePreviousCircular }) { // Make sure we start with a fresh ticket each time, or else each iteration through this loop would continue to build up // more and more entities. delete m_ticket; m_ticket = new AzFramework::EntitySpawnTicket(*m_spawnableAsset); constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ValidateEntityReferences(refScheme, NumEntities, entities); }; // Spawn twice. constexpr size_t NumSpawnAllCalls = 2; for (int spawns = 0; spawns < NumSpawnAllCalls; spawns++) { AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); } m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } } TEST_F(SpawnableEntitiesManagerTest, SpawnAllEntities_DeleteTicketBeforeCall_NoCrash) { { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->SpawnAllEntities(ticket); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // SpawnEntities // TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_Call_AllEntitiesSpawned) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); AZStd::vector indices = { 0, 2, 3, 1 }; size_t spawnedEntitiesCount = 0; auto callback = [&spawnedEntitiesCount](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { spawnedEntitiesCount += entities.size(); }; AzFramework::SpawnEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnEntities(*m_ticket, AZStd::move(indices), AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_EQ(NumEntities, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_SpawnTheSameEntity_AllEntitiesSpawned) { static constexpr size_t NumEntities = 1; FillSpawnable(NumEntities); AZStd::vector indices = { 0, 0 }; size_t spawnedEntitiesCount = 0; auto callback = [&spawnedEntitiesCount](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { spawnedEntitiesCount += entities.size(); }; AzFramework::SpawnEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnEntities(*m_ticket, AZStd::move(indices), AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_EQ(NumEntities * 2, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_MultipleSpawns_AllEntitiesSpawned) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); AZStd::vector indices = { 0, 2, 3, 1 }; size_t spawnedEntitiesCount = 0; auto callback = [&spawnedEntitiesCount](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { spawnedEntitiesCount += entities.size(); }; AzFramework::SpawnEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); m_manager->SpawnEntities(*m_ticket, indices, optionalArgs); m_manager->SpawnEntities(*m_ticket, AZStd::move(indices), AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_EQ(NumEntities * 2, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_ReferencesAreRemappedForNewBatch_AllPointToLatestParent) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateSingleParent(); AZStd::vector indices = { 0, 1, 2, 3 }; AZStd::vector parents; auto callback = [&parents](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { AZ::EntityId parent = (*entities.begin())->GetId(); parents.push_back(parent); auto it = entities.begin(); ++it; // Skip the first as that is the parent. for (; it != entities.end(); ++it) { AZ::TransformInterface* transform = (*it)->GetTransform(); ASSERT_NE(nullptr, transform); ASSERT_EQ(parent, transform->GetParentId()); } }; AzFramework::SpawnEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); optionalArgs.m_referencePreviouslySpawnedEntities = false; m_manager->SpawnEntities(*m_ticket, indices, optionalArgs); m_manager->SpawnEntities(*m_ticket, AZStd::move(indices), AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_NE(parents[0], parents[1]); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_ReferencesAreRemappedForContinuedBatch_AllPointToLatestParent) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateSingleParent(); AZStd::vector indices = { 0, 1, 2, 3 }; AZStd::vector parents; auto callback = [&parents](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { AZ::EntityId parent = (*entities.begin())->GetId(); parents.push_back(parent); auto it = entities.begin(); ++it; // Skip the first as that is the parent. for (; it!=entities.end(); ++it) { AZ::TransformInterface* transform = (*it)->GetTransform(); ASSERT_NE(nullptr, transform); ASSERT_EQ(parent, transform->GetParentId()); } }; AzFramework::SpawnEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(callback); optionalArgs.m_referencePreviouslySpawnedEntities = true; m_manager->SpawnEntities(*m_ticket, indices, optionalArgs); m_manager->SpawnEntities(*m_ticket, AZStd::move(indices), AZStd::move(optionalArgs)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_NE(parents[0], parents[1]); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_ReferencesAreRemappedAcrossBatches_AllPointToLatestParent) { FillSpawnable(4); CreateSingleParent(); // Spawn a regular batch but with two parents and store the id of the last entity. This will the parent for the next batch. AZ::EntityId parent; auto getParent = [&parent](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ASSERT_NE(entities.begin(), entities.end()); parent = (*AZStd::prev(entities.end()))->GetId(); }; AzFramework::SpawnEntitiesOptionalArgs optionalArgsFirstBatch; optionalArgsFirstBatch.m_completionCallback = AZStd::move(getParent); optionalArgsFirstBatch.m_referencePreviouslySpawnedEntities = true; m_manager->SpawnEntities(*m_ticket, {0, 1, 2, 3, 0}, AZStd::move(optionalArgsFirstBatch)); // Next, spawn all the entities that have a reference to the parent that was just stored. auto parentCheck = [&parent](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { for (auto& it : entities) { AZ::TransformInterface* transform = it->GetTransform(); ASSERT_NE(nullptr, transform); ASSERT_EQ(parent, transform->GetParentId()); } }; AzFramework::SpawnEntitiesOptionalArgs optionalArgsSecondBatch; optionalArgsSecondBatch.m_completionCallback = AZStd::move(parentCheck); optionalArgsSecondBatch.m_referencePreviouslySpawnedEntities = true; m_manager->SpawnEntities(*m_ticket, {1, 2, 3}, AZStd::move(optionalArgsSecondBatch)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_AllEntitiesReferenceOtherEntities_ForwardReferencesWorkInSingleCall) { constexpr EntityReferenceScheme refScheme = EntityReferenceScheme::AllReferenceNextCircular; constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ValidateEntityReferences(refScheme, NumEntities, entities); }; // Verify that by default, entities that refer to other entities that haven't been spawned yet have the correct references // when the spawning all occurs in the same call m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3 }); m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_AllEntitiesReferenceOtherEntities_ForwardReferencesWorkAcrossCalls) { constexpr EntityReferenceScheme refScheme = EntityReferenceScheme::AllReferenceNextCircular; constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ValidateEntityReferences(refScheme, NumEntities, entities); }; // Verify that by default, entities that refer to other entities that haven't been spawned yet have the correct references // even when the spawning is across multiple calls m_manager->SpawnEntities(*m_ticket, { 0 }); m_manager->SpawnEntities(*m_ticket, { 1 }); m_manager->SpawnEntities(*m_ticket, { 2 }); m_manager->SpawnEntities(*m_ticket, { 3 }); m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_AllEntitiesReferenceOtherEntities_ReferencesPointToFirstOrLatest) { // With SpawnEntities, entity references should either refer to the first entity that *will* be spawned, or the last entity // that *has* been spawned. This test will create entities 0 1 2 3 that all refer to entity 3, and it will create two batches // of those. In the first batch, they'll forward-reference. In the second batch, they should backward-reference, except for // the second entity 3, which will now refer to itself as the last one that's been spawned. constexpr EntityReferenceScheme refScheme = EntityReferenceScheme::AllReferenceLast; constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { size_t numElements = entities.size(); for (size_t i = 0; i < numElements; ++i) { const AZ::Entity* const entity = *(entities.begin() + i); auto component = entity->FindComponent(); ASSERT_NE(nullptr, component); AZ::EntityId comparisonId; if (i < (numElements - 1)) { // There are two batches of NumEntities elements. Every entity should either forward-reference or backward-reference // to the last entity of the first batch, except for the very last entity of the second batch, which should reference // itself. comparisonId = (*(entities.begin() + (NumEntities- 1)))->GetId(); } else { // The very last entity of the second batch should reference itself because it's now the latest instance of that // entity to be spawned. comparisonId = entity->GetId(); } EXPECT_EQ(comparisonId, component->m_entityReference); } }; // Create 2 batches of forward references. In the first batch, entities 0 1 2 will point forward to 3. In the second batch, // entities 0 1 2 will point *backward* to the first 3, and the second entity 3 will point to itself. m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3 }); m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3 }); m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_AllEntitiesReferenceOtherEntities_MultipleSpawnsInSameCallReferenceCorrectly) { // With SpawnEntities, entity references should either refer to the first entity that *will* be spawned, or the last entity // that *has* been spawned. This test will create entities 0 1 2 3 that all refer to entity 3, and it will create three sets // of those in the same call, with the following results: // - The first 0 1 2 will forward-reference to the first 3 // - The first 3 will reference itself // - The second 0 1 2 will backwards-reference to the first 3 // - The second 3 will reference itself // - The third 0 1 2 will backwards-reference to the second 3 // - The third 3 will reference itself constexpr EntityReferenceScheme refScheme = EntityReferenceScheme::AllReferenceLast; constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { size_t numElements = entities.size(); for (size_t i = 0; i < numElements; ++i) { const AZ::Entity* const entity = *(entities.begin() + i); auto component = entity->FindComponent(); ASSERT_NE(nullptr, component); AZ::EntityId comparisonId; if (i < ((NumEntities * 2) - 1)) { // The first 7 entities (0 1 2 3 0 1 2) will all refer to the 4th one (1st '3'). comparisonId = (*(entities.begin() + (NumEntities - 1)))->GetId(); } else if (i < (numElements - 1)) { // The next 4 entities (3 0 1 2) will all refer to the 8th one (2nd '3'). comparisonId = (*(entities.begin() + ((NumEntities * 2) - 1)))->GetId(); } else { // The very last entity (3) will reference itself (3rd '3'). comparisonId = entity->GetId(); } EXPECT_EQ(comparisonId, component->m_entityReference); } }; // Create the 3 batches of entities 0, 1, 2, 3. The entity references should work as described at the top of the test. m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3 }); m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_AllEntitiesReferenceOtherEntities_OptionalFlagClearsReferenceMap) { constexpr EntityReferenceScheme refScheme = EntityReferenceScheme::AllReferenceLast; constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); CreateEntityReferences(refScheme); auto callback = [this, refScheme, NumEntities](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { ValidateEntityReferences(refScheme, NumEntities, entities); }; // By setting the "referencePreviouslySpawnedEntities" flag to false, the map will get cleared on each call, so in both batches // the entities will forward-reference to the last entity in the batch. If the flag were true, entities 0 1 2 in the second // batch would refer backwards to the first entity 3. AzFramework::SpawnEntitiesOptionalArgs optionalArgsSecondBatch; optionalArgsSecondBatch.m_completionCallback = AZStd::move(callback); optionalArgsSecondBatch.m_referencePreviouslySpawnedEntities = false; m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3 }, optionalArgsSecondBatch); m_manager->SpawnEntities(*m_ticket, { 0, 1, 2, 3 }, AZStd::move(optionalArgsSecondBatch)); m_manager->ListEntities(*m_ticket, callback); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } TEST_F(SpawnableEntitiesManagerTest, SpawnEntities_DeleteTicketBeforeCall_NoCrash) { { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->SpawnEntities(ticket, {/* Deliberate empty list of indices. */}); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // DespawnAllEntities // TEST_F(SpawnableEntitiesManagerTest, DespawnAllEntities_DeleteTicketBeforeCall_NoCrash) { { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->DespawnAllEntities(ticket); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // ReloadSpawnable // TEST_F(SpawnableEntitiesManagerTest, ReloadSpawnable_DeleteTicketBeforeCall_NoCrash) { { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->ReloadSpawnable(ticket, *m_spawnableAsset); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // ListEntitities // TEST_F(SpawnableEntitiesManagerTest, ListEntities_Call_AllEntitiesAreReported) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); bool allValidEntityIds = true; size_t spawnedEntitiesCount = 0; auto callback = [&allValidEntityIds, &spawnedEntitiesCount] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView entities) { for (auto&& entity : entities) { allValidEntityIds = entity->GetId().IsValid() && allValidEntityIds; } spawnedEntitiesCount += entities.size(); }; m_manager->SpawnAllEntities(*m_ticket); m_manager->ListEntities(*m_ticket, AZStd::move(callback)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_TRUE(allValidEntityIds); EXPECT_EQ(NumEntities, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, ListEntities_DeleteTicketBeforeCall_NoCrash) { auto callback = [](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView) {}; { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->ListEntities(ticket, AZStd::move(callback)); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // ListIndicesAndEntities // TEST_F(SpawnableEntitiesManagerTest, ListIndicesAndEntities_Call_AllEntitiesAreReportedAndIncrementByOne) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); bool allValidEntityIds = true; size_t spawnedEntitiesCount = 0; auto callback = [&allValidEntityIds, &spawnedEntitiesCount] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstIndexEntityContainerView entities) { for (auto&& indexEntityPair : entities) { // Since all entities are spawned a single time, the indices should be 0..NumEntities. if (indexEntityPair.GetIndex() == spawnedEntitiesCount) { spawnedEntitiesCount++; } allValidEntityIds = indexEntityPair.GetEntity()->GetId().IsValid() && allValidEntityIds; } }; m_manager->SpawnAllEntities(*m_ticket); m_manager->ListIndicesAndEntities(*m_ticket, AZStd::move(callback)); m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_TRUE(allValidEntityIds); EXPECT_EQ(NumEntities, spawnedEntitiesCount); } TEST_F(SpawnableEntitiesManagerTest, ListIndicesAndEntities_DeleteTicketBeforeCall_NoCrash) { auto callback = [](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstIndexEntityContainerView) {}; { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->ListIndicesAndEntities(ticket, AZStd::move(callback)); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // ClaimEntities // TEST_F(SpawnableEntitiesManagerTest, ClaimEntities_DeleteTicketBeforeCall_NoCrash) { auto callback = [](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableEntityContainerView) {}; { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->ClaimEntities(ticket, AZStd::move(callback)); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // Barrier // TEST_F(SpawnableEntitiesManagerTest, Barrier_DeleteTicketBeforeCall_NoCrash) { auto callback = [](AzFramework::EntitySpawnTicket::Id) {}; { AzFramework::EntitySpawnTicket ticket(*m_spawnableAsset); m_manager->Barrier(ticket, AZStd::move(callback)); } m_manager->ProcessQueue(AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); } // // Misc. - Priority tests // TEST_F(SpawnableEntitiesManagerTest, Priority_HighBeforeDefault_HigherPriorityCallHappensBeforeDefaultPriorityEvenWhenQueuedLater) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); AzFramework::EntitySpawnTicket highPriorityTicket(*m_spawnableAsset); size_t callCounter = 1; size_t highPriorityCallId = 0; size_t defaultPriorityCallId = 0; auto highCallback = [&callCounter, &highPriorityCallId] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView) { highPriorityCallId = callCounter++; }; auto defaultCallback = [&callCounter, &defaultPriorityCallId] (AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView) { defaultPriorityCallId = callCounter++; }; AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(defaultCallback); optionalArgs.m_priority = AzFramework::SpawnablePriority_Default; m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); AzFramework::SpawnAllEntitiesOptionalArgs highPriortyOptionalArgs; highPriortyOptionalArgs.m_completionCallback = AZStd::move(highCallback); highPriortyOptionalArgs.m_priority = AzFramework::SpawnablePriority_High; m_manager->SpawnAllEntities(highPriorityTicket, AZStd::move(highPriortyOptionalArgs)); m_manager->ProcessQueue( AzFramework::SpawnableEntitiesManager::CommandQueuePriority::High | AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_LT(highPriorityCallId, defaultPriorityCallId); } TEST_F(SpawnableEntitiesManagerTest, Priority_SameTicket_DefaultPriorityCallHappensBeforeHighPriority) { static constexpr size_t NumEntities = 4; FillSpawnable(NumEntities); size_t callCounter = 1; size_t highPriorityCallId = 0; size_t defaultPriorityCallId = 0; auto highCallback = [&callCounter, &highPriorityCallId](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView) { highPriorityCallId = callCounter++; }; auto defaultCallback = [&callCounter, &defaultPriorityCallId](AzFramework::EntitySpawnTicket::Id, AzFramework::SpawnableConstEntityContainerView) { defaultPriorityCallId = callCounter++; }; AzFramework::SpawnAllEntitiesOptionalArgs optionalArgs; optionalArgs.m_completionCallback = AZStd::move(defaultCallback); optionalArgs.m_priority = AzFramework::SpawnablePriority_Default; m_manager->SpawnAllEntities(*m_ticket, AZStd::move(optionalArgs)); AzFramework::SpawnAllEntitiesOptionalArgs highPriortyOptionalArgs; highPriortyOptionalArgs.m_completionCallback = AZStd::move(highCallback); highPriortyOptionalArgs.m_priority = AzFramework::SpawnablePriority_High; m_manager->SpawnAllEntities(*m_ticket, AZStd::move(highPriortyOptionalArgs)); m_manager->ProcessQueue( AzFramework::SpawnableEntitiesManager::CommandQueuePriority::High | AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); // Run a second time as the high priority task will be pending at this point. m_manager->ProcessQueue( AzFramework::SpawnableEntitiesManager::CommandQueuePriority::High | AzFramework::SpawnableEntitiesManager::CommandQueuePriority::Regular); EXPECT_LT(defaultPriorityCallId, highPriorityCallId); } } // namespace UnitTest