6f8afd69d4
Merge pull request #4372 from aws-lumberyard-dev/daimini/4364/restore-layout-fix
...
Editor crashes after changing the layout when the Prefab system is enabled
2021-09-28 14:20:37 -05:00
e958b0e09c
No longer can instantiate prefabs in an empty level ( #4277 )
...
* No longer can instantiate prefabs in an empty level
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* PR feedback from Ram
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* removing tab
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* PR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Implement Project Manager 'build' button for Mac and Linux(#4248 )
Signed-off-by: Steve Pham <spham@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove the PrefabEditManager. Introduce the FocusMode system on the Editor side, and a PrefabFocusHandler on the Prefab side to handle focus.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Changed FocusOnOwningPrefab to return Outcome. Added comments and error checking.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove assert for edge case that can actually happen in normal circumstances, simply return false in those cases.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove nested FocusModeFramework namespace
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Minor fixes to variable names and comments.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* ClearFocusRoot implementation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Remove pragma once from cpp file
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix header formatting to pass validation
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Do not assert if m_focusModeInterface can't be initialized
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Initialization changes to pass unit tests. Some interfaces are now retrieved on demand and there's clearer failure paths that don't involve asserts to better handle test/headless initializations.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS (#4268 )
* LYN-6793 [iOS] [asset_profile] 4 assets fail to process for iOS
The issue was because the compression of ETC formats took too long.
Replaced all ETC and PVRTC formats with ASTC formats.
Update all pixel operation for formats with single R channel to align the change with R8.
Signed-off-by: Qing Tao <qingtao@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Use resize_no_construct when creating a buffer asset, since the initial data is going to be memcopy'd anyways. (#4249 )
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix a minor spelling mistake (#4247 )
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* 1. Update iOS deployment target to 14 (#4266 )
2. Set MacOS default deployment target to 11.
Signed-off-by: amzn-sj <srikkant@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Debug build clang fixes
Signed-off-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix failed 'server' platform assets on Linux related to Shaders (#4275 )
* Add missing 'server' platform identifier for the ShaderBuilder
* Use the current host platform as the fallback platform identifier (and not 'pc')
Signed-off-by: Steve Pham <spham@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* [development] Atom CPU profiler include cleanup (#4272 )
- Removed all unnecessary includes to Atom CpuProfiler.h
- Added includes to AzCore Profiler.h where necessary
Signed-off-by: AMZN-ScottR 24445312+AMZN-ScottR@users.noreply.github.com
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Add guard against edge case.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Expose Transform::CreateLookAt to behavior context to use with hydra tests
Signed-off-by: amzn-tommy <waltont@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Cached BLAS objects at the sub-mesh level
Signed-off-by: dmcdiar <dmcdiar@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* EMotion FX: Asset Processor generates an Actor for every FBX (#4284 )
Fixing the actor behavior to ignore actor asset generation for files that only contain nodes/bones. We're only checking for blend shapes and skins now. In case neither is present in an FBX, we don't export the actor asset.
This makes a plain skeleton a special case where users manually need to add the actor group for the fbx. The most common use case for these are animation files anyway, where we don't want to export actor assets.
Also increased the version number of the actor group so that they are all getting reprocessed and the unneeded actor assets get removed.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* EMotion FX: Crash in the actor builder when fbx meta data contains node groups (#4283 )
Fixing a crash related to the small array conversion that made multiple assets crash the actor builder.
Signed-off-by: Benjamin Jillich <jillich@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Project Manager Gem Dependencies (#4132 )
* Fix engine API change and add gem dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Add GemCatalog dependency test
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Clarify display name and fix missing const
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Moving a couple helper functions into private scope
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Update gem count when unselecting a gem #4074
This addresses the following issue https://github.com/o3de/o3de/issues/4074
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Active/Inactive filter and dependency tooltips
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Accessors for previously added and dependencies
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Cart displays gem dependency changes
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Shorten titles to fit in summary popup
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove QString::number
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove extra space
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Consolidate source model accesor helpers
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Addressing minor feedback
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
* Remove unused local variable
Signed-off-by: AMZN-alexpete <26804013+AMZN-alexpete@users.noreply.github.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fix AutoGen of RPCs with no params
Signed-off-by: puvvadar <puvvadar@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Adds Inspector to Gem Repo Screen (#4242 )
* Adds the gem repo screen with the UI built but with mocked data and not connected to the o3de scripts
Signed-off-by: nggieber <nggieber@amazon.com >
* Changed name of added to enabled, disabled define, removed unused functions
Signed-off-by: nggieber <nggieber@amazon.com >
* Added Repo Screen Inspector UI
Signed-off-by: nggieber <nggieber@amazon.com >
* Addressed minor PR feedback
Signed-off-by: nggieber <nggieber@amazon.com >
* Add some more minor PR changes
Signed-off-by: nggieber <nggieber@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Updated NetworkSpawnableHolderComponent to use TransformBus instead of FindComponent. Added dependency on TransformService
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Fixed Entity::GetTransform to work for the components of an activating entity. Made the cached transform lazy evaluated.
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Changed NetworkSpawnableHolderComponent to use Entity::GetTransform instead of an ebus call
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Moved local variable to a smaller scope
Signed-off-by: pereslav <pereslav@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Signed-off-by: LesaelR <LesaelR@amazon.com > (#4278 )
* Signed-off-by: LesaelR <LesaelR@amazon.com >
* Removing the un-needed sandbox marks.
Signed-off-by: LesaelR <LesaelR@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Small fix for color node tooltip to ask for values 0-1 instead of 0-255
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Exposing NetworkCharacterComponent::TryMoveWithVelocity to script. Updating Multiplayer AutoComponent baseclass behavior context to Reflect itself instead of its derived (human made) component. This is so the derived class can also create behaviorcontext classes of its own if needed. Misc copyright header edit.
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Make sure Multiplayer AutoComponents dont generate property OnChange script events if GenerateEventBindings is disabled
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Adding parameter names to NetworkCharacterComponent script events so people know what the parameters are used for in scriptcanvas
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Small fix to use AZ_CRC_CE
Signed-off-by: Gene Walters <genewalt@amazon.com >
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Disabling some tests when prefab mode is enabled
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "Disabling some tests when prefab mode is enabled"
This reverts commit 3fe9358d42ec9d7fa5ffaee458e4c6ca3ecbed6e.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "PR feedback"
This reverts commit a5b86d1954974b950b7719d1bc7dd56bc2a2a21b.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "removing tab"
This reverts commit ff6ef4bfb514d82a1b668baa95901ad363e648d0.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Revert "PR feedback from Ram"
This reverts commit cba7f9c2a114d3bb51c9b64f38a7e1fef7bb8fe8.
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* Renaming level->rootInstance
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
Co-authored-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com >
Co-authored-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
Co-authored-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com >
Co-authored-by: Tommy Walton <82672795+amzn-tommy@users.noreply.github.com >
Co-authored-by: SJ <srikkant@amazon.com >
Co-authored-by: AMZN-Olex <5432499+AMZN-Olex@users.noreply.github.com >
Co-authored-by: Scott Romero <24445312+AMZN-ScottR@users.noreply.github.com >
Co-authored-by: amzn-tommy <waltont@amazon.com >
Co-authored-by: dmcdiar <dmcdiar@amazon.com >
Co-authored-by: Benjamin Jillich <43751992+amzn-jillich@users.noreply.github.com >
Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com >
Co-authored-by: puvvadar <puvvadar@amazon.com >
Co-authored-by: AMZN-nggieber <52797929+AMZN-nggieber@users.noreply.github.com >
Co-authored-by: pereslav <pereslav@amazon.com >
Co-authored-by: LesaelR <89800757+LesaelR@users.noreply.github.com >
Co-authored-by: Gene Walters <genewalt@amazon.com >
2021-09-28 12:07:56 -07:00
a641586df2
Move FocusModeInterface retrieval to EntityOutlinerListModel constructor to prevent crash on widget refresh. Also force expansion of root on construction for the same reason.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-28 10:02:47 -07:00
1f6dfd0194
Asset Browser Search View Column Resizing ( #4087 )
...
* Added resizing
Signed-off-by: igarri <igarri@amazon.com >
* Added Signals and Slots for resizing columns
Signed-off-by: igarri <igarri@amazon.com >
* Cleaned up code
Signed-off-by: igarri <igarri@amazon.com >
* Fixed Column Resize when docking
Signed-off-by: igarri <igarri@amazon.com >
* Added constants
Signed-off-by: igarri <igarri@amazon.com >
* Applied Code review feedback
Signed-off-by: igarri <igarri@amazon.com >
* aplied more feedback
Signed-off-by: igarri <igarri@amazon.com >
* Addressed Code Review Comments
Signed-off-by: igarri <igarri@amazon.com >
* Fixing bad merge
Signed-off-by: igarri <igarri@amazon.com >
* Added fix in initialization
Signed-off-by: igarri <igarri@amazon.com >
* Changed header setup sequence
Signed-off-by: igarri <igarri@amazon.com >
2021-09-28 12:47:21 +01:00
7da866e81a
Update to how entity space is treated in the viewport ( #4263 )
...
* first pass fixes for how entity space is handled in the viewport interaction model
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small updates to simplify space handling
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix for influence group with one entity selected
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some tidy-up and fix for scale manipulator snapping
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* couple of small fixes for scale manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small comment update
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fixes for integration test failures
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add test for rotation manipulator
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add test coverage for rotation manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add tests for translation manipulators and some other tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add tests for translating a group of entities
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add some tests for scale manipulators
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some updates and formatting changes (clang-format) to ViewportScreen
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* simplify usage of lround code
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update missed name updates
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update usage of WorldToScreenNdc
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* some more small tidy-up changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* move static variables to be marked inline
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small formatting fixes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-28 09:26:20 +01:00
527508ce66
Merge pull request #4270 from aws-lumberyard-dev/daimini/FocusMode/selection
...
LYN-5297 | Focus Mode - When a Prefab is selected other entities outside the Prefab hierarchy should not be selectable
2021-09-27 13:02:34 -05:00
8e92ed14df
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/selection
2021-09-27 09:29:49 -07:00
b9bd17f2ae
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/setup_tests
2021-09-27 08:39:36 -07:00
c75f3690da
Product/Source differentiation AssetBrowser Search View. ( #4144 )
...
* Added whole row highlight
Signed-off-by: igarri <igarri@amazon.com >
* Applied code review changes
Signed-off-by: igarri <igarri@amazon.com >
* Addressed code review comments
Signed-off-by: igarri <igarri@amazon.com >
* fixed QPointers
Signed-off-by: igarri <igarri@amazon.com >
* Added indentation to child items
Signed-off-by: igarri <igarri@amazon.com >
* Added Branch Icons
Signed-off-by: igarri <igarri@amazon.com >
* Loading icons and keeping a reference.
Signed-off-by: igarri <igarri@amazon.com >
* Fixed typos
Signed-off-by: igarri <igarri@amazon.com >
* Fixed TableView Header
Signed-off-by: igarri <igarri@amazon.com >
* Cleaned up Delegate Paint
Signed-off-by: igarri <igarri@amazon.com >
* Fixed view style
Signed-off-by: igarri <igarri@amazon.com >
* small tweaks
Signed-off-by: igarri <igarri@amazon.com >
* Added Assert
Signed-off-by: igarri <igarri@amazon.com >
* Small tweak in Table Model
Signed-off-by: igarri <igarri@amazon.com >
* Code Review Feedback
Signed-off-by: igarri <igarri@amazon.com >
* Code review Comments
Signed-off-by: igarri <igarri@amazon.com >
* Removed Comment
Signed-off-by: igarri <igarri@amazon.com >
2021-09-27 10:43:08 +01:00
f7e964c91d
Better replacement for EntityId checks
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 16:35:48 -07:00
80e6a6903a
Remove unused CreateEditorEntity function
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:55:02 -07:00
72110e40cf
Add Unit tests for EditorFocusMode and PrefabFocus. Minor change to PrefabFocusHandler to avoid instantiating a new AZ::EntityId() for checks.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-24 15:05:34 -07:00
03372d2ea9
Made IsInFocusSubTree const, and other minor refactorings.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-23 12:50:49 -07:00
23357b4c93
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/selection
2021-09-23 12:28:31 -07:00
d10cf1e495
Add guard against edge case.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-23 10:47:21 -07:00
3fdf1f052a
Minor comments and whitespace fixes.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 16:46:21 -07:00
1dd58511c1
Remove FocusModeFramework nested namespace
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 14:18:19 -07:00
368c325613
Disable selection of "out of focus" entities in both Outliner and Viewport. Refactor hover/selection rect painting for branches in the Outliner to fix disabled hover state.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 14:18:16 -07:00
4ae95719de
Initialization changes to pass unit tests. Some interfaces are now retrieved on demand and there's clearer failure paths that don't involve asserts to better handle test/headless initializations.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-22 12:44:18 -07:00
305e62380a
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/setup
2021-09-22 10:03:42 -07:00
b865d2aec1
Add support for camera reference frames to support camera yaw in certain situations ( #4088 )
...
* proof of concept change for fixing camera yaw rotation being ignored
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates to fully support camera roll
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* small fixes for PR
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* undo changes in EditorCameraComponent
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add test to verify interaction between editor viewport view entity change and modular camera controller
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add additional tests for updated camera behaviors
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* revert change to Camera Gem Output Name
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* move location of new files
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix tab/spaces issue
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove static from potentially unused functions
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* set camera lib name in CMakeLists.txt file
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* cosmetic CMakeLists.txt change
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-22 09:08:24 +01:00
ceed8f692b
Do not assert if m_focusModeInterface can't be initialized
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 17:16:27 -07:00
f14e8d6eac
Fix header formatting to pass validation
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 15:06:29 -07:00
107732d057
Remove pragma once from cpp file
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 13:45:39 -07:00
df10b56f2a
ClearFocusRoot implementation
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 10:47:02 -07:00
5a4476a0e4
Minor fixes to variable names and comments.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 10:26:41 -07:00
b8c78caa2f
Remove nested FocusModeFramework namespace
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-21 09:48:09 -07:00
29d7fcb55e
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/setup
2021-09-21 09:41:36 -07:00
7fca57a169
Fixed Assert ( #4234 )
...
Signed-off-by: igarri <igarri@amazon.com >
2021-09-21 14:55:10 +01:00
489a93cf91
Remove assert for edge case that can actually happen in normal circumstances, simply return false in those cases.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-20 13:44:25 -07:00
71bf614912
Changed FocusOnOwningPrefab to return Outcome. Added comments and error checking.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-20 12:18:23 -07:00
bd6705a06e
Merge branch 'development' of https://github.com/o3de/o3de into daimini/FocusMode/setup
2021-09-20 11:58:39 -07:00
594981f130
Remove the PrefabEditManager. Introduce the FocusMode system on the Editor side, and a PrefabFocusHandler on the Prefab side to handle focus.
...
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-20 11:58:31 -07:00
4aff76343f
Provisional implemenation and testing of central state tracker to track viewport editing modes. ( #4112 )
...
* Provisional impl and testing of central state tracker.
Signed-off-by: John <jonawals@amazon.com >
* Add missing namespace comment.
Signed-off-by: John <jonawals@amazon.com >
* ViewportEditorModeState -> ViewportEditorModes
Signed-off-by: John <jonawals@amazon.com >
* ViewportEditorModesTracker -> ViewportEditorModeTracker
Signed-off-by: John <jonawals@amazon.com >
* GetEditorModeState ->GetViewportEditorModes
Signed-off-by: John <jonawals@amazon.com >
* GetNumTrackedViewports -> GetTrackedViewportCount
Signed-off-by: John <jonawals@amazon.com >
* IsViewportStateBeingTracked -> IsViewportModeTracked
Signed-off-by: John <jonawals@amazon.com >
* Fix API comments.
Signed-off-by: John <jonawals@amazon.com >
* Delete hangover file.
Signed-off-by: John <jonawals@amazon.com >
* Delete more hangover files.
Signed-off-by: John <jonawals@amazon.com >
* Minor member name refactor.
Signed-off-by: John <jonawals@amazon.com >
* Refactor nonclemanture.
Signed-off-by: John <jonawals@amazon.com >
* Rename Enter/ExitMode to Register/UnregisterMode.
Signed-off-by: John <jonawals@amazon.com >
* Error and warning msgs now return AZ::Outcomes.
Signed-off-by: John <jonawals@amazon.com >
* Change all nomenclature to Activate/Deactivate for consistency.
Signed-off-by: John <jonawals@amazon.com >
* Change tense of notification bus methods.
Signed-off-by: John <jonawals@amazon.com >
* Fix malformed string format.
Signed-off-by: John <jonawals@amazon.com >
* Fix malformed string format (again).
Signed-off-by: John <jonawals@amazon.com >
* Fix Linux warning.
Signed-off-by: John <jonawals@amazon.com >
2021-09-20 17:37:09 +01:00
b3db885ae5
Switched over to AzQtComponents::TableView ( #3949 )
...
Signed-off-by: igarri <igarri@amazon.com >
2021-09-20 11:10:55 +01:00
de9a27597b
Additional test support for Manipulator Ditto commands ( #4191 )
...
* additional test support for manipulator ditto
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* tidy-up to changes
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix for non-unity build compile error
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-20 09:49:01 +01:00
4167bb6cde
Warning System Changes (polish) Redo ( #4009 )
...
* Restores the branch to the old status from old branch
Signed-off-by: aaguilea <aaguilea@amazon.com >
* Changes that didnt make it from merge manually fixed
Signed-off-by: aaguilea <aaguilea@amazon.com >
* forgot one
Signed-off-by: aaguilea <aaguilea@amazon.com >
* Added Ebus in order to remove rigidbody's dependencies
Signed-off-by: aaguilea <aaguilea@amazon.com >
* answering some of the comments in the PR
Signed-off-by: aaguilea <aaguilea@amazon.com >
* Small typo changed
Signed-off-by: aaguilea <aaguilea@amazon.com >
2021-09-17 14:49:48 +01:00
58c227ceb1
Implemented C++23 deleted nullptr_t constructor/assignment for AZStd string classes ( #4158 )
...
* Added string and string_view class constructor overloads which is deleted that prevents initializing them from a nullptr or an integer type
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Fixed locations where string and string_view were initialized with
nullptr
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
* Fix IArchive::IsInstalledToHDD signature
Updated calls to ConvertAbsolutePathToAliasedPath to use an
list initialization instead of nullptr
Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com >
2021-09-16 12:50:18 -05:00
7e85b1512a
Expose sticky select option to the SettingsRegistry and disable by default ( #4149 )
...
* expose sticky select option to the SettingsRegistry
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update missed callsites after API change to Manipulator Test Framework
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-16 09:14:37 +01:00
a8908a987a
Fixing Save level As template path ( #4054 )
...
* Fixing Save level As template path
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* CR Feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* CR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* PR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* remove emplace
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
* more PR feedback
Signed-off-by: Mikhail Naumov <mnaumov@amazon.com >
2021-09-15 17:19:01 -07:00
bbe437819b
Enables override/virtual warnings
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-15 14:11:17 -07:00
52095e3e16
Ensure undo/redo operation for change entity selection is atomic ( #4122 )
2021-09-15 11:12:26 +01:00
36b7cb2814
Merge branch 'development' into cmake/warn_virtual
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Framework/AzCore/AzCore/Memory/HeapSchema.h
# Code/Framework/AzCore/AzCore/Memory/HphaSchema.h
# Code/Framework/AzCore/AzCore/Memory/MallocSchema.h
# Code/Framework/AzCore/AzCore/Memory/OverrunDetectionAllocator.h
2021-09-14 15:32:35 -07:00
c0426ba465
PerScreenDpi | QLabels incorrectly handle scale for icons ( #4070 )
...
* Fixes to icon generation. Generating a pixmap out of a size won't take the screen scaling factor into account, resulting in blurry results.
Note that this is not a catchall solution, every case needs to be addressed manually.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* HighDpi fixes for startup splashscreen and About dialog
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
* Add helper function to generate appropriate pixmaps for a screen based on its dpi settings.
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com >
2021-09-14 20:35:56 +01:00
ee2e728760
Merge branch 'development' into cmake/warn_virtual
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
2021-09-14 10:28:58 -07:00
9d2352c3b7
Update the viewport interaction model to support single click select ( #4094 )
...
* add support for single click select
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant profile macro
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* updates following review feedback
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* fix behaviour for fallthrough to match previous code
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-14 13:24:01 +01:00
1e3c8edc40
Remove viewport freeze request bus ( #4089 )
...
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-13 18:04:20 +01:00
972944e762
Merge branch 'development' into cmake/warn_virtual
...
Signed-off-by: Esteban Papp <81431996+amznestebanpapp@users.noreply.github.com >
# Conflicts:
# Code/Editor/Viewport.h
2021-09-13 08:59:24 -07:00
d884eef0f4
Merge pull request #4040 from aws-lumberyard-dev/automation_improv
...
Added EntityExists for automation
2021-09-13 17:14:35 +02:00
7a58b72f15
Add remaining integration tests for viewport selection (box select) ( #4075 )
...
* updates to viewport box select tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* add interface for querying keyboard modifiers
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant casts
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update formatting options for trace functions in ActionDispatcher
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* remove redundant GetKeyboardModifiers call
Signed-off-by: hultonha <hultonha@amazon.co.uk >
* update how trace/log functions have been fixed to output during tests
Signed-off-by: hultonha <hultonha@amazon.co.uk >
2021-09-13 15:19:46 +01:00
Chris Galvan
Mikhail Naumov
Danilo Aimini
AMZN-Igarri
hultonha
jonawals
AMZN-Alexandre Corcia Aguilera
lumberyard-employee-dm
Esteban Papp
AMZN-AlexOteiza