Commit Graph

9933 Commits

Author SHA1 Message Date
Gene Walters b19f96f1fe Small safety check. It's unlikely, but possible, that a component is created and not assigned to an entity.
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:53:41 -08:00
Gene Walters b50739f55e Small tweak to assert back to match existing format
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:06:04 -08:00
Gene Walters 4f9d4b7045 Improved logged to print entity name if improperly deleted; helps when debugging to find the problem entity
Signed-off-by: Gene Walters <genewalt@amazon.com>
2021-12-06 09:02:15 -08:00
lumberyard-employee-dm c3fdbfb926 Updated the ComponentApplication Settings Registry initialization to no (#6108)
longer read form the users `~/.o3de/Registry` directory in non
debug/profile configurations.

Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
2021-12-03 11:55:23 -06:00
amzn-mike 5f41463cd6 Procedural Prefabs: Add PhysX mesh group support and example (#6073)
* Auto LOD script setup

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Working auto LODs

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Correctly selected LODs and added default prefab

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Cleanup code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Cleanup code

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add missing legal header, move name cleanup to scene_helpers, add documentation

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add PhysX mesh group support.

Updated example script to show usage

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Add a physics collider component

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>

* Update DefaultOrValue call

Signed-off-by: amzn-mike <80125227+amzn-mike@users.noreply.github.com>
2021-12-03 09:23:48 -08:00
Allen Jackson 8186c268e3 {lyn7298} removing PythonBuilderRequestBus from PythonAssetBuilder (#6115)
* {lyn7298} removing PythonBuilderRequestBus from PythonAssetBuilder

* PythonBuilderRequestBus is a depreciated event bus
* removing the unsupported API

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>

* removing the PythonBuilderRequestBus_Behavior_Exists test

Signed-off-by: Allen Jackson <23512001+jackalbe@users.noreply.github.com>
2021-12-03 11:21:33 -06:00
Michael Pollind 75c015b67e chore: add #prama once to XcbInputDeviceKeyboard (#6091)
Signed-off-by: Michael Pollind <mpollind@gmail.com>
2021-12-03 09:09:02 -08:00
sphrose 1962083c72 Merge pull request #4955 from aws-lumberyard-dev/terrain/sphrose_test_terrain_gradient_list_LYN-7376
Python tests for TerrainHeightGradientList LYN-7376
2021-12-03 15:42:02 +00:00
Luis Sempé 9db83814f2 Merge pull request #6045 from aws-lumberyard-dev/scripting/fix_translation_reload
If the asset catalog gets reloaded, clear the translation to avoid du…
2021-12-03 07:36:54 -08:00
Tom Hulton-Harrop 8344539ab6 Manipulator Bounds updates (#5959)
* first pass updates to improve manipulators

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add setting to enable/disable manipulator axis flipping

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* update manipulator cvar to use ed_ naming convention

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* wip updates to add AzToolsFramework values to the SettingsRegistry

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* expose a number of manipulator settings for configuration

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add setting for manipulator base scale to change size of all manipulators together

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* minor updates before posting PR

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* add manipulator section for settings registry paths

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* fix for failing unit test after manipulator changes

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* fix total scale

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>

* fix for polygon prism component shape tests

Signed-off-by: Tom Hulton-Harrop <82228511+hultonha@users.noreply.github.com>
2021-12-03 14:46:15 +00:00
sphrose d24f01a413 compile fix
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-12-03 14:10:23 +00:00
sphrose 1ed0b4f8ff Replace } lost in merge
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-12-03 12:15:56 +00:00
sphrose 4e5b62ee25 conflict fix
Signed-off-by: sphrose <82213493+sphrose@users.noreply.github.com>
2021-12-03 11:36:58 +00:00
moraaar 8f4ff91915 Merge pull request #6050 from aws-lumberyard-dev/daimini/physicsMaterialNameCrash
Add additional check to ensure material library is loaded when trying to retrieve names.
2021-12-03 11:25:25 +00:00
Mike Chang cfb426b86c Add conditional to pull O3DE_BUILD_VERSION through environment var (#6096)
Signed-off-by: Mike Chang <changml@amazon.com>
2021-12-02 17:05:42 -08:00
Danilo Aimini 5c4f287b79 Mark physmaterial assets as critical
Signed-off-by: Danilo Aimini <82231674+AMZN-daimini@users.noreply.github.com>
2021-12-02 16:44:29 -08:00
lsemp3d 88b6e52248 Fixed support for AZEvent name generation
Signed-off-by: lsemp3d <58790905+lsemp3d@users.noreply.github.com>
2021-12-02 16:43:21 -08:00
tjmgd 631ebacc0c Fix for bug - switch association fails (#5947)
* Fix for bug - switch association fails

Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

* Change message box button from 'Yes' to 'Ok'

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

* Changed message box button from 'Yes' to 'Ok'

Signed-off-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>

Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
Co-authored-by: amzn-phist <52085794+amzn-phist@users.noreply.github.com>
2021-12-02 15:50:51 -08:00
Qing Tao f56bbb96b0 LYN-5843. Fixed an issue when exit from full screen game mode in Editor. (#6098)
* LYN-5843. Fixed an issue when exit from full screen game mode.

Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
2021-12-02 15:38:24 -08:00
michabr 4d5aad13d1 Remove legacy renderer dependencies in LyShine and move LyShine headers to gem (#6049)
* Remove CryRenderer dependencies

Signed-off-by: abrmich <abrmich@amazon.com>

* Fix non-unity compile error

Signed-off-by: abrmich <abrmich@amazon.com>

* Remove ITexture.h reference

Signed-off-by: abrmich <abrmich@amazon.com>

* Simple file moves from CryCommon to LyShine Gem

Signed-off-by: abrmich <abrmich@amazon.com>

* More simple file moves from CryCommon to LyShine Gem

Signed-off-by: abrmich <abrmich@amazon.com>

* Move more headers from CryCommon to LyShine Gem

Signed-off-by: abrmich <abrmich@amazon.com>

* Add LyShine gem module as a build dependency to fix compile error in some gems

Signed-off-by: abrmich <abrmich@amazon.com>
2021-12-02 14:47:32 -08:00
Roman 28f38ca009 Update the deformer in the atom debug draw (#6095)
Signed-off-by: rhhong <rhhong@amazon.com>
2021-12-02 14:15:59 -08:00
amzn-sj e407191b64 Update AWS package version for MacOS (#6058)
Signed-off-by: amzn-sj <srikkant@amazon.com>
2021-12-02 16:15:27 -06:00
Guthrie Adams 4079b253b6 Merge pull request #6106 from aws-lumberyard-dev/Atom/guthadam/fix_warnings_from_unreflected_system_components
Fixing warnings caused by system components not added to serialize context
2021-12-02 16:06:25 -06:00
LesaelR 0498e4a9c3 Added an assert to verify AP and AP Batch close on teardown. (#5891)
* Added an assert to verify AP and AP Batch close on teardown.

Signed-off-by: Rosario Cox <lesaelr@amazon.com>

* Removed ".exe" from assert to ensure it works on any platform
Fixed missing set of parenthesis in the assert
Added "AssetBuilder" to the assert to ensure assetbuilders have closed correctly

Signed-off-by: Rosario Cox <lesaelr@amazon.com>

* Moving the helper function from asset_processor_fixture to asset_processor_utils.
Changed individual process_utils calls into a single call with a list.

Signed-off-by: Rosario Cox <lesaelr@amazon.com>

* Added the missing references.

Signed-off-by: Rosario Cox <lesaelr@amazon.com>
2021-12-02 13:48:30 -08:00
bosnichd 7a0282a534 Fix debug ImGui asserts I introduced in [b2c13b2]. (#6104)
Also allow different D3D12_ROOT_SIGNATURE flags to be set for each platform.

Signed-off-by: bosnichd <bosnichd@amazon.com>
2021-12-02 14:17:12 -07:00
Guthrie Adams 82b1b6f337 Merge pull request #6102 from aws-lumberyard-dev/Atom/guthadam/remove_preset_warnings_from_material_editor
Removing warnings from material editor viewport
2021-12-02 14:42:18 -06:00
Guthrie Adams 50f094c51e Fixing warnings caused by system components not added to serialize context
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type MultiplayerToolsSystemComponent not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]
==================================================================
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Trace::Warning
 D:/projects/lyengine/git/ly-dev/o3de/Code/Framework/AzCore/AzCore/Module/ModuleManager.cpp(34): 'bool __cdecl AZ::ShouldUseSystemComponent(const class AZ::ComponentDescriptor &,const class AZStd::vector<class AZ::Crc32,class AZStd::allocator> &,const class AZ::SerializeContext &)'
2021-11-30T20:21:23{000000000000395C}[Module Manager]     Component type PythonEditorFuncs not reflected to SerializeContext!
2021-11-30T20:21:23{000000000000395C}[Module Manager]     ==================================================================

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-12-02 14:34:36 -06:00
Guthrie Adams d0d26ab56f Merge pull request #6097 from aws-lumberyard-dev/Atom/guthadam/prevent_python_asset_builder_from_activating_in_editor
Removing PythonAssetBuilderSystemComponent from GetRequiredSystemComponents
2021-12-02 13:58:55 -06:00
antonmic 827d3d930b Merge pull request #6088 from aws-lumberyard-dev/Atom/antonmic/DepthOfFieldVulkanFix
Atom/antonmic/depth of field vulkan fix
2021-12-02 11:26:50 -08:00
Guthrie Adams 74cc3ccc20 Removing warnings from material editor viewport
Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-12-02 13:05:02 -06:00
tjmgd ba9ae77023 Bug - association update (#5932)
* Fixed crash when typing asset name and clicking browse (#5495)

Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

* Fixed issue where associated control disappears after clicking Save

Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

Co-authored-by: AMZN-AlexOteiza <82234181+AMZN-AlexOteiza@users.noreply.github.com>
Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
2021-12-02 10:55:05 -08:00
tjmgd 11357fbf9f Fix for bug preventing undo function working correctly (#5937)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>
2021-12-02 10:54:58 -08:00
tjmgd 0842eae3a0 Fix for inappropriate data being used to calc position of audio listerner (#5941)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>
2021-12-02 10:54:51 -08:00
tjmgd ce717ad48a Improvement to filter types (optimization) (#5944)
Signed-off-by: T.J. McGrath-Daly <tj.mcgrath.daly@huawei.com>

Co-authored-by: Tobias Alexander Franke <tobias.alexander.franke@huawei.com>
2021-12-02 10:54:40 -08:00
Guthrie Adams dea512f02f Removing PythonAssetBuilderSystemComponent from GetRequiredSystemComponents
This change was prompted by the Python asset builder activating in the material editor and asset processor, leading to conflicts as both initialized, started Python, spamming the console window and log with warnings while trying to save module symbol information.
Because PythonAssetBuilderSystemComponent also has a SystemComponentTag attribute declaring it as an AssetBuilder, it will still be discovered and automatically added to the asset builder.
Removing it from GetRequiredSystemComponents will stop the component from activating outside of the asset builder.

Signed-off-by: Guthrie Adams <guthadam@amazon.com>
2021-12-02 12:37:31 -06:00
Luis Sempé ed4498ebe5 Merge pull request #5943 from tjmgd/bug-delete-event-h
Fixed bug  when deleting event
2021-12-02 10:23:51 -08:00
Steve Pham bd1a4a3062 Removed trait AZ_TRAIT_DISABLE_FAILED_INPUT_TESTS
* Removed trait AZ_TRAIT_DISABLE_FAILED_INPUT_TESTS (#6078)
* Added check for gamepad support
* Skip tests that rely on gamepad support on platforms that dont support it
* Use GTEST_SKIP(() if available, otherwise just use SUCCEED()

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-02 10:20:55 -08:00
antonmic f82604406c merging dev because AR failed for mysterious reasons
Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
2021-12-02 09:47:08 -08:00
mrieggeramzn bce5e36b53 Fix for artifact with thin-film materials and shadows (#6016)
* *BackL*.azsli

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* refactoring from feedback

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-12-02 09:27:01 -08:00
mrieggeramzn f4f7f07721 shadow fixes (#5890)
* shadow fixes

Signed-off-by: Michael Riegger <mriegger@amazon.com>

* Adding missing line

Signed-off-by: Michael Riegger <mriegger@amazon.com>

* Adding point sampler

Signed-off-by: Michael Riegger <mriegger@amazon.com>

* feedback from pr

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* better variable name

Signed-off-by: mrieggeramzn <mriegger@amazon.com>

* Fix compile error

Signed-off-by: mrieggeramzn <mriegger@amazon.com>
2021-12-02 09:26:34 -08:00
Steve Pham d89dcff7df Fix failing zero color conversion test on Linux
* Removed AZ_TRAIT_DISABLE_FAILED_ZERO_COLOR_CONVERSION_TEST (#6074)
* Protect against 'NaN' (divide by zero) for saturation calculations by setting value to zero instead

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
2021-12-02 08:50:03 -08:00
SWMasterson 0116f0a520 Adding Macbeth level to AutomatedTesting and converting to Prefab (#6060)
* Adding macbeth level to AutomatedTesting

Signed-off-by: Sean Masterson <semaster@amazon.com>

* removing unnecessary files

Signed-off-by: Sean Masterson <semaster@amazon.com>
2021-12-02 08:26:56 -08:00
Luis Sempé 3c624b6d96 Merge pull request #5935 from tjmgd/bug-render-anim-h
Fix for animation window render options not being persistent
2021-12-02 08:12:18 -08:00
Luis Sempé cf073dc303 Merge pull request #5823 from pollend/bugfix/5552-LyShine-Transform2d-Overlapping-Anchors
UI Editor - bugfix: prevent Anchor buttons from overlapping when shrinking layout(#5552)
2021-12-02 08:11:45 -08:00
Luis Sempé e146299a83 Merge pull request #5911 from tjmgd/bug-motion-set-removal-h
Bug motion set removal h
2021-12-02 08:10:56 -08:00
srikappa-amzn 625fca71ab Prefab/unit tests for deletion (#6034)
* Added tests for deleting entity under level and other prefabs

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Added class comments and improved variable names

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Called the reflect function of PrefabFocusHandler from PrefabSystemComponent

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Added couple of unit tests around entity and prefab deletion

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Used engine root path from settings registry as fake path for prefab creation

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>

* Added 2 unit tests around deleting prefabs

Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
2021-12-02 08:09:28 -08:00
greerdv 6150a60e57 Merge pull request #6030 from aws-lumberyard-dev/ragdoll-collider-alignment
fix alignment of autosized ragdoll colliders
2021-12-02 11:13:38 +00:00
sphrose 0e5c9c3867 Merge pull request #5908 from aws-lumberyard-dev/terrain/sphrose/reference_shape
LYN-7693 Rename and move vegetation reference shape.
2021-12-02 10:09:05 +00:00
greerdv dbba71fe3a merge from development
Signed-off-by: greerdv <greerdv@amazon.com>
2021-12-02 09:55:37 +00:00
Michael Pollind bd1c8ec961 chore: remove duplicate instance of FancyDockingDropZoneConstants (#5827)
* chore: remove duplicate instance of FancyDockingDropZoneConstants

Signed-off-by: Michael Pollind <mpollind@gmail.com>

* chore: move to namespace

Signed-off-by: Michael Pollind <mpollind@gmail.com>
2021-12-02 09:28:29 +00:00